mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH 0/2] ifupdown: Remove not used hook folders again
Date: Wed,  3 Apr 2024 12:08:54 +0200	[thread overview]
Message-ID: <20240403100856.46337-1-ada@thorsis.com> (raw)

After putting a script in /etc/network/if-post-up.d and wondering why it
was not executed I found myself in a strange rabbit hole.

busybox added support for the folders post-up and pre-down with 1.20.0
and according to the two patches reverted now, complained when those
where missing.  So after upgrading to busybox 1.20.1 for
ptxdist-2012.07.0 those folders where created from ptxdist-2012.08.0
onwards.

That busybox feature seemed to be incompatible with how Debian ifupdown
(the original one) handles things, which considers those folders as
aliases only.  The claim "Treat post-up and pre-down as aliases for up
and down." is probably only related to things you can set in file
/etc/network/interfaces per interface, so post-up and pre-down probably
work from interfaces but not from hook folders.  The Debian manpage also
says this:

> Please note that as post-up and pre-down are aliases, no files in the
> corresponding directories are processed.  Please use if-up.d and
> if-down.d directories instead.

So busybox 1.21.0 removed executing scripts from post-up and pre-down
folders again, without explicitly making that clear, only stating it
would improve compatibility to Debian.  With busybox 1.21.0 those
warnings where gone again if those folders are not present, so from the
hook script point of view everything as before 1.20.0.

That update to busybox 1.21.0 came with ptxdist-2013.07.0 one year later
and from then on we had two useless folders.  Removing those now to
avoid further confusion.

Link: https://git.busybox.net/busybox/commit/?id=dd82443b921111d7f5570fddc2eaeb634f1f971d
Link: https://git.busybox.net/busybox/commit/?id=3a9365e2732f5df2cdef758bc1f6e5e9da8fbcef

Alexander Dahl (2):
  Revert "initmethod-bbinit: add more empty folders for ifupdown"
  Revert "initmethod-systemd: add more empty folders for ifupdown"

 rules/initmethod-bbinit.make  | 2 --
 rules/initmethod-systemd.make | 2 --
 2 files changed, 4 deletions(-)


base-commit: e7e42d3b81e1244a33533b9c7a6e41d8da5d7769
-- 
2.39.2




             reply	other threads:[~2024-04-03 10:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 10:08 Alexander Dahl [this message]
2024-04-03 10:08 ` [ptxdist] [PATCH 1/2] Revert "initmethod-bbinit: add more empty folders for ifupdown" Alexander Dahl
2024-04-08 11:05   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-04-03 10:08 ` [ptxdist] [PATCH 2/2] Revert "initmethod-systemd: " Alexander Dahl
2024-04-08 11:05   ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403100856.46337-1-ada@thorsis.com \
    --to=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox