From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 03 Apr 2024 12:09:28 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rrxYe-005mLE-02 for lore@lore.pengutronix.de; Wed, 03 Apr 2024 12:09:28 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rrxYd-0006Up-Py; Wed, 03 Apr 2024 12:09:27 +0200 Received: from mail.thorsis.com ([2003:a:e28:26e4::10]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrxYG-0006RW-B4 for ptxdist@pengutronix.de; Wed, 03 Apr 2024 12:09:07 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5237A148BCF2 for ; Wed, 3 Apr 2024 12:08:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1712138939; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding; bh=s3xQNqno2unmKyN6NvHC/vzwLrLQRkUV1Ub8HMqZgl0=; b=W5Etcb1FykwqJb3DX2f1hrmaMKKmf+CatP/nHhJCSvlWETWpwhO7Jr1ZmM6tChd93uWteA qomOAZR3C5rkgYp2euJsdm01Y+iixz1I4q4OXyywAzZYy0FB9z4aQ6nQFDL2Hf920lUiZS yDIxo/2RAni30VRUp9acanlPmP3p3MK7Rn6PH4plfIwe1xbzsgrJuYVeaxYZxtChgAz0kF D3OODmw9WSOXHfsKt4lK0LJHNparjLvcAaQ61q2rikwLQIeNJawaXXmEcfOQJXryDdhl8p Hs7Nt9E7ca6RLMiI+nKnvDG+IrshRWO/xBsJXoythtPHHnUU5aAOHYwGjW0kaQ== From: Alexander Dahl To: ptxdist@pengutronix.de Date: Wed, 3 Apr 2024 12:08:54 +0200 Message-Id: <20240403100856.46337-1-ada@thorsis.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: [ptxdist] [PATCH 0/2] ifupdown: Remove not used hook folders again X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false After putting a script in /etc/network/if-post-up.d and wondering why it was not executed I found myself in a strange rabbit hole. busybox added support for the folders post-up and pre-down with 1.20.0 and according to the two patches reverted now, complained when those where missing. So after upgrading to busybox 1.20.1 for ptxdist-2012.07.0 those folders where created from ptxdist-2012.08.0 onwards. That busybox feature seemed to be incompatible with how Debian ifupdown (the original one) handles things, which considers those folders as aliases only. The claim "Treat post-up and pre-down as aliases for up and down." is probably only related to things you can set in file /etc/network/interfaces per interface, so post-up and pre-down probably work from interfaces but not from hook folders. The Debian manpage also says this: > Please note that as post-up and pre-down are aliases, no files in the > corresponding directories are processed. Please use if-up.d and > if-down.d directories instead. So busybox 1.21.0 removed executing scripts from post-up and pre-down folders again, without explicitly making that clear, only stating it would improve compatibility to Debian. With busybox 1.21.0 those warnings where gone again if those folders are not present, so from the hook script point of view everything as before 1.20.0. That update to busybox 1.21.0 came with ptxdist-2013.07.0 one year later and from then on we had two useless folders. Removing those now to avoid further confusion. Link: https://git.busybox.net/busybox/commit/?id=dd82443b921111d7f5570fddc2eaeb634f1f971d Link: https://git.busybox.net/busybox/commit/?id=3a9365e2732f5df2cdef758bc1f6e5e9da8fbcef Alexander Dahl (2): Revert "initmethod-bbinit: add more empty folders for ifupdown" Revert "initmethod-systemd: add more empty folders for ifupdown" rules/initmethod-bbinit.make | 2 -- rules/initmethod-systemd.make | 2 -- 2 files changed, 4 deletions(-) base-commit: e7e42d3b81e1244a33533b9c7a6e41d8da5d7769 -- 2.39.2