mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH 0/2] Fix configure.ac for unzip and xz
@ 2024-03-11 13:45 Markus Heidelberg
  2024-03-11 13:45 ` [ptxdist] [PATCH 1/2] configure.ac: fix check for unzip Markus Heidelberg
  2024-03-11 13:45 ` [ptxdist] [PATCH 2/2] configure.ac: add check for xz Markus Heidelberg
  0 siblings, 2 replies; 5+ messages in thread
From: Markus Heidelberg @ 2024-03-11 13:45 UTC (permalink / raw)
  To: ptxdist; +Cc: Markus Heidelberg

I didn't notice the missing "unzip" because of a failing package
download in .zip format, but because of this error:

    ---------------------------------------------
    target: host-system-python3-flit-core.install
    ---------------------------------------------
    
    ptxdist: executing: mkdir -p [...]/packages/host-system-flit_core-3.8.0/usr/lib/system-python3/lib/python3.10/site-packages && unzip -d [...]/packages/host-system-flit_core-3.8.0/usr/lib/system-python3/lib/python3.10/site-packages [...]/build-host/system-flit_core-3.8.0/*.whl && ptxd_make_world_install_python_cleanup_host
    /usr/bin/bash: line 1: unzip: command not found

There are also two outdated packages (ed, ddrescue) using .tar.lz format
for download, but I ignored them now.

Markus Heidelberg (2):
  configure.ac: fix check for unzip
  configure.ac: add check for xz

 configure.ac | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.34.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ptxdist] [PATCH 1/2] configure.ac: fix check for unzip
  2024-03-11 13:45 [ptxdist] [PATCH 0/2] Fix configure.ac for unzip and xz Markus Heidelberg
@ 2024-03-11 13:45 ` Markus Heidelberg
  2024-03-19  6:44   ` [ptxdist] [APPLIED] " Michael Olbrich
  2024-03-11 13:45 ` [ptxdist] [PATCH 2/2] configure.ac: add check for xz Markus Heidelberg
  1 sibling, 1 reply; 5+ messages in thread
From: Markus Heidelberg @ 2024-03-11 13:45 UTC (permalink / raw)
  To: ptxdist; +Cc: Markus Heidelberg

Instead of unzip, gunzip was checked actually:
checking for gunzip... /usr/bin/gunzip

Now it is checked properly:
checking for unzip... /usr/bin/unzip

There are only seven packages using .zip format for download, though.

Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 2499b06fc..dfce4330e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -238,7 +238,7 @@ if test -z "$GUNZIP"; then
 fi
 
 dnl Check for unzip
-AC_PATH_PROGS(UNZIP, gunzip,, $PATH)
+AC_PATH_PROGS(UNZIP, unzip,, $PATH)
 if test -z "$UNZIP"; then
 	AC_MSG_ERROR([unzip could not be found, please install])
 fi
-- 
2.34.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ptxdist] [PATCH 2/2] configure.ac: add check for xz
  2024-03-11 13:45 [ptxdist] [PATCH 0/2] Fix configure.ac for unzip and xz Markus Heidelberg
  2024-03-11 13:45 ` [ptxdist] [PATCH 1/2] configure.ac: fix check for unzip Markus Heidelberg
@ 2024-03-11 13:45 ` Markus Heidelberg
  2024-03-19  6:44   ` [ptxdist] [APPLIED] " Michael Olbrich
  1 sibling, 1 reply; 5+ messages in thread
From: Markus Heidelberg @ 2024-03-11 13:45 UTC (permalink / raw)
  To: ptxdist; +Cc: Markus Heidelberg

Many packages are offered in .tar.xz format for download, so having xz
installed is a hard requirement.

Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
---
 configure.ac | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/configure.ac b/configure.ac
index dfce4330e..70f03f6da 100644
--- a/configure.ac
+++ b/configure.ac
@@ -243,6 +243,12 @@ if test -z "$UNZIP"; then
 	AC_MSG_ERROR([unzip could not be found, please install])
 fi
 
+dnl Check for xz
+AC_PATH_PROGS(XZ, xz,, $PATH)
+if test -z "$XZ"; then
+	AC_MSG_ERROR([xz could not be found, please install])
+fi
+
 dnl Check for wget
 AC_PATH_PROGS(WGET, wget,, $PATH)
 if test -z "$WGET"; then
-- 
2.34.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ptxdist] [APPLIED] configure.ac: fix check for unzip
  2024-03-11 13:45 ` [ptxdist] [PATCH 1/2] configure.ac: fix check for unzip Markus Heidelberg
@ 2024-03-19  6:44   ` Michael Olbrich
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Olbrich @ 2024-03-19  6:44 UTC (permalink / raw)
  To: ptxdist; +Cc: Markus Heidelberg

Thanks, applied as 3a5a24daa17f1979ca47643382fb633fd520e8f5.

Michael

[sent from post-receive hook]

On Tue, 19 Mar 2024 07:44:43 +0100, Markus Heidelberg <m.heidelberg@cab.de> wrote:
> Instead of unzip, gunzip was checked actually:
> checking for gunzip... /usr/bin/gunzip
> 
> Now it is checked properly:
> checking for unzip... /usr/bin/unzip
> 
> There are only seven packages using .zip format for download, though.
> 
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
> Message-Id: <20240311134552.608327-2-m.heidelberg@cab.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/configure.ac b/configure.ac
> index 2499b06fc0be..dfce4330ee8a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -238,7 +238,7 @@ if test -z "$GUNZIP"; then
>  fi
>  
>  dnl Check for unzip
> -AC_PATH_PROGS(UNZIP, gunzip,, $PATH)
> +AC_PATH_PROGS(UNZIP, unzip,, $PATH)
>  if test -z "$UNZIP"; then
>  	AC_MSG_ERROR([unzip could not be found, please install])
>  fi



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ptxdist] [APPLIED] configure.ac: add check for xz
  2024-03-11 13:45 ` [ptxdist] [PATCH 2/2] configure.ac: add check for xz Markus Heidelberg
@ 2024-03-19  6:44   ` Michael Olbrich
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Olbrich @ 2024-03-19  6:44 UTC (permalink / raw)
  To: ptxdist; +Cc: Markus Heidelberg

Thanks, applied as 8fdeb74ae9a47e05b6afec505ac1ebe6056c8260.

Michael

[sent from post-receive hook]

On Tue, 19 Mar 2024 07:44:44 +0100, Markus Heidelberg <m.heidelberg@cab.de> wrote:
> Many packages are offered in .tar.xz format for download, so having xz
> installed is a hard requirement.
> 
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
> Message-Id: <20240311134552.608327-3-m.heidelberg@cab.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/configure.ac b/configure.ac
> index dfce4330ee8a..70f03f6da02d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -243,6 +243,12 @@ if test -z "$UNZIP"; then
>  	AC_MSG_ERROR([unzip could not be found, please install])
>  fi
>  
> +dnl Check for xz
> +AC_PATH_PROGS(XZ, xz,, $PATH)
> +if test -z "$XZ"; then
> +	AC_MSG_ERROR([xz could not be found, please install])
> +fi
> +
>  dnl Check for wget
>  AC_PATH_PROGS(WGET, wget,, $PATH)
>  if test -z "$WGET"; then



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-03-19  6:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 13:45 [ptxdist] [PATCH 0/2] Fix configure.ac for unzip and xz Markus Heidelberg
2024-03-11 13:45 ` [ptxdist] [PATCH 1/2] configure.ac: fix check for unzip Markus Heidelberg
2024-03-19  6:44   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-03-11 13:45 ` [ptxdist] [PATCH 2/2] configure.ac: add check for xz Markus Heidelberg
2024-03-19  6:44   ` [ptxdist] [APPLIED] " Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox