mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] image-hdimg: fix building image without bootloader
@ 2023-10-09 11:37 Roland Hieber
  2023-10-18  7:42 ` [ptxdist] [APPLIED] " Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Roland Hieber @ 2023-10-09 11:37 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

genimage complains that '@GPT_LOCATION@' is an invalid size suffix
because we replace that template variable in the config file only if
IMAGE_HDIMG_BAREBOX, IMAGE_HDIMG_GRUB, or IMAGE_HDIMG_VFAT are selected.
Fix the use case for IMAGE_HDIMG_NONE too.

Fixes: 40a39c7a94d1f8821fab (2023-03-16, "image-hdimg: support using barebox with GPT")
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/image-hdimg.make | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/image-hdimg.make b/rules/image-hdimg.make
index 2aa8aeddaf78..06712ca6d956 100644
--- a/rules/image-hdimg.make
+++ b/rules/image-hdimg.make
@@ -25,6 +25,7 @@ IMAGE_HDIMG_CONFIG	:= hd.config
 
 ifdef PTXCONF_IMAGE_HDIMG
 IMAGE_HDIMG_BOOTLOADER_ENV := \
+	GPT_LOCATION='0' \
 	BOOTLOADER_IMAGES='' \
 	BOOTLOADER_PARTITIONS=''
 
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [APPLIED] image-hdimg: fix building image without bootloader
  2023-10-09 11:37 [ptxdist] [PATCH] image-hdimg: fix building image without bootloader Roland Hieber
@ 2023-10-18  7:42 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2023-10-18  7:42 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as 0bf8bc3cecbdf085e427374dcea4d760951e7822.

Michael

[sent from post-receive hook]

On Wed, 18 Oct 2023 09:42:51 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> genimage complains that '@GPT_LOCATION@' is an invalid size suffix
> because we replace that template variable in the config file only if
> IMAGE_HDIMG_BAREBOX, IMAGE_HDIMG_GRUB, or IMAGE_HDIMG_VFAT are selected.
> Fix the use case for IMAGE_HDIMG_NONE too.
> 
> Fixes: 40a39c7a94d1f8821fab (2023-03-16, "image-hdimg: support using barebox with GPT")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20231009113710.493504-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/image-hdimg.make b/rules/image-hdimg.make
> index 2aa8aeddaf78..06712ca6d956 100644
> --- a/rules/image-hdimg.make
> +++ b/rules/image-hdimg.make
> @@ -25,6 +25,7 @@ IMAGE_HDIMG_CONFIG	:= hd.config
>  
>  ifdef PTXCONF_IMAGE_HDIMG
>  IMAGE_HDIMG_BOOTLOADER_ENV := \
> +	GPT_LOCATION='0' \
>  	BOOTLOADER_IMAGES='' \
>  	BOOTLOADER_PARTITIONS=''
>  



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-18  7:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-09 11:37 [ptxdist] [PATCH] image-hdimg: fix building image without bootloader Roland Hieber
2023-10-18  7:42 ` [ptxdist] [APPLIED] " Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox