* [ptxdist] [PATCH] util-linux: select missing ncurses dependency for fdisk and sfdisk
@ 2023-10-09 15:39 Philipp Zabel
2023-10-18 7:42 ` [ptxdist] [APPLIED] " Michael Olbrich
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2023-10-09 15:39 UTC (permalink / raw)
To: ptxdist; +Cc: Philipp Zabel
These tools depend on ncurses via the internal tcolors library.
Since all fdisks now share the same selected dependencies, consolidate
selections under the shared UTIL_LINUX_FDISKS option.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
rules/util-linux.in | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/rules/util-linux.in b/rules/util-linux.in
index 357aa7e4660a..3cdcad57d65e 100644
--- a/rules/util-linux.in
+++ b/rules/util-linux.in
@@ -29,6 +29,9 @@ config UTIL_LINUX_LIBFDISK
bool
config UTIL_LINUX_FDISKS
+ select UTIL_LINUX_LIBFDISK
+ select UTIL_LINUX_LIBSMARTCOLS
+ select UTIL_LINUX_USES_NCURSES
bool
config UTIL_LINUX_USES_NCURSES
@@ -61,10 +64,7 @@ config UTIL_LINUX_ADDPART
config UTIL_LINUX_CFDISK
bool
- select UTIL_LINUX_LIBFDISK
- select UTIL_LINUX_LIBSMARTCOLS
select UTIL_LINUX_FDISKS
- select UTIL_LINUX_USES_NCURSES
prompt "cfdisk"
help
cfdisk is a curses based program for partitioning any hard disk drive.
@@ -79,8 +79,6 @@ config UTIL_LINUX_DELPART
config UTIL_LINUX_FDISK
bool
prompt "fdisk"
- select UTIL_LINUX_LIBFDISK
- select UTIL_LINUX_LIBSMARTCOLS
select UTIL_LINUX_FDISKS
depends on !BUSYBOX_FDISK || ALLYES
help
@@ -137,8 +135,6 @@ config UTIL_LINUX_PARTX
config UTIL_LINUX_SFDISK
bool
prompt "sfdisk"
- select UTIL_LINUX_LIBFDISK
- select UTIL_LINUX_LIBSMARTCOLS
select UTIL_LINUX_FDISKS
help
sfdisk - Partition table manipulator for Linux,
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ptxdist] [APPLIED] util-linux: select missing ncurses dependency for fdisk and sfdisk
2023-10-09 15:39 [ptxdist] [PATCH] util-linux: select missing ncurses dependency for fdisk and sfdisk Philipp Zabel
@ 2023-10-18 7:42 ` Michael Olbrich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2023-10-18 7:42 UTC (permalink / raw)
To: ptxdist; +Cc: Philipp Zabel
Thanks, applied as 9ee115c14b41e5c484ee6f5fe60783aee36ace03.
Michael
[sent from post-receive hook]
On Wed, 18 Oct 2023 09:42:53 +0200, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> These tools depend on ncurses via the internal tcolors library.
> Since all fdisks now share the same selected dependencies, consolidate
> selections under the shared UTIL_LINUX_FDISKS option.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Message-Id: <20231009153937.915402-1-p.zabel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/util-linux.in b/rules/util-linux.in
> index 357aa7e4660a..3cdcad57d65e 100644
> --- a/rules/util-linux.in
> +++ b/rules/util-linux.in
> @@ -29,6 +29,9 @@ config UTIL_LINUX_LIBFDISK
> bool
>
> config UTIL_LINUX_FDISKS
> + select UTIL_LINUX_LIBFDISK
> + select UTIL_LINUX_LIBSMARTCOLS
> + select UTIL_LINUX_USES_NCURSES
> bool
>
> config UTIL_LINUX_USES_NCURSES
> @@ -61,10 +64,7 @@ config UTIL_LINUX_ADDPART
>
> config UTIL_LINUX_CFDISK
> bool
> - select UTIL_LINUX_LIBFDISK
> - select UTIL_LINUX_LIBSMARTCOLS
> select UTIL_LINUX_FDISKS
> - select UTIL_LINUX_USES_NCURSES
> prompt "cfdisk"
> help
> cfdisk is a curses based program for partitioning any hard disk drive.
> @@ -79,8 +79,6 @@ config UTIL_LINUX_DELPART
> config UTIL_LINUX_FDISK
> bool
> prompt "fdisk"
> - select UTIL_LINUX_LIBFDISK
> - select UTIL_LINUX_LIBSMARTCOLS
> select UTIL_LINUX_FDISKS
> depends on !BUSYBOX_FDISK || ALLYES
> help
> @@ -137,8 +135,6 @@ config UTIL_LINUX_PARTX
> config UTIL_LINUX_SFDISK
> bool
> prompt "sfdisk"
> - select UTIL_LINUX_LIBFDISK
> - select UTIL_LINUX_LIBSMARTCOLS
> select UTIL_LINUX_FDISKS
> help
> sfdisk - Partition table manipulator for Linux,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-18 7:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-09 15:39 [ptxdist] [PATCH] util-linux: select missing ncurses dependency for fdisk and sfdisk Philipp Zabel
2023-10-18 7:42 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox