[ptxdist] Image package creating several files

[ptxdist] Image package creating several files

[Guillermo Rodriguez Garcia]

Hello all,

I have created an image package that signs some files.
This package creates two separate files.

What is the recommended way to handle this? From the documentation
(https://www.ptxdist.org/doc/ref_make_variables.html#image-packages),
I believe that <PKG>_IMAGE is expected to contain the filename of one
single file. For example the "clean" target uses this to know which
file to delete.

How can this be adapted for cases where more than one file is generated?

Thanks,

Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

Re: [ptxdist] Image package creating several files

[Christian Melki]

Hi.

On 3/8/23 16:56, Guillermo Rodriguez Garcia wrote:
> Hello all,
> 
> I have created an image package that signs some files.
> This package creates two separate files.
> 
> What is the recommended way to handle this? From the documentation
> (https://www.ptxdist.org/doc/ref_make_variables.html#image-packages),
> I believe that <PKG>_IMAGE is expected to contain the filename of one
> single file. For example the "clean" target uses this to know which
> file to delete.
> 
> How can this be adapted for cases where more than one file is generated?
> 

Not sure what you mean by <PKG>_IMAGE. But iirc,
barebox (etc) image installing packages handle this.
The rules can install multiple files into image directories and are
capable of cleaning up after themselves.

> Thanks,
> 
> Guillermo Rodriguez Garcia
> guille.rodriguez@gmail.com
> 

Re: [ptxdist] Image package creating several files

[Guillermo Rodriguez Garcia]

Hi Christian,

El mié, 8 mar 2023 a las 18:49, Christian Melki
(<christian.melki@t2data.com>) escribió:
>
> Hi.
>
> On 3/8/23 16:56, Guillermo Rodriguez Garcia wrote:
> > Hello all,
> >
> > I have created an image package that signs some files.
> > This package creates two separate files.
> >
> > What is the recommended way to handle this? From the documentation
> > (https://www.ptxdist.org/doc/ref_make_variables.html#image-packages),
> > I believe that <PKG>_IMAGE is expected to contain the filename of one
> > single file. For example the "clean" target uses this to know which
> > file to delete.
> >
> > How can this be adapted for cases where more than one file is generated?
> >
>
> Not sure what you mean by <PKG>_IMAGE. But iirc,
> barebox (etc) image installing packages handle this.
> The rules can install multiple files into image directories and are
> capable of cleaning up after themselves.

Yes but that is a "regular" package.
I am referring to "image packages", which are a bit different; see the
documentation here:
https://www.ptxdist.org/doc/ref_make_variables.html#image-packages

In these packages, the <PKG>_IMAGE variable points to a file (the
image that is created by the rule). The clean target is automatically
generated based on this variable. My question is how to do this if the
package generates more than one image.

BR,

Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

Re: [ptxdist] Image package creating several files

[Michael Olbrich]

Hi,

On Wed, Mar 08, 2023 at 07:05:55PM +0100, Guillermo Rodriguez Garcia wrote:
> El mié, 8 mar 2023 a las 18:49, Christian Melki
> (<christian.melki@t2data.com>) escribió:
> > On 3/8/23 16:56, Guillermo Rodriguez Garcia wrote:
> > > Hello all,
> > >
> > > I have created an image package that signs some files.
> > > This package creates two separate files.
> > >
> > > What is the recommended way to handle this? From the documentation
> > > (https://www.ptxdist.org/doc/ref_make_variables.html#image-packages),
> > > I believe that <PKG>_IMAGE is expected to contain the filename of one
> > > single file. For example the "clean" target uses this to know which
> > > file to delete.
> > >
> > > How can this be adapted for cases where more than one file is generated?
> > >
> >
> > Not sure what you mean by <PKG>_IMAGE. But iirc,
> > barebox (etc) image installing packages handle this.
> > The rules can install multiple files into image directories and are
> > capable of cleaning up after themselves.
> 
> Yes but that is a "regular" package.
> I am referring to "image packages", which are a bit different; see the
> documentation here:
> https://www.ptxdist.org/doc/ref_make_variables.html#image-packages
> 
> In these packages, the <PKG>_IMAGE variable points to a file (the
> image that is created by the rule). The clean target is automatically
> generated based on this variable. My question is how to do this if the
> package generates more than one image.

You should be able to use ptx/image-install in the image rule. Just like
regular packages. File installed with this are recorded and later removed
in the clean stage.

Note that generating more than one file in an image rule can cause problems
with dependencies because PTXdist doesn't know about the extra files.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |