Re: [ptxdist] [PATCH] util-linux: add an option to enable rfkill

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Dec 08, 2022 at 01:53:13PM +0100, Christian Melki wrote:
> Hi Philipp,
> 
> 
> On 12/8/22 1:38 PM, Philipp Zabel wrote:
> > Add a configuration option UTIL_LINUX_RFKILL to enable the rfkill tool.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >   rules/util-linux.in   | 9 +++++++++
> >   rules/util-linux.make | 3 ++-
> >   2 files changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/rules/util-linux.in b/rules/util-linux.in
> > index 429473404a14..bf83def65f42 100644
> > --- a/rules/util-linux.in
> > +++ b/rules/util-linux.in
> > @@ -468,6 +468,15 @@ config UTIL_LINUX_READPROFILE
> >   comment "BusyBox' readprofile is selected!"
> >   	depends on BUSYBOX_READPROFILE
> > +config UTIL_LINUX_RFKILL
> > +	bool
> > +	prompt "rfkill"
> > +	select UTIL_LINUX_LIBSMARTCOLS
> 
> Looks like busybox has a rfkill too?
> PTXCONF_BUSYBOX_RFKILL

Indeed, so you need to add the conflict check.

Michael

> > +	help
> > +	  rfkill is a simple tool for accessing the Linux rfkill device
> > +	  interface, which is used to enable and disable wireless networking
> > +	  devices, typically WLAN, Bluetooth and mobile broadband.
> > +
> >   config UTIL_LINUX_SWAPON
> >   	bool
> >   	prompt "swapon"
> > diff --git a/rules/util-linux.make b/rules/util-linux.make
> > index 0afa9ecdd938..c0f2dab369e4 100644
> > --- a/rules/util-linux.make
> > +++ b/rules/util-linux.make
> > @@ -116,7 +116,7 @@ UTIL_LINUX_CONF_OPT	:= \
> >   	--$(call ptx/endis, PTXCONF_UTIL_LINUX_IPCS)-ipcs \
> >   	--$(call ptx/endis, PTXCONF_UTIL_LINUX_IRQTOP)-irqtop \
> >   	--$(call ptx/endis, PTXCONF_UTIL_LINUX_LSIRQ)-lsirq \
> > -	--disable-rfkill \
> > +	--$(call ptx/endis, PTXCONF_UTIL_LINUX_RFKILL)-rfkill \
> >   	--disable-scriptutils \
> >   	--disable-tunelp \
> >   	--disable-kill \
> > @@ -238,6 +238,7 @@ UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_MOUNTPOINT)		+= bin/mountpoint
> >   UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_NSENTER)		+= bin/nsenter
> >   UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_PIVOT_ROOT)		+= sbin/pivot_root
> >   UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_READPROFILE)	+= sbin/readprofile
> > +UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_RFKILL)		+= sbin/rfkill
> >   UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_SWAPON)		+= sbin/swapoff sbin/swapon
> >   UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_SWITCH_ROOT)	+= sbin/switch_root
> >   UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_UMOUNT)		+= bin/umount
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |