From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 09 Dec 2022 08:03:18 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p3XPi-00FlAG-1D for lore@lore.pengutronix.de; Fri, 09 Dec 2022 08:03:18 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1p3XPh-0004Ko-CZ; Fri, 09 Dec 2022 08:03:17 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3XPE-0004KD-7y; Fri, 09 Dec 2022 08:02:48 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1p3XPD-0002os-SK; Fri, 09 Dec 2022 08:02:47 +0100 Date: Fri, 9 Dec 2022 08:02:47 +0100 From: Michael Olbrich To: Christian Melki Message-ID: <20221209070247.GV30335@pengutronix.de> Mail-Followup-To: Christian Melki , Philipp Zabel , ptxdist@pengutronix.de References: <20221208123847.1261596-1-p.zabel@pengutronix.de> <039a94f4-1806-eb36-596f-e82d7e7e26bc@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <039a94f4-1806-eb36-596f-e82d7e7e26bc@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] util-linux: add an option to enable rfkill X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de, Philipp Zabel Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Thu, Dec 08, 2022 at 01:53:13PM +0100, Christian Melki wrote: > Hi Philipp, > > > On 12/8/22 1:38 PM, Philipp Zabel wrote: > > Add a configuration option UTIL_LINUX_RFKILL to enable the rfkill tool. > > > > Signed-off-by: Philipp Zabel > > --- > > rules/util-linux.in | 9 +++++++++ > > rules/util-linux.make | 3 ++- > > 2 files changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/rules/util-linux.in b/rules/util-linux.in > > index 429473404a14..bf83def65f42 100644 > > --- a/rules/util-linux.in > > +++ b/rules/util-linux.in > > @@ -468,6 +468,15 @@ config UTIL_LINUX_READPROFILE > > comment "BusyBox' readprofile is selected!" > > depends on BUSYBOX_READPROFILE > > +config UTIL_LINUX_RFKILL > > + bool > > + prompt "rfkill" > > + select UTIL_LINUX_LIBSMARTCOLS > > Looks like busybox has a rfkill too? > PTXCONF_BUSYBOX_RFKILL Indeed, so you need to add the conflict check. Michael > > + help > > + rfkill is a simple tool for accessing the Linux rfkill device > > + interface, which is used to enable and disable wireless networking > > + devices, typically WLAN, Bluetooth and mobile broadband. > > + > > config UTIL_LINUX_SWAPON > > bool > > prompt "swapon" > > diff --git a/rules/util-linux.make b/rules/util-linux.make > > index 0afa9ecdd938..c0f2dab369e4 100644 > > --- a/rules/util-linux.make > > +++ b/rules/util-linux.make > > @@ -116,7 +116,7 @@ UTIL_LINUX_CONF_OPT := \ > > --$(call ptx/endis, PTXCONF_UTIL_LINUX_IPCS)-ipcs \ > > --$(call ptx/endis, PTXCONF_UTIL_LINUX_IRQTOP)-irqtop \ > > --$(call ptx/endis, PTXCONF_UTIL_LINUX_LSIRQ)-lsirq \ > > - --disable-rfkill \ > > + --$(call ptx/endis, PTXCONF_UTIL_LINUX_RFKILL)-rfkill \ > > --disable-scriptutils \ > > --disable-tunelp \ > > --disable-kill \ > > @@ -238,6 +238,7 @@ UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_MOUNTPOINT) += bin/mountpoint > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_NSENTER) += bin/nsenter > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_PIVOT_ROOT) += sbin/pivot_root > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_READPROFILE) += sbin/readprofile > > +UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_RFKILL) += sbin/rfkill > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_SWAPON) += sbin/swapoff sbin/swapon > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_SWITCH_ROOT) += sbin/switch_root > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_UMOUNT) += bin/umount > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |