mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] mtd-utils: Add option to build and install test tools
Date: Fri, 10 Jun 2022 08:49:24 +0200	[thread overview]
Message-ID: <20220610064924.2824476-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20220601104838.24007-1-ada@thorsis.com>

Thanks, applied as 03d91ca869141bc3dca7f4715f52990d35d6ddcd.

Michael

[sent from post-receive hook]

On Fri, 10 Jun 2022 08:49:24 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> Those tools are only needed in development for testing and debugging.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20220601104838.24007-1-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/mtd-utils.in b/rules/mtd-utils.in
> index bd7ce94493e5..c3b8bb29b97a 100644
> --- a/rules/mtd-utils.in
> +++ b/rules/mtd-utils.in
> @@ -396,4 +396,12 @@ config MTD_UTILS_MTDINFO
>  
>  endif
>  
> +config MTD_UTILS_TESTS
> +    bool
> +    prompt "MTD test programs"
> +    help
> +      MTD test-suite with the following, potentially dangerous, test
> +      programs: nandbiterrs, flash_speed, flash_stress, flash_readtest,
> +      nandpagetest, nandsubpagetest, and flash_torture.
> +
>  endif
> diff --git a/rules/mtd-utils.make b/rules/mtd-utils.make
> index a049e9896678..d14f4356eef1 100644
> --- a/rules/mtd-utils.make
> +++ b/rules/mtd-utils.make
> @@ -35,7 +35,7 @@ MTD_UTILS_CONF_OPT	:= \
>  	$(CROSS_AUTOCONF_USR) \
>  	--disable-unit-tests \
>  	$(GLOBAL_LARGE_FILE_OPTION) \
> -	--disable-tests \
> +	--$(call ptx/endis,PTXCONF_MTD_UTILS_TESTS)-tests \
>  	--$(call ptx/endis,PTXCONF_MTD_UTILS_UBIHEALTHD)-ubihealthd \
>  	--$(call ptx/endis, PTXCONF_MTD_UTILS_LSMTD)-lsmtd \
>  	--$(call ptx/wwo, PTXCONF_MTD_UTILS_JFFS)-jffs \
> @@ -256,6 +256,22 @@ ifdef PTXCONF_MTD_UTILS_MTDINFO
>  	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
>  		/usr/sbin/mtdinfo)
>  endif
> +ifdef PTXCONF_MTD_UTILS_TESTS
> +	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
> +		/usr/libexec/mtd-utils/nandbiterrs)
> +	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
> +		/usr/libexec/mtd-utils/flash_speed)
> +	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
> +		/usr/libexec/mtd-utils/flash_stress)
> +	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
> +		/usr/libexec/mtd-utils/flash_readtest)
> +	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
> +		/usr/libexec/mtd-utils/nandpagetest)
> +	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
> +		/usr/libexec/mtd-utils/nandsubpagetest)
> +	@$(call install_copy, mtd-utils, 0, 0, 0755, -, \
> +		/usr/libexec/mtd-utils/flash_torture)
> +endif
>  
>  	@$(call install_finish, mtd-utils)
>  



      reply	other threads:[~2022-06-10  6:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 10:48 [ptxdist] [PATCH] " Alexander Dahl
2022-06-10  6:49 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610064924.2824476-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox