From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Jun 2022 08:49:46 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzYSo-009kZV-Lb for lore@lore.pengutronix.de; Fri, 10 Jun 2022 08:49:46 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nzYSn-000893-4g; Fri, 10 Jun 2022 08:49:45 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzYST-0007gd-Tf; Fri, 10 Jun 2022 08:49:25 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzYSU-007WnA-He; Fri, 10 Jun 2022 08:49:25 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzYSS-00BqnI-Ej; Fri, 10 Jun 2022 08:49:24 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Fri, 10 Jun 2022 08:49:24 +0200 Message-Id: <20220610064924.2824476-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220601104838.24007-1-ada@thorsis.com> References: <20220601104838.24007-1-ada@thorsis.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] mtd-utils: Add option to build and install test tools X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 03d91ca869141bc3dca7f4715f52990d35d6ddcd. Michael [sent from post-receive hook] On Fri, 10 Jun 2022 08:49:24 +0200, Alexander Dahl wrote: > Those tools are only needed in development for testing and debugging. > > Signed-off-by: Alexander Dahl > Message-Id: <20220601104838.24007-1-ada@thorsis.com> > Signed-off-by: Michael Olbrich > > diff --git a/rules/mtd-utils.in b/rules/mtd-utils.in > index bd7ce94493e5..c3b8bb29b97a 100644 > --- a/rules/mtd-utils.in > +++ b/rules/mtd-utils.in > @@ -396,4 +396,12 @@ config MTD_UTILS_MTDINFO > > endif > > +config MTD_UTILS_TESTS > + bool > + prompt "MTD test programs" > + help > + MTD test-suite with the following, potentially dangerous, test > + programs: nandbiterrs, flash_speed, flash_stress, flash_readtest, > + nandpagetest, nandsubpagetest, and flash_torture. > + > endif > diff --git a/rules/mtd-utils.make b/rules/mtd-utils.make > index a049e9896678..d14f4356eef1 100644 > --- a/rules/mtd-utils.make > +++ b/rules/mtd-utils.make > @@ -35,7 +35,7 @@ MTD_UTILS_CONF_OPT := \ > $(CROSS_AUTOCONF_USR) \ > --disable-unit-tests \ > $(GLOBAL_LARGE_FILE_OPTION) \ > - --disable-tests \ > + --$(call ptx/endis,PTXCONF_MTD_UTILS_TESTS)-tests \ > --$(call ptx/endis,PTXCONF_MTD_UTILS_UBIHEALTHD)-ubihealthd \ > --$(call ptx/endis, PTXCONF_MTD_UTILS_LSMTD)-lsmtd \ > --$(call ptx/wwo, PTXCONF_MTD_UTILS_JFFS)-jffs \ > @@ -256,6 +256,22 @@ ifdef PTXCONF_MTD_UTILS_MTDINFO > @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > /usr/sbin/mtdinfo) > endif > +ifdef PTXCONF_MTD_UTILS_TESTS > + @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > + /usr/libexec/mtd-utils/nandbiterrs) > + @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > + /usr/libexec/mtd-utils/flash_speed) > + @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > + /usr/libexec/mtd-utils/flash_stress) > + @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > + /usr/libexec/mtd-utils/flash_readtest) > + @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > + /usr/libexec/mtd-utils/nandpagetest) > + @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > + /usr/libexec/mtd-utils/nandsubpagetest) > + @$(call install_copy, mtd-utils, 0, 0, 0755, -, \ > + /usr/libexec/mtd-utils/flash_torture) > +endif > > @$(call install_finish, mtd-utils) >