[ptxdist] [PATCH] pipewire: disable v4l2 integration

[ptxdist] [PATCH] pipewire: disable v4l2 integration

[Michael Tretter]

PipeWire allows to emulate V4L2 devices by intercepting the device
ioctls and handling them in PipeWire. This is unrelated to the V4L2
backend, which allows to use V4L2 devices in PipeWire.

Disable the integration, because applications should use PipeWire
directly instead of using the V4L2 API.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 rules/pipewire.make | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/rules/pipewire.make b/rules/pipewire.make
index 9fd3d4d40658..495c5188687c 100644
--- a/rules/pipewire.make
+++ b/rules/pipewire.make
@@ -75,7 +75,7 @@ PIPEWIRE_CONF_OPT	:= \
 	-Dman=disabled \
 	-Dpipewire-alsa=enabled \
 	-Dpipewire-jack=disabled \
-	-Dpipewire-v4l2=enabled \
+	-Dpipewire-v4l2=disabled \
 	-Dpw-cat=enabled \
 	-Draop=$(call ptx/endis,PTXCONF_PIPEWIRE_RAOP)d \
 	-Droc=disabled \
@@ -176,7 +176,6 @@ endif
 ifdef PTXCONF_PIPEWIRE_PW_TOP
 	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/pw-top)
 endif
-	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/pw-v4l2)
 	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/spa-acp-tool)
 	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/spa-inspect)
 	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/spa-json-dump)
@@ -193,8 +192,6 @@ endif
 		$(call install_lib, pipewire, 0, 0, 644, \
 			pipewire-0.3/libpipewire-module-$(module))$(ptx/nl))
 
-	@$(call install_lib, pipewire, 0, 0, 644, pipewire-0.3/v4l2/libpw-v4l2)
-
 	@$(foreach module, $(PIPEWIRE_SPA_MODULES), \
 		$(call install_lib, pipewire, 0, 0, 644, \
 			spa-0.2/$(module))$(ptx/nl))
-- 
2.30.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] pipewire: disable v4l2 integration

[Michael Olbrich]

Thanks, applied as 3cef96ff21ac02a7eba7e69e784539ced938eb70.

Michael

[sent from post-receive hook]

On Fri, 22 Apr 2022 12:00:58 +0200, Michael Tretter <m.tretter@pengutronix.de> wrote:
> PipeWire allows to emulate V4L2 devices by intercepting the device
> ioctls and handling them in PipeWire. This is unrelated to the V4L2
> backend, which allows to use V4L2 devices in PipeWire.
> 
> Disable the integration, because applications should use PipeWire
> directly instead of using the V4L2 API.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Message-Id: <20220421151942.342129-1-m.tretter@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/pipewire.make b/rules/pipewire.make
> index 9fd3d4d40658..495c5188687c 100644
> --- a/rules/pipewire.make
> +++ b/rules/pipewire.make
> @@ -75,7 +75,7 @@ PIPEWIRE_CONF_OPT	:= \
>  	-Dman=disabled \
>  	-Dpipewire-alsa=enabled \
>  	-Dpipewire-jack=disabled \
> -	-Dpipewire-v4l2=enabled \
> +	-Dpipewire-v4l2=disabled \
>  	-Dpw-cat=enabled \
>  	-Draop=$(call ptx/endis,PTXCONF_PIPEWIRE_RAOP)d \
>  	-Droc=disabled \
> @@ -176,7 +176,6 @@ endif
>  ifdef PTXCONF_PIPEWIRE_PW_TOP
>  	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/pw-top)
>  endif
> -	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/pw-v4l2)
>  	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/spa-acp-tool)
>  	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/spa-inspect)
>  	@$(call install_copy, pipewire, 0, 0, 755, -, /usr/bin/spa-json-dump)
> @@ -193,8 +192,6 @@ endif
>  		$(call install_lib, pipewire, 0, 0, 644, \
>  			pipewire-0.3/libpipewire-module-$(module))$(ptx/nl))
>  
> -	@$(call install_lib, pipewire, 0, 0, 644, pipewire-0.3/v4l2/libpw-v4l2)
> -
>  	@$(foreach module, $(PIPEWIRE_SPA_MODULES), \
>  		$(call install_lib, pipewire, 0, 0, 644, \
>  			spa-0.2/$(module))$(ptx/nl))

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de