Re: [ptxdist] [Might-be-helpful-to-someone-PATCH] scripts/kconfig: (Re-)add warning about unassigned symbols.

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jan 28, 2022 at 10:55:05AM +0100, Christian Melki wrote:
> 
> 
> On 1/28/22 10:16 AM, Michael Olbrich wrote:
> > On Tue, Jan 25, 2022 at 04:01:24PM +0100, Christian Melki wrote:
> > > Kconfig/lxdialog is inherited from the linux kernel.
> > > That version removed a warning regarding unassigned symbols.
> > > Commit f072181e6403b0fe2e2aa800a005497b748fd284,
> > > kconfig: drop the ""trying to assign nonexistent symbol" warning.
> > > 
> > > This warning actually helps detecting symbol renames which are lost in
> > > translation which is helpful when doing oldconfigs etc.
> > 
> > Good argument. I like it.
> > 
> > When I update kconfig, then I overwrite it with the new version. Then I
> > apply the patches from scripts/ptx-modifications/. So any local changes
> > must be added there too. Can you do that? Just add exactly this patch there
> > and add it to the series file. Then amend the commit or create a second
> > one. Either way works for me.
> > 
> > Michael
> > 
> 
> Will do. Btw. This obviously applies to other projects using
> kconfig/lxdialog. Kernel, busybox etc. I've always found that the developers
> do not care for unassigned symbols in defconfigs etc. I am currently trying
> to push this back into the kernel as it has approx 1k unassigned symbols
> over arch defconfigs (ARM has around 450). Even really, really old symbols.
> 
> But for the embedded developer for a project, coming from an old version and
> upgrading kernel, busybox, whatever with oldconfig, a lot of symbols are
> renamed over time and functionality "lost" without as much as a notice.
> Sometimes that leads to time waste because you did not notice the symbol
> name change.

A fully agree. If something is inconsistent then I want to know about it.

The kconfig in the kernel is actually worse. You can select a non-existent
symbol without getting an error. So if a symbol name changes of it it's
removed then a user can be forgotten without generating an error :-/.
I reverted that change some time ago.

> Which has always bugged me. Ever since that was deleted in 2008.
> So probably helpful for those pesky Busybox updates too (tnx) :)

np.

Michael

> > > Signed-off-by: Christian Melki <christian.melki@t2data.com>
> > > ---
> > >   scripts/kconfig/confdata.c | 5 ++++-
> > >   1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> > > index c5f4b552b..09777fdfe 100644
> > > --- a/scripts/kconfig/confdata.c
> > > +++ b/scripts/kconfig/confdata.c
> > > @@ -426,6 +426,7 @@ load:
> > >   			if (def == S_DEF_USER) {
> > >   				sym = sym_find(line + 2 + strlen(CONFIG_));
> > >   				if (!sym) {
> > > +					conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_));
> > >   					sym_add_change_count(1);
> > >   					continue;
> > >   				}
> > > @@ -468,8 +469,10 @@ load:
> > >   					 * include/config/foo.h must be touched.
> > >   					 */
> > >   					conf_touch_dep(line + strlen(CONFIG_));
> > > -				else
> > > +				else {
> > > +					conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_));
> > >   					sym_add_change_count(1);
> > > +				}
> > >   				continue;
> > >   			}
> > > -- 
> > > 2.30.2
> > > 
> > > 
> > > _______________________________________________
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > > 
> > 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de