From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 28 Jan 2022 11:42:53 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nDOiT-00FsPx-VZ for lore@lore.pengutronix.de; Fri, 28 Jan 2022 11:42:53 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nDOiT-0004kQ-Ao; Fri, 28 Jan 2022 11:42:53 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDOiI-0004kE-16; Fri, 28 Jan 2022 11:42:42 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nDOiH-0006Yo-JZ; Fri, 28 Jan 2022 11:42:41 +0100 Date: Fri, 28 Jan 2022 11:42:41 +0100 From: Michael Olbrich To: Christian Melki Message-ID: <20220128104241.GY11273@pengutronix.de> Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20220125150124.6297-1-christian.melki@t2data.com> <0c4b6abf-bf68-81bd-80b2-279bbb2fe170@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0c4b6abf-bf68-81bd-80b2-279bbb2fe170@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:39:21 up 48 days, 19:24, 80 users, load average: 0.05, 0.11, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [Might-be-helpful-to-someone-PATCH] scripts/kconfig: (Re-)add warning about unassigned symbols. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Jan 28, 2022 at 10:55:05AM +0100, Christian Melki wrote: > > > On 1/28/22 10:16 AM, Michael Olbrich wrote: > > On Tue, Jan 25, 2022 at 04:01:24PM +0100, Christian Melki wrote: > > > Kconfig/lxdialog is inherited from the linux kernel. > > > That version removed a warning regarding unassigned symbols. > > > Commit f072181e6403b0fe2e2aa800a005497b748fd284, > > > kconfig: drop the ""trying to assign nonexistent symbol" warning. > > > > > > This warning actually helps detecting symbol renames which are lost in > > > translation which is helpful when doing oldconfigs etc. > > > > Good argument. I like it. > > > > When I update kconfig, then I overwrite it with the new version. Then I > > apply the patches from scripts/ptx-modifications/. So any local changes > > must be added there too. Can you do that? Just add exactly this patch there > > and add it to the series file. Then amend the commit or create a second > > one. Either way works for me. > > > > Michael > > > > Will do. Btw. This obviously applies to other projects using > kconfig/lxdialog. Kernel, busybox etc. I've always found that the developers > do not care for unassigned symbols in defconfigs etc. I am currently trying > to push this back into the kernel as it has approx 1k unassigned symbols > over arch defconfigs (ARM has around 450). Even really, really old symbols. > > But for the embedded developer for a project, coming from an old version and > upgrading kernel, busybox, whatever with oldconfig, a lot of symbols are > renamed over time and functionality "lost" without as much as a notice. > Sometimes that leads to time waste because you did not notice the symbol > name change. A fully agree. If something is inconsistent then I want to know about it. The kconfig in the kernel is actually worse. You can select a non-existent symbol without getting an error. So if a symbol name changes of it it's removed then a user can be forgotten without generating an error :-/. I reverted that change some time ago. > Which has always bugged me. Ever since that was deleted in 2008. > So probably helpful for those pesky Busybox updates too (tnx) :) np. Michael > > > Signed-off-by: Christian Melki > > > --- > > > scripts/kconfig/confdata.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > > > index c5f4b552b..09777fdfe 100644 > > > --- a/scripts/kconfig/confdata.c > > > +++ b/scripts/kconfig/confdata.c > > > @@ -426,6 +426,7 @@ load: > > > if (def == S_DEF_USER) { > > > sym = sym_find(line + 2 + strlen(CONFIG_)); > > > if (!sym) { > > > + conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_)); > > > sym_add_change_count(1); > > > continue; > > > } > > > @@ -468,8 +469,10 @@ load: > > > * include/config/foo.h must be touched. > > > */ > > > conf_touch_dep(line + strlen(CONFIG_)); > > > - else > > > + else { > > > + conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_)); > > > sym_add_change_count(1); > > > + } > > > continue; > > > } > > > -- > > > 2.30.2 > > > > > > > > > _______________________________________________ > > > ptxdist mailing list > > > ptxdist@pengutronix.de > > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > > > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de