mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] rng-tools: fix dependency for init script and systemd unit
Date: Fri,  5 Nov 2021 08:55:24 +0100	[thread overview]
Message-ID: <20211105075524.3106507-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20211024203158.vgnpwg2we3m6y3zt@pengutronix.de>

Thanks, applied as 1f4688b04f35887b7abfbde8004351f40b2b8d43.

Michael

[sent from post-receive hook]

On Fri, 05 Nov 2021 08:55:24 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> Both call rngd, so it does not make sense to install them without rngd.
> Furthermore, the systemd unit is useless without systemd itself.
> 
> Fixes: 88f17567fbef465e9bf2 (2021-06-07, "rng-tools: allow installing rngtest without rngd")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20211024203158.vgnpwg2we3m6y3zt@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/rng-tools.in b/rules/rng-tools.in
> index e8e5b776cf97..5e68791d3c66 100644
> --- a/rules/rng-tools.in
> +++ b/rules/rng-tools.in
> @@ -24,13 +24,15 @@ config RNG_TOOLS_RNGD
>  config RNG_TOOLS_STARTSCRIPT
>  	bool
>  	default y
> -	depends on RNG_TOOLS && INITMETHOD_BBINIT
> +	select RNG_TOOLS_RNGD
> +	depends on INITMETHOD_BBINIT
>  	prompt "install /etc/init.d/rngd"
>  
>  config RNG_TOOLS_SYSTEMD_UNIT
>  	bool
>  	default y
> -	depends on SYSTEMD
> +	depends on INITMETHOD_SYSTEMD
> +	select RNG_TOOLS_RNGD
>  	prompt "install systemd unit files"
>  
>  config RNG_TOOLS_RNGTEST

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-11-05  7:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 13:17 [ptxdist] [PATCH 1/2] rng-tools: pin down license files Roland Hieber
2021-08-12 13:17 ` [ptxdist] [PATCH 2/2] rng-tools: version bump v6.5 -> v6.14 Roland Hieber
2021-08-13  9:44   ` [ptxdist] [PATCH v2 2/3] " Roland Hieber
2021-10-20  9:39     ` [ptxdist] [APPLIED] " Michael Olbrich
2021-08-12 13:42 ` [ptxdist] [PATCH 3/2] rng-tools: fix dependency for systemd services and init script Roland Hieber
2021-09-03 14:20   ` Michael Olbrich
2021-10-24 20:31   ` [ptxdist] [PATCH v2 3/2] rng-tools: fix dependency for init script and systemd unit Roland Hieber
2021-11-05  7:55     ` Michael Olbrich [this message]
2021-10-20  9:39 ` [ptxdist] [APPLIED] rng-tools: pin down license files Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211105075524.3106507-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox