Re: [ptxdist] [PATCH 3/2] rng-tools: fix dependency for systemd services and init script

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Aug 12, 2021 at 03:42:54PM +0200, Roland Hieber wrote:
> Both call rngd, so it does not make sense to install them without rngd.
> Furthermore, the systemd unit is useless without systemd itself.
> 
> Fixes: 88f17567fbef465e9bf2 (2021-06-07, "rng-tools: allow installing rngtest without rngd")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/rng-tools.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/rng-tools.in b/rules/rng-tools.in
> index eed76200987a..a9dc01340243 100644
> --- a/rules/rng-tools.in
> +++ b/rules/rng-tools.in
> @@ -25,12 +25,13 @@ config RNG_TOOLS_RNGD
>  config RNG_TOOLS_STARTSCRIPT
>  	bool
>  	default y
> -	depends on RNG_TOOLS && INITMETHOD_BBINIT
> +	depends on RNG_TOOLS_RNGD && INITMETHOD_BBINIT
>  	prompt "install /etc/init.d/rngd"
>  
>  config RNG_TOOLS_SYSTEMD_UNIT
>  	bool
>  	default y
> +	depends on RNG_TOOLS_RNGD && INITMETHOD_SYSTEMD
>  	depends on SYSTEMD

Either INITMETHOD_SYSTEMD or SYSTEMD but not both.

Michael

>  	prompt "install systemd unit files"
>  
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de