From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Christian Melki <christian.melki@t2data.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/8] rules/xorg-driver-input-evdev.make: Use CROSS_LIB_DIR.
Date: Wed, 29 Sep 2021 11:05:08 +0200 [thread overview]
Message-ID: <20210929090507.GA2560099@pengutronix.de> (raw)
In-Reply-To: <20210908140002.299517-1-christian.melki@t2data.com>
On Wed, Sep 08, 2021 at 03:59:55PM +0200, Christian Melki wrote:
> Let xorg-driver-input install libraries in CROSS_LIB_DIR.
Please use the package name not the file name in the subject for patches
like this. This applies to all other patches as well.
> ---
> rules/xorg-driver-input-evdev.make | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules/xorg-driver-input-evdev.make b/rules/xorg-driver-input-evdev.make
> index 8937a5ae5..2049ea100 100644
> --- a/rules/xorg-driver-input-evdev.make
> +++ b/rules/xorg-driver-input-evdev.make
> @@ -50,7 +50,7 @@ $(STATEDIR)/xorg-driver-input-evdev.targetinstall:
> @$(call install_fixup, xorg-driver-input-evdev,DESCRIPTION,missing)
>
> @$(call install_copy, xorg-driver-input-evdev, 0, 0, 0755, -, \
> - /usr/lib/xorg/modules/input/evdev_drv.so)
> + /usr/$(CROSS_LIB_DIR)/xorg/modules/input/evdev_drv.so)
Convert this to used install_lib instead. That way, the libdir is used
correctly automatically. And I'm pretty sure that the file does not need to
be executable. So:
@$(call install_lib, xorg-driver-input-evdev, 0, 0, 0644, \
xorg/modules/input/evdev_drv)
The same applies to all the other xorg-driver-* patches as well.
Michael
>
> @$(call install_finish, xorg-driver-input-evdev)
>
> --
> 2.30.2
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
prev parent reply other threads:[~2021-09-29 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 13:59 Christian Melki
2021-09-08 13:59 ` [ptxdist] [PATCH 2/8] rules/xorg-driver-input-keyboard.make: " Christian Melki
2021-09-08 13:59 ` [ptxdist] [PATCH 3/8] rules/xorg-driver-input-mouse.make: " Christian Melki
2021-09-08 13:59 ` [ptxdist] [PATCH 4/8] rules/xorg-driver-input-tslib.make: " Christian Melki
2021-09-08 13:59 ` [ptxdist] [PATCH 5/8] rules/xorg-driver-input-void.make: " Christian Melki
2021-09-08 14:00 ` [ptxdist] [PATCH 6/8] rules/xorg-driver-video-vesa.make: " Christian Melki
2021-09-08 14:00 ` [ptxdist] [PATCH 7/8] rules/xorg-fonts.make: " Christian Melki
2021-09-08 14:00 ` [ptxdist] [PATCH 8/8] rules/mesalib.make: " Christian Melki
2021-09-29 9:05 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929090507.GA2560099@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=christian.melki@t2data.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox