From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 29 Sep 2021 11:05:42 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVVX4-00025v-TP for lore@lore.pengutronix.de; Wed, 29 Sep 2021 11:05:42 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVVX4-0003V9-Cc; Wed, 29 Sep 2021 11:05:42 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVVWW-0003Uc-P6; Wed, 29 Sep 2021 11:05:08 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVVWW-0004ks-2u; Wed, 29 Sep 2021 11:05:08 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mVVWW-00AkCd-25; Wed, 29 Sep 2021 11:05:08 +0200 Date: Wed, 29 Sep 2021 11:05:08 +0200 From: Michael Olbrich To: Christian Melki Message-ID: <20210929090507.GA2560099@pengutronix.de> Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20210908140002.299517-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210908140002.299517-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH 1/8] rules/xorg-driver-input-evdev.make: Use CROSS_LIB_DIR. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Sep 08, 2021 at 03:59:55PM +0200, Christian Melki wrote: > Let xorg-driver-input install libraries in CROSS_LIB_DIR. Please use the package name not the file name in the subject for patches like this. This applies to all other patches as well. > --- > rules/xorg-driver-input-evdev.make | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rules/xorg-driver-input-evdev.make b/rules/xorg-driver-input-evdev.make > index 8937a5ae5..2049ea100 100644 > --- a/rules/xorg-driver-input-evdev.make > +++ b/rules/xorg-driver-input-evdev.make > @@ -50,7 +50,7 @@ $(STATEDIR)/xorg-driver-input-evdev.targetinstall: > @$(call install_fixup, xorg-driver-input-evdev,DESCRIPTION,missing) > > @$(call install_copy, xorg-driver-input-evdev, 0, 0, 0755, -, \ > - /usr/lib/xorg/modules/input/evdev_drv.so) > + /usr/$(CROSS_LIB_DIR)/xorg/modules/input/evdev_drv.so) Convert this to used install_lib instead. That way, the libdir is used correctly automatically. And I'm pretty sure that the file does not need to be executable. So: @$(call install_lib, xorg-driver-input-evdev, 0, 0, 0644, \ xorg/modules/input/evdev_drv) The same applies to all the other xorg-driver-* patches as well. Michael > > @$(call install_finish, xorg-driver-input-evdev) > > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de