Re: [ptxdist] [PATCH 2/7] host-system-mpc: add fedora package help

[Roland Hieber <rhi@pengutronix.de>]

On Mon, Jun 21, 2021 at 08:13:45AM +0200, Bruno Thomsen wrote:
> Den lør. 19. jun. 2021 kl. 23.27 skrev Roland Hieber <rhi@pengutronix.de>:
> >
> > On Sat, Jun 19, 2021 at 02:58:13PM +0200, Bruno Thomsen wrote:
> > > Improve help message when failing to find mpc development files
> > > on a Fedora system (RPM based).
> > >
> > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > > ---
> > >  rules/host-system-mpc.make | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/rules/host-system-mpc.make b/rules/host-system-mpc.make
> > > index ec2991d..1f6337a 100644
> > > --- a/rules/host-system-mpc.make
> > > +++ b/rules/host-system-mpc.make
> > > @@ -21,7 +21,7 @@ $(STATEDIR)/host-system-mpc.prepare:
> > >       @echo "Checking for mpc ..."
> > >       @echo "#include <mpc.h>" | $(HOSTCC) -x c -c -o /dev/null - 2>/dev/null || \
> > >               ptxd_bailout "mpc development files not found!" \
> > > -             "Please install libmpc-dev (debian)"
> > > +             "Please install libmpc-dev (debian) or libmpc-devel (fedora)"
> >
> > This pokes out… if the package name is really the same in both distros,
> > I would rephrase this messages as
> >
> >     "Please install libmpc-dev (debian, fedora)"
> >
> 
> Hi Roland,
> 
> It's not the same name: dev vs devel.

Ah. Yes, the patch makes sense then.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de