mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/7] host-system-mpc: add fedora package help
Date: Sat, 19 Jun 2021 23:27:34 +0200	[thread overview]
Message-ID: <20210619212734.mslvij2jhyzy2jk3@pengutronix.de> (raw)
In-Reply-To: <20210619125818.374987-3-bruno.thomsen@gmail.com>

On Sat, Jun 19, 2021 at 02:58:13PM +0200, Bruno Thomsen wrote:
> Improve help message when failing to find mpc development files
> on a Fedora system (RPM based).
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
>  rules/host-system-mpc.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/host-system-mpc.make b/rules/host-system-mpc.make
> index ec2991d..1f6337a 100644
> --- a/rules/host-system-mpc.make
> +++ b/rules/host-system-mpc.make
> @@ -21,7 +21,7 @@ $(STATEDIR)/host-system-mpc.prepare:
>  	@echo "Checking for mpc ..."
>  	@echo "#include <mpc.h>" | $(HOSTCC) -x c -c -o /dev/null - 2>/dev/null || \
>  		ptxd_bailout "mpc development files not found!" \
> -		"Please install libmpc-dev (debian)"
> +		"Please install libmpc-dev (debian) or libmpc-devel (fedora)"

This pokes out… if the package name is really the same in both distros,
I would rephrase this messages as 

    "Please install libmpc-dev (debian, fedora)"

.

 - Roland

>  	@$(call touch)
>  
>  # vim: syntax=make
> -- 
> 2.31.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-06-19 21:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 12:58 [ptxdist] [PATCH 0/7] OSELAS improve host package help text Bruno Thomsen
2021-06-19 12:58 ` [ptxdist] [PATCH 1/7] host-system-isl: add fedora package help Bruno Thomsen
2021-06-19 12:58 ` [ptxdist] [PATCH 2/7] host-system-mpc: " Bruno Thomsen
2021-06-19 21:27   ` Roland Hieber [this message]
2021-06-21  6:13     ` Bruno Thomsen
2021-06-21  9:34       ` Roland Hieber
2021-06-19 12:58 ` [ptxdist] [PATCH 3/7] host-system-mpfr: " Bruno Thomsen
2021-06-19 12:58 ` [ptxdist] [PATCH 4/7] host-system-gmp: " Bruno Thomsen
2021-06-19 12:58 ` [ptxdist] [PATCH 5/7] host-system-expat: " Bruno Thomsen
2021-06-19 12:58 ` [ptxdist] [PATCH 6/7] host-system-xz: " Bruno Thomsen
2021-06-19 12:58 ` [ptxdist] [PATCH 7/7] host-system-zlib: " Bruno Thomsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210619212734.mslvij2jhyzy2jk3@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=bruno.thomsen@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox