From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] ptxdist: package-info: give better error message without parameters
Date: Fri, 23 Apr 2021 15:47:33 +0200 [thread overview]
Message-ID: <20210423134733.2557794-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20210411202518.31984-2-rhi@pengutronix.de>
Thanks, applied as 65c1a38738aec3c40722f3ee64040da44e35a3a2.
Michael
[sent from post-receive hook]
On Fri, 23 Apr 2021 15:47:33 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> The current output is not very explanatory:
>
> $ ptxdist package-info
> ptxdist: error: please use 'ptxdist' instead of calling make directly.
> make: *** [.../ptxdist/rules/other/Toplevel.make:55: all] Error 1
>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20210411202518.31984-2-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/bin/ptxdist b/bin/ptxdist
> index f5ded85577ef..13f81674f4fd 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1886,6 +1886,11 @@ EOF
> package-info)
> declare -a pkgs
>
> + if [ ${#} -eq 0 ]; then
> + echo "Usage: package-info <packages...>"
> + exit 1
> + fi
> +
> check_config &&
> check_deps &&
> pkgs=( "${@/#/${STATEDIR}/}" ) &&
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-04-23 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 20:25 [ptxdist] [PATCH 1/2] ptxdist: drop: " Roland Hieber
2021-04-11 20:25 ` [ptxdist] [PATCH 2/2] ptxdist: package-info: " Roland Hieber
2021-04-23 13:47 ` Michael Olbrich [this message]
2021-04-23 13:47 ` [ptxdist] [APPLIED] ptxdist: drop: " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423134733.2557794-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox