From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Fri, 23 Apr 2021 15:48:28 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1lZwAW-0005rS-Dh
	for lore@lore.pengutronix.de; Fri, 23 Apr 2021 15:48:28 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1lZwAV-0003P7-V4; Fri, 23 Apr 2021 15:48:27 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1lZw9d-0003GX-V3; Fri, 23 Apr 2021 15:47:34 +0200
Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1lZw9d-0001HW-Fv; Fri, 23 Apr 2021 15:47:33 +0200
Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1lZw9d-00AjPV-D3; Fri, 23 Apr 2021 15:47:33 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Fri, 23 Apr 2021 15:47:33 +0200
Message-Id: <20210423134733.2557794-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20210411202518.31984-2-rhi@pengutronix.de>
References: <20210411202518.31984-2-rhi@pengutronix.de>
MIME-Version: 1.0
Subject: Re: [ptxdist] [APPLIED] ptxdist: package-info: give better error
 message without parameters
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 65c1a38738aec3c40722f3ee64040da44e35a3a2.

Michael

[sent from post-receive hook]

On Fri, 23 Apr 2021 15:47:33 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> The current output is not very explanatory:
> 
>     $ ptxdist package-info
>     ptxdist: error: please use 'ptxdist' instead of calling make directly.
>     make: *** [.../ptxdist/rules/other/Toplevel.make:55: all] Error 1
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20210411202518.31984-2-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index f5ded85577ef..13f81674f4fd 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1886,6 +1886,11 @@ EOF
>  		package-info)
>  			declare -a pkgs
>  
> +			if [ ${#} -eq 0 ]; then
> +				echo "Usage: package-info <packages...>"
> +				exit 1
> +			fi
> +
>  			check_config &&
>  			check_deps &&
>  			pkgs=( "${@/#/${STATEDIR}/}" ) &&

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de