mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] Networkmanager pppd support broken
@ 2020-03-30 16:27 Denis Osterland-Heim
  2020-03-30 19:39 ` Michael Olbrich
  0 siblings, 1 reply; 4+ messages in thread
From: Denis Osterland-Heim @ 2020-03-30 16:27 UTC (permalink / raw)
  To: ptxdist

Hi,

NetworkManager pppd compile support seems broken.

../NetworkManager-1.20.8/src/ppp/nm-pppd-plugin.c:34:10: fatal error: pppd/eui64.h: No such file or directory
   34 | #include <pppd/eui64.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.

It seems to refer to https://github.com/wkz/pppd/blob/master/pppd/eui64.h
but this header is not installed to sysroot-target/usr/include/pppd
https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L18

Does anyone use it?

Regards Denis


Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
- For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] Networkmanager pppd support broken
  2020-03-30 16:27 [ptxdist] Networkmanager pppd support broken Denis Osterland-Heim
@ 2020-03-30 19:39 ` Michael Olbrich
  2020-03-31  5:17   ` Denis Osterland-Heim
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2020-03-30 19:39 UTC (permalink / raw)
  To: ptxdist

On Mon, Mar 30, 2020 at 04:27:48PM +0000, Denis Osterland-Heim wrote:
> NetworkManager pppd compile support seems broken.
> 
> ../NetworkManager-1.20.8/src/ppp/nm-pppd-plugin.c:34:10: fatal error: pppd/eui64.h: No such file or directory
>    34 | #include <pppd/eui64.h>
>       |          ^~~~~~~~~~~~~~
> compilation terminated.
> 
> It seems to refer to https://github.com/wkz/pppd/blob/master/pppd/eui64.h
> but this header is not installed to sysroot-target/usr/include/pppd
> https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L18

It's added here:

https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L180

> Does anyone use it?

The file is installed and building the NetworkManager pppd support works in
my build everything test.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] Networkmanager pppd support broken
  2020-03-30 19:39 ` Michael Olbrich
@ 2020-03-31  5:17   ` Denis Osterland-Heim
  2020-04-01 14:52     ` Michael Olbrich
  0 siblings, 1 reply; 4+ messages in thread
From: Denis Osterland-Heim @ 2020-03-31  5:17 UTC (permalink / raw)
  To: ptxdist

Hi Michael,

Am Montag, den 30.03.2020, 21:39 +0200 schrieb Michael Olbrich:
> On Mon, Mar 30, 2020 at 04:27:48PM +0000, Denis Osterland-Heim wrote:
> > NetworkManager pppd compile support seems broken.
> > 
> > ../NetworkManager-1.20.8/src/ppp/nm-pppd-plugin.c:34:10: fatal error: pppd/eui64.h: No such file or directory
> >    34 | #include <pppd/eui64.h>
> >       |          ^~~~~~~~~~~~~~
> > compilation terminated.
> > 
> > It seems to refer to https://github.com/wkz/pppd/blob/master/pppd/eui64.h
> > but this header is not installed to sysroot-target/usr/include/pppd
> > https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L18
> 
> It's added here:
> 
> https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L180
this solves the puzzle.
eui64.h is only installed if GLOBAL_IPV6 is selected, but NetworkManager pppd
depends on it unconditionally.

Shall we go with "select" or "depends on" in case of this global setting?

> 
> > Does anyone use it?
> 
> The file is installed and building the NetworkManager pppd support works in
> my build everything test.
I should have known this. sorry

Regards Denis

> 
> Michael
> 


Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
- For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] Networkmanager pppd support broken
  2020-03-31  5:17   ` Denis Osterland-Heim
@ 2020-04-01 14:52     ` Michael Olbrich
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2020-04-01 14:52 UTC (permalink / raw)
  To: ptxdist

On Tue, Mar 31, 2020 at 05:17:04AM +0000, Denis Osterland-Heim wrote:
> Hi Michael,
> 
> Am Montag, den 30.03.2020, 21:39 +0200 schrieb Michael Olbrich:
> > On Mon, Mar 30, 2020 at 04:27:48PM +0000, Denis Osterland-Heim wrote:
> > > NetworkManager pppd compile support seems broken.
> > > 
> > > ../NetworkManager-1.20.8/src/ppp/nm-pppd-plugin.c:34:10: fatal error: pppd/eui64.h: No such file or directory
> > >    34 | #include <pppd/eui64.h>
> > >       |          ^~~~~~~~~~~~~~
> > > compilation terminated.
> > > 
> > > It seems to refer to https://github.com/wkz/pppd/blob/master/pppd/eui64.h
> > > but this header is not installed to sysroot-target/usr/include/pppd
> > > https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L18
> > 
> > It's added here:
> > 
> > https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L180
> this solves the puzzle.
> eui64.h is only installed if GLOBAL_IPV6 is selected, but NetworkManager pppd
> depends on it unconditionally.
> 
> Shall we go with "select" or "depends on" in case of this global setting?

Yes, but add a comment that shows up when it is disabled and the option is
invisible, so that users know what to do.

> > 
> > > Does anyone use it?
> > 
> > The file is installed and building the NetworkManager pppd support works in
> > my build everything test.
> I should have known this. sorry

:-)

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-01 14:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 16:27 [ptxdist] Networkmanager pppd support broken Denis Osterland-Heim
2020-03-30 19:39 ` Michael Olbrich
2020-03-31  5:17   ` Denis Osterland-Heim
2020-04-01 14:52     ` Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox