From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 17 Jun 2024 16:03:53 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sJCxd-007cAy-1m for lore@lore.pengutronix.de; Mon, 17 Jun 2024 16:03:53 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sJCxc-0005vb-Qq; Mon, 17 Jun 2024 16:03:52 +0200 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1sJ9Nf-0000uG-FI for ptxdist@pengutronix.de; Mon, 17 Jun 2024 12:14:33 +0200 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-57c60b13a56so4922826a12.0 for ; Mon, 17 Jun 2024 03:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718619271; x=1719224071; darn=pengutronix.de; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0L2QKu3Q7F2VAvVct8HM+iyLoch8jRJ23g9UenQ4pvs=; b=kpyO+o1FMJSkM+/VWSsnCuuyFQy/+MJwJy/pQjWt4s8sGnt5ZQ5LPNfwX/p0dUJ/Gx hcIzWgvFZpvNIQHy4M5jwno0cVPuO1QCXPX1Dtrt2KdZQWIRWAwvh9rASIy0dknNAZxu KeDJpilpbdZK4NRk8zb6MoF7+4ylmVvwhDsEypTSk6WQkyDo8X9CgZt9FEhkYG8f842s eLWZW5+GhSx+83WS2miUbcmEje2a9xLim7TJNB21pnhJku4ghAfq3SnXFmzUUGGBRB4Z kDtStID88oa4bKwe+xiSAqjG2xCm4VjVStDiRYllHfMDlvew5YUVA8f8BF0aIBOebhyc GkDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718619271; x=1719224071; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0L2QKu3Q7F2VAvVct8HM+iyLoch8jRJ23g9UenQ4pvs=; b=mBXkhPr3APKoCMx1OusP/9CtIK0MhwF8IME+iJ0+n062JYUxZKOvNwCmEVv4texOIF G3SCzqI7C4OuCHX50W4ZoOupnGTQUcKXhKZeSsTgSspYnXD0HvacqIMsI9DY0kTK3K9X csy/qerwveH9p7ivpmQM69ZBuwkKNcAZSBHxHnLoE/15SMlNn0zzCF0Lmpr/liLtnG4c fsmEJAHxN9STtMt7QuBhGE0QzPYgRG7oH7vYBLBvnFJT2fI/dbiUmu8H+0Am9XHLpEqx Ua3IRHk5VnsoT0UuKoubqY4kbcTrV6me/Efnq2W/1As2yxOCfhoma/gXPq1tnTXce+WC yMeQ== X-Gm-Message-State: AOJu0Yx85SB6RNDrmV/0qHERm2RsmsH4Wnb7WcR4YxU/LNaA/7mmyogB 0LcoS5TPAHMtWYRAwVcEXSammz9PbqeRZM4N98g5OKKBQN+yPPexkJ4OB9J3IUM= X-Google-Smtp-Source: AGHT+IHjcNWtbscWjOycuRP6ZbrX0R2vbVcNhZbDu37dTE+ifA26a643fuMVOTh7O5KL41vZEidEVg== X-Received: by 2002:a50:d4d8:0:b0:57c:6953:2cac with SMTP id 4fb4d7f45d1cf-57cbd67ed7dmr6439574a12.22.1718619270598; Mon, 17 Jun 2024 03:14:30 -0700 (PDT) Received: from localhost (p509153eb.dip0.t-ipconnect.de. [80.145.83.235]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb7439646sm6202135a12.88.2024.06.17.03.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 03:14:30 -0700 (PDT) Date: Mon, 17 Jun 2024 12:14:29 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Roland Hieber Message-ID: References: <20240614155900.799336-1-u.kleine-koenig@baylibre.com> <20240617091803.zb2y7ojp7toikifk@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gwvlirbrhmnw5hcp" Content-Disposition: inline In-Reply-To: <20240617091803.zb2y7ojp7toikifk@pengutronix.de> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 X-Mailman-Approved-At: Mon, 17 Jun 2024 16:03:33 +0200 Subject: Re: [ptxdist] [PATCH] libpwm: New package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false --gwvlirbrhmnw5hcp Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Roland, On Mon, Jun 17, 2024 at 11:18:03AM +0200, Roland Hieber wrote: > On Fri, Jun 14, 2024 at 05:59:00PM +0200, Uwe Kleine-K=F6nig wrote: > > libpwm is a thin abstract layer to drive PWM devices under Linux. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig >=20 > Thanks for your first contribution, u.kleine-koenig@baylibre.com! >=20 > (No, seriously: nice to read you again! :-) > Do you want to add yourself to .mailmap?) Wouldn't that make all my prior contributions to appear having been done with my current email address? If so, I don't want to add such a mapping. > > --- > > patches/libpwm-f7a7496fcb9d/autogen.sh | 1 + > > rules/libpwm.in | 8 ++++ > > rules/libpwm.make | 57 ++++++++++++++++++++++++++ > > 3 files changed, 66 insertions(+) > > create mode 120000 patches/libpwm-f7a7496fcb9d/autogen.sh > > create mode 100644 rules/libpwm.in > > create mode 100644 rules/libpwm.make > >=20 > > diff --git a/patches/libpwm-f7a7496fcb9d/autogen.sh b/patches/libpwm-f7= a7496fcb9d/autogen.sh > > new file mode 120000 > > index 000000000000..9f8a4cb7ddcb > > --- /dev/null > > +++ b/patches/libpwm-f7a7496fcb9d/autogen.sh > > @@ -0,0 +1 @@ > > +../autogen.sh > > \ No newline at end of file > > diff --git a/rules/libpwm.in b/rules/libpwm.in > > new file mode 100644 > > index 000000000000..6d07e056a3e5 > > --- /dev/null > > +++ b/rules/libpwm.in > > @@ -0,0 +1,8 @@ > > +## SECTION=3Dsystem_libraries > > + > > +config LIBPWM > > + bool > > + prompt "libpwm" > > + select KERNEL_HEADER > > + help > > + drive Linux PWM devices from userspace > > diff --git a/rules/libpwm.make b/rules/libpwm.make > > new file mode 100644 > > index 000000000000..b7c1810951e5 > > --- /dev/null > > +++ b/rules/libpwm.make > > @@ -0,0 +1,57 @@ > > +# -*-makefile-*- > > +# > > +# Copyright (C) 2024 by Uwe Kleine-Koenig > > +# > > +# For further information about the PTXdist project and license condit= ions > > +# see the README file. > > +# > > + > > +# > > +# We provide this package > > +# > > +PACKAGES-$(PTXCONF_LIBPWM) +=3D libpwm > > + > > +# > > +# Paths and names > > +# > > +LIBPWM_VERSION :=3D f7a7496fcb9d >=20 > I think it makes sense here to have a pseudo-git-describe string > containing the date of the commit, so that future versions stay > sortable, e.g. 2024-04-09-gf7a7496fcb9d. (You'll have to rename the > patch folder too). Yup. >=20 > > +LIBPWM_MD5 :=3D 8ed77baaad0328359cbaf075517b0025 > > +LIBPWM :=3D libpwm-$(LIBPWM_VERSION) > > +LIBPWM_SUFFIX :=3D tar.gz > > +LIBPWM_URL :=3D https://git.kernel.org/pub/scm/linux/kernel/git/uklei= nek/libpwm.git/snapshot/$(LIBPWM_VERSION).$(LIBPWM_SUFFIX) > > +LIBPWM_SOURCE :=3D $(SRCDIR)/$(LIBPWM).$(LIBPWM_SUFFIX) > > +LIBPWM_DIR :=3D $(BUILDDIR)/$(LIBPWM) > > +LIBPWM_BUILD_OOT :=3D YES > > +LIBPWM_LICENSE :=3D LGPL-2.1 AND 0BSD >=20 > Use LGPL-2.0-only here (SPDX 2.0), as the copyright dedication doesn't > say anything about "or later".=20 > Are the "test programs" mentioned in the license the ones that you > targetinstall at /usr/bin/pwmtest and /usr/bin/pwmtestperf ? Yes. > > +LIBPWM_LICENSE_FILES :=3D file://COPYING;md5=3D41d65f310284fe1f2945ea9= c57f297c7 >=20 > Note: COPYING does not include the LGPL license text; since you are the > upstream maintainer, consider adding it to the repository (see > ). I'll add that to my todo list. > > + @$(call install_fixup, libpwm, AUTHOR, "Uwe Kleine-Koenig ") >=20 > This is a different e-mail address than what you wrote from. Oops, same typo further up in the same file. =20 > Other than that, looks good to me. Thanks Uwe --gwvlirbrhmnw5hcp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmZwDIEACgkQj4D7WH0S /k6Z/AgAow6Tk0kFNbys2xBL3SUH4uInbNfmkmVGjCWMeNvsCbsyizDpLVJsDOkb v+rKNA7lLbbPldfjENTtv7r/0vjvJvcYormqhWndS6+/OYuhuB5paozbaQJVfhoI R7C9FeFzXMZJ1LoaDP+7PdrfLs6iJrQ5AGCWtOtdYs5KuXJAt/NbuRVBDFJ97EHd ndM+ySyw8I95yS9UcE37+MMAz49sgSfxQIYYNE6spc+nNpllmHXBv/8mLAalC2vu /VpE2KYuLKsESJVos4yWKPYMtodp5ZufxXWcdS6bulm3JsP1G40gXdCs/bk7K/Ui RII4OY2c0Uip3tBLTGDGXwI5wCjohQ== =lvbe -----END PGP SIGNATURE----- --gwvlirbrhmnw5hcp--