Re: [ptxdist] [APPLIED] kernel: fix modules.builtin.modinfo being executable

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

Hello,

On Mon, Jan 12, 2026 at 04:30:53PM +0100, ruggero rossi via ptxdist wrote:
> migrating to PTXDIST 2026.01.0, I found a problem compiling the kernel.
> In my (quite old) kernel, there are no modules.builtin.modinfo files,
> and ptxdist install fails.
> 
> It seems that the reason is this patch.
> 
> The following patch solved my problem:
> 
> --- /usr/local/lib/ptxdist-2026.01.0/rules/kernel.make	2025-12-12
> 09:44:06.000000000 +0100 +++ kernel.make	2026-01-12
> 16:14:44.223920509 +0100 @@ -285,7 +285,11 @@
>  	@$(call targetinfo)
>  ifdef PTXCONF_KERNEL_MODULES_INSTALL
>  	@$(call world/install, KERNEL)
> -	@chmod -x $(KERNEL_PKGDIR)/lib/modules/*/modules.builtin.modinfo
> +	@for fileName in
> $(KERNEL_PKGDIR)/lib/modules/*/modules.builtin.modinfo; do \
> +        if "$fileName" ; then \

	if "$fileName"

looks wrong to me. Either this gives you a "Permission denied" error, or
the file already has the x bit set :-)

The side effect is however that $? is 0 because the if swallows the
error code, so it indeed fixes the build (but probably with an error
message in the log).

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]