From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sun, 23 Jan 2022 22:50:26 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nBkkk-00BFy6-Kt for lore@lore.pengutronix.de; Sun, 23 Jan 2022 22:50:26 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nBkkj-0004DA-LS; Sun, 23 Jan 2022 22:50:25 +0100 Received: from lx20.hoststar.hosting ([168.119.41.54]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBkjq-0004D1-2R for ptxdist@pengutronix.de; Sun, 23 Jan 2022 22:49:30 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at; s=mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References :To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hznK2Gql7FMCNPxzr68L7AHjqmT1GlkGD0rvlPbXjiw=; b=Lvzg2qLfuUI2amX80YzVk0JteL 6/dm2GYilqDTdiUdVvB4B4UMP6inWzEdfn8h2dh4rUzQOKKYD90iy1C1Hj84jpPamMFtva05QyO70 WwMrATPGFHpXlieuhIWzyDZWkgSud+Sn/5eWZoxwB2aJ5noPvvwzbXhFoXF/LlopbEGM=; Received: from 194-208-208-245.tele.net ([194.208.208.245]:61928 helo=[192.168.100.101]) by lx20.hoststar.hosting with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.93) (envelope-from ) id 1nBkjo-006wxU-79 for ptxdist@pengutronix.de; Sun, 23 Jan 2022 22:49:28 +0100 Message-ID: Date: Sun, 23 Jan 2022 22:49:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ptxdist@pengutronix.de References: <20220120085436.760446-1-matthias.fend@emfend.at> From: Matthias Fend In-Reply-To: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] media-session: use install_alternative for configuration files X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi Michael, Am 21.01.2022 um 13:25 schrieb Michael Olbrich: > On Thu, Jan 20, 2022 at 09:54:36AM +0100, Matthias Fend wrote: >> This allows customization of the configuration files in projectroot. > > Hmmm, these files are supposed to be overwritten in /etc/ if you need a > custom version. I'm not sure if we should replace the original files. Yes that's right. Here are just a few of my thoughts. I thought it is the usual case when the package rules file also installs the configuration files and I don't know if there is an 'install a file from projectroot if present'-function. Also, I found that a second set of configuration files is unnecessary for an embedded system. With this rule change, a user could still choose to change the configuration in /usr/share or install additional files in /etc in their own rule. However, you have the best knowledge to choose a solution that conforms to the existing rules. Thanks, ~Matthias > > Michael > >> Signed-off-by: Matthias Fend >> --- >> rules/media-session.make | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/rules/media-session.make b/rules/media-session.make >> index cda641294..5a90bc273 100644 >> --- a/rules/media-session.make >> +++ b/rules/media-session.make >> @@ -78,13 +78,13 @@ ifdef PTXCONF_MEDIA_SESSION_SYSTEMD_UNIT_USER >> /usr/lib/systemd/user/pipewire.service.wants/pipewire-media-session.service) >> endif >> >> - @$(call install_copy, media-session, 0, 0, 644, -, \ >> + @$(call install_alternative, media-session, 0, 0, 0644, \ >> /usr/share/pipewire/media-session.d/alsa-monitor.conf) >> - @$(call install_copy, media-session, 0, 0, 644, -, \ >> + @$(call install_alternative, media-session, 0, 0, 0644, \ >> /usr/share/pipewire/media-session.d/bluez-monitor.conf) >> - @$(call install_copy, media-session, 0, 0, 644, -, \ >> + @$(call install_alternative, media-session, 0, 0, 0644, \ >> /usr/share/pipewire/media-session.d/media-session.conf) >> - @$(call install_copy, media-session, 0, 0, 644, -, \ >> + @$(call install_alternative, media-session, 0, 0, 0644, \ >> /usr/share/pipewire/media-session.d/v4l2-monitor.conf) >> >> @$(call install_finish, media-session) >> -- >> 2.25.1 >> >> >> _______________________________________________ >> ptxdist mailing list >> ptxdist@pengutronix.de >> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de >> > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de