From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 18 Oct 2023 14:25:19 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qt5bz-00CyE8-Nt for lore@lore.pengutronix.de; Wed, 18 Oct 2023 14:25:19 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qt5by-0002q2-R6; Wed, 18 Oct 2023 14:25:18 +0200 Received: from mail.ela-soft.com ([213.23.49.162]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qt5bl-0002pY-5K for ptxdist@pengutronix.de; Wed, 18 Oct 2023 14:25:05 +0200 Received: from [10.0.1.140] (tupai.ela-bln.local [10.0.1.140]) by mail.ela-soft.com (mailsystem) with ESMTPSA id 11ACB1712B; Wed, 18 Oct 2023 14:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ela-soft.com; s=2021; t=1697631904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BVVUOCCB/riNS9wBvb1Gzk/C1NJKc7I2ujyc7zdXx2Q=; b=UENbsZ65HZUZjmH4uXuA29uRgBi0fYRdV1tkFhXQflkM129hvKMCA4ct9uIBl/kZ9qZNti gkRqyUDAjbKi70KhbWy6JsADh/KTF6nvRAFHfyCEq/Ufk4WD15ftYlLP+VGSIyLSbqVj5u MiK/TfTZg9R9jt+9zUZIvkS26lDgy1zxruZBcdoRsBX7LKenaPRKk1CkhdGEEyWwG9VfDq P/BiBe/pyW96TdlobGVoBIWA9Z5y6c9Q94I+w/AnvDAsNv9tsItesxVkSgvNhhbLI5lMna 15qxe9QqxxnYY0e70GE+BpI0D5l4XWlNbTPdLO7R1fdWdeWY7VEKkxtT2hsx1A== Message-ID: Date: Wed, 18 Oct 2023 14:25:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US, de-DE To: Alexander Dahl References: <20231016170734.263595-1-ahelmcke@ela-soft.com> <20231017-tackiness-overdrive-065957c90abd@ifak-system.com> <20231018-depose-trillion-6d774c70ffca@ifak-system.com> From: Andreas Helmcke Autocrypt: addr=ahelmcke@ela-soft.com; keydata= xsDiBDqtzDQRBADYJNLjNC+RK93Lhqx89UudxF0GIBfb+7AzjKRMe1aWRB5o3a14vm7ScQh+ xFIw8j2jaxM1jNZ/6eZw3nT8vy/3gRVazBnJg/JXKxU0axpvCwioodS8UKy82Wp89Gya+yhF IH10Q/2Rp2Y33oxbmwAl/YSS8eqN2oPjCrnCbEWcQQCg/w2d6Pwilu2ajlxtNby1lXOs7R0E AIveEzbSpi5hFsUgRz3MEnvBxTYvP3F0yU8x/LPl08FTa+0kNb+8FVqPxNPenBAtX0mRPLLA BRknO9xEQ8Zi1bnQ3/1Gcj1W+92XIClMkFJWTxPn5lmHOLsH1K/FaWEDS9z1+usxgPVDUVxT MbPSxhXxJU7S9tC02noI0rB1/0WLBACGNP3II9pZ5cZJP7ZBje/LtZCMK+anx6Ix9DHBpedL kkPYFBwSCEB9AciFtPa0IVkuvynqnyeiyfdwQK7ul9nMowjSWarnmWcdQkByfMNzEdVQF1oy IV+FJCx3bPYc6Bxb8mRmwEK7s6i8Y3qdgFwyyphGTWkMcFtvTr/Tknf3L80nQW5kcmVhcyBI ZWxtY2tlIDxhaGVsbWNrZUBlbGEtc29mdC5jb20+wn0EExEIAD0CGwMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgBYhBFA9ZZ0xTAe07lSeJg1WleJJOvBfBQJigjivBQkts1p6AAoJEA1WleJJ OvBfJwoAoLhmWTcXdFaqxcJpbZG2Wtb3ScCLAJ9ya78PPO4bbUqj0DbXDYL6ylWLhc7BTQQ6 rcw0EAgA9kJXtwh/CBdyorrWqULzBej5UxE5T7bxbrlLOCDaAadWoxTpj0BV89AHxstDqZSt 90xkhkn4DIO9ZekX1KHTUPj1WV/cdlJPPT2N286Z4VeSWc39uK50T8X8dryDxUcwYc58yWb/ Ffm7/ZFexwGq01uejaClcjrUGvC/RgBYK+X0iP1YTknbzSC0neSRBzZrM2w4DUUdD3yIsxx8 Wy2O9vPJI8BD8KVbGI2Ou1WMuF040zT9fBdXQ6MdGGzeMyEstSr/POGxKUAYEY18hKcKctaG xAMZyAcpesqVDNmWn6vQClCbAkbTCD1mpF1Bn5x8vYlLIhkmuquiXsNV6TILOwACAggAwYsD zwilCtMj1WbBxKHhjyLf57L0AJsHx1SB8gixbvSS9Z1lvWri7UXwljvI747af56DgwxWs+/p c/voH/xkVHdgSEf4AuUc2lWQcoFmNHo8QJKN4An1j1H7DvJXKyffRLHj7YsgQ7NPs8/FsPm9 69oHX61xuzRiY7ndi34DduMjChFvoWV/ddQjitjvekP5gCm64TGQg23mUMGixuTWXAgUmgN0 fHPieqYXqVvEgwChgm1iZQJDSQ0sYRfOqfMK4vvwQCp6aSlRPrd06EKaOvxCL8HWUWX7tPzt n3BwxNU8uWqXFejPTymRry3WsoABRgpBvAhO8+ByoRA1ZV9EK8JpBBgRCAApBRsMAAAAFiEE UD1lnTFMB7TuVJ4mDVaV4kk68F8FAmKCOK8FCS2zWnoACgkQDVaV4kk68F9yrACdGIe4ZU1K S633UcVEUIH8vAQ/qCAAnjXHahTIOEw5yN93a2o6INLx6FlP In-Reply-To: <20231018-depose-trillion-6d774c70ffca@ifak-system.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-102.1 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] lighttpd: Version bump, 1.4.67 -> 1.4.72 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Alexander, Am 18.10.23 um 13:38 schrieb Alexander Dahl: > Hello Andreas, > > Am Wed, Oct 18, 2023 at 12:53:58PM +0200 schrieb Andreas Helmcke: >> Hello Alexander, hello Michael, >> >> Am 18.10.23 um 07:54 schrieb Michael Olbrich: >>> On Tue, Oct 17, 2023 at 08:05:11AM +0200, Alexander Dahl wrote: >>>> Hello Andreas, >>>> >>>> first of all, thanks for taking care of this, my remarks below. >>>> >>>> Am Mon, Oct 16, 2023 at 07:07:34PM +0200 schrieb Andreas Helmcke: >>>>> Bugfixes and several changes. e.g. >>>>> - Stronger TLS defaults >>>>> - HTTP/2 Support now as optional module >>>>> >>>>> see: https://www.lighttpd.net/releases/ >>>> >>>> Link: https://www.lighttpd.net/2023/1/3/1.4.68/ >>>> Link: https://www.lighttpd.net/2023/2/10/1.4.69/ >>>> Link: https://www.lighttpd.net/2023/5/10/1.4.70/ >>>> Link: https://www.lighttpd.net/2023/5/27/1.4.71/ >>>> Link: https://www.lighttpd.net/2023/10/6/1.4.72/ >> >> thanks, changed that >> >>>>> Signed-off-by: Andreas Helmcke >>>>> --- >>>>> rules/lighttpd.make | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/rules/lighttpd.make b/rules/lighttpd.make >>>>> index 3aa54a1fb..7b7abf7d2 100644 >>>>> --- a/rules/lighttpd.make >>>>> +++ b/rules/lighttpd.make >>>>> @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd >>>>> # >>>>> # Paths and names >>>>> # >>>>> -LIGHTTPD_VERSION := 1.4.67 >>>>> -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b >>>>> +LIGHTTPD_VERSION := 1.4.72 >>>>> +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d >>>> >>>> Builds fine, but … >>>> >>>> That 1.4.70 in particular needs a little more work on the ptxdist >>>> package, because several modules are not built separate anymore, but >>>> built-in now. This makes some of the LIGHTTPD_MOD_* options in menu >>>> not necessary anymore, and breaks targetinstall if those should have >>>> been installed before, e.g. like this: >>>> >>>> Error: ptxd_lib_install: cannot find library 'lighttpd/mod_indexfile'! >> >> I can not (re)produce your error, but ... > > Interesting. It's one of the modules always installed. Maybe we have > different options set? Comes from these lines: > > 111 # add modules that are always loaded > 112 LIGHTTPD_MODULES_INSTALL := mod_indexfile mod_dirlisting mod_staticfile $(LIGHTTPD_MODULES-y) > > Please test with PTXCONF_LIGHTTPD_INSTALL_SELECTED_MODULES set and > not set, and compare. I guess you will also find 'mod_staticfile'? Yes, you are right. I didn't use the option "Only install selected modules". If I fix this by removing mod_indexfile and mod_staticfile (which works) only mod_dirlisting remains in the list of always loaded modules. So it might be a good idea to completely do without a static list of always loaded modules and also make mod_dirlist configurable. Any objections? > >>>> The list of affected modules is in the 1.4.70 announcement. >> >> i have cleaned up the list of modules and removed the now obsolete ones. >> >>>> With 1.4.71 HTTP/2 support is moved to a separate module however and >>>> no longer built-in anymore. Should we introduce a new menu option for >>>> that or let the ptxdist user configure it with >>>> PTXCONF_LIGHTTPD_MOD_EXTRA instead? >>> >>> If it requires additional dependencies then a new option is mandatory. >>> If not, then I don't really care either way. Just leave it as is I guess. >>> >> >> I have decided to create a new menu option because i do think, that >> this is a central/fundamental part and not some exotic stuff so it >> deserves one. > > Thanks. It's good if you can turn it off. Might save some space for > folks who don't want HTTP/2 for whatever reason. > > Greets > Alex > >> >> >>>>> LIGHTTPD := lighttpd-$(LIGHTTPD_VERSION) >>>>> LIGHTTPD_SUFFIX := tar.xz >>>>> LIGHTTPD_URL := http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX) >>>>> -- >>>>> 2.39.2 >>>>> >> >> Andreas >> -- Mit freundlichen Grüßen / Best regards i. A. Andreas Helmcke Hard- und Softwareentwickler / Hard- and Software Developer ela-soft GmbH Entwicklung|GEMOS access / Development|GEMOS access Breitenbachstraße 10 13509 Berlin Germany Phone  +49 30 891003-0 Fax      +49 30 891003-22 ahelmcke@ela-soft.com http://www.ela-soft.com ela-soft GmbH / Company of limited liability Sitz der Gesellschaft: Berlin / Place of residence: Berlin Handelsregistereintrag / Commercial Register entry: Amtsgericht Bln Charlottenburg, HRB 114128 B GF: Julius von Resch / Board of directors: Julius von Resch