mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Juergen Borleis <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] alsa-lib: add missing use-case-manager -> mixer dependency
Date: Wed, 26 Feb 2020 08:08:27 +0100	[thread overview]
Message-ID: <f7973dce51d9445c613298ef1868e2836050ee78.camel@pengutronix.de> (raw)
In-Reply-To: <20200225170302.1037-1-p.zabel@pengutronix.de>

Hi Phillip,

Am Dienstag, den 25.02.2020, 18:03 +0100 schrieb Philipp Zabel:
> Fixes the following build failure if ALSA_LIB_UCM is enabled but
> ALSA_LIB_MIXER is disabled:
> 
>     CCLD     libasound.la
>   .../arm-v7a-linux-gnueabihf/bin/ld: ucm/.libs/libucm.a(main.o): in function
> `snd_use_case_parse_selem_id':
>   .../alsa-lib-1.2.1.2/src/ucm/main.c:1968: undefined reference to
> `snd_mixer_selem_id_parse'
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  rules/alsa-lib.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/alsa-lib.in b/rules/alsa-lib.in
> index ae859fee376a..23c6c9b1cd1c 100644
> --- a/rules/alsa-lib.in
> +++ b/rules/alsa-lib.in
> @@ -8,6 +8,7 @@ menuconfig ALSA_LIB
>  	select LIBC_PTHREAD
>  	select LIBC_RT
>  	select GCCLIBS_GCC_S
> +	select ALSA_LIB_MIXER		if ALSA_LIB_UCM
>  	help
>  	  This is the userspace library to the kernel's "Advanced Linux Sound Architecture" feature

And I thought I had test *all* permutations...

Acked-by: Juergen Borleis <jbe@pengutronix.de>

-- 
Pengutronix e.K.                       | Juergen Borleis             |
Steuerwalder Str. 21                   | https://www.pengutronix.de/ |
31137 Hildesheim, Germany              | Phone: +49-5121-206917-5128 |
Amtsgericht Hildesheim, HRA 2686       | Fax:   +49-5121-206917-5555 |


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2020-02-26  7:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 17:03 Philipp Zabel
2020-02-26  7:08 ` Juergen Borleis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7973dce51d9445c613298ef1868e2836050ee78.camel@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox