Re: [ptxdist] [PATCH] xorg-fonts: make all xorg-font packages tristate

["Baeuerle, Florian" <Florian.Baeuerle@allegion.com>]

Hi,

Am Dienstag, den 31.07.2018, 11:31 +0200 schrieb Michael Olbrich:
> Hi,
> 
> On Tue, Jul 31, 2018 at 08:54:14AM +0000, Baeuerle, Florian wrote:
> > the approach works for me, at least for completely selecting or deselecting
> > a font via collection. You have to select MENU_FONTS and XORG_FONT_TTF as
> > module. I have a package which then selects noto fonts as dependency.
> > 
> > When deselecting this package in a collection, I end up with a rootfs
> > containing no fonts. When selecting the package, I have the font.
> > 
> > I admittedly did not check all scenarios and corner cases, like (de)selecting
> > a subset of fonts via collection.
> > 
> > We really need such a feature because we have products with and without
> > display and the latter ones do not have enough NAND to contain the fonts.
> > 
> > 
> > The solution might be ugly but it solves a problem.
> > 
> > If you have other ideas, I'd be willing to discuss and eventually implement
> > them, because we really want to be able to (de)select fonts via collection.
> 
> If only want to switch from 'some fonts' to 'no fonts', then the goal
> should be to leave the individual font packages as 'bool' and only change
> MENU_XORG_FONTS/XORG_FONTS to tristate.

Well, actually we require two different subsets of fonts and no fonts. I just
did not yet make enough progress to test that.

> 
> However, that's currently not quite that simple because xorg-fonts provides
> the dependencies. Hmmm, try this for the font packages:
> 
> ifdef PTXCONF_XORG_FONTS
> PACKAGES-$(PTXCONF_XORG_FONT_<SOMETHING>) += xorg-font-<something>
> endif

Would you accept such a patch?

I think being able to select sets of fonts via collection would be nicer.
Can you see issues with above patch that would prevent that from working?

I totally see that it would be nicer having distinct packages per font, but
also I have no clue how that could be done properly. Maybe the ipkg should contain
a postinst/postrm hook to manipulate fonts.dir and fonts.scale? But then also the
fc-cache should be invalidated if someone really wants to use opkg on a target
device for updating... 

> 
> Then the packages should be skipped if XORG_FONTS is not selected in the
> collection.
> 
> Michael
> 

Best Regards
Florian
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de