From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 May 2024 14:24:36 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s2rxs-00HJ7R-2L for lore@lore.pengutronix.de; Fri, 03 May 2024 14:24:36 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1s2rxs-0004gi-1P; Fri, 03 May 2024 14:24:36 +0200 Received: from smtp126.ord1d.emailsrvr.com ([184.106.54.126]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2rxa-0004gM-Bs for ptxdist@pengutronix.de; Fri, 03 May 2024 14:24:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1714739056; bh=NtpPKAwLEu5uuCX2pR/yoXdaLf2edX5PN/5jwMAQWv4=; h=Date:Subject:To:From:From; b=LXvmywVxD0UgryUIT+T/Hi3hFlLobAzNzF98aAgqkfsCna1VtH87lZis9R1vhVj0l Mo9YHOis73xBULHQf2Aaz59OFFI7fbhg88NzknyAa/j4j4ekUlPHAwVGWCW/52+U8U zZ3STsS7d3T0pwQVp+XNzNP+3CKeIuNTRIisVUxY= X-Auth-ID: abbotti@mev.co.uk Received: by smtp24.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 1938DA00C6 for ; Fri, 3 May 2024 08:24:15 -0400 (EDT) Message-ID: Date: Fri, 3 May 2024 13:24:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ptxdist@pengutronix.de References: <20240502145322.141754-1-abbotti@mev.co.uk> <20240503-evade-jumble-3c1c96970cb1@thorsis.com> <20240503-amiss-veteran-105160060dfa@thorsis.com> From: Ian Abbott Organization: MEV Ltd. In-Reply-To: <20240503-amiss-veteran-105160060dfa@thorsis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: ac60544a-3dc7-4565-992a-197c8c614539-1-1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] vim: allow vim to be installed alongside busybox vi and xxd X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On 03/05/2024 10:40, Alexander Dahl wrote: > Hello Ian, > > Am Fri, May 03, 2024 at 10:12:47AM +0100 schrieb Ian Abbott: >> On 03/05/2024 07:59, Alexander Dahl wrote: >>> Am Thu, May 02, 2024 at 03:53:22PM +0100 schrieb Ian Abbott: >>>> + >>>> +comment "BusyBox' vi is selected!" >>>> + depends on VIM_VIM && BUSYBOX_VI >>>> + >>>> +config VIM_VI_SYMLINK >>>> + depends on VIM_VIM && !BUSYBOX_VI >>> >>> The !BUSYBOX_VI is redundant, but I guess one can keep it. >> >> I'm not sure why it's redundant. I don't want this option and BUSYBOX_VI >> fighting over the symlink to /usr/bin/vi in the image. > > Right, there should be only one package setting that symlink. > > What I meant was: VIM_VIM already depends on !BUSYBOX_VI so if > VIM_VI_SYMLINK depends on VIM_VIM, then !BUSYBOX_VI is already > implicitly satisfied and stating it again is not strictly necessary. Actually, my patch removed the dependency of VIM_VIM on !BUSYBOX_VI so that /usr/bin/vim can be installed alongside busybox's /usr/bin/vi. I'm not sure if there is a valid use case for installing both busybox vi and vim. Obviously it would use more space in the image, but if busybox is already running, running busybox's vi should be less memory hungry than running vim. -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-