mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] vim: allow vim to be installed alongside busybox vi and xxd
Date: Fri, 3 May 2024 13:24:15 +0100	[thread overview]
Message-ID: <f47b2b87-00a9-435c-a35e-278b3e886c75@mev.co.uk> (raw)
In-Reply-To: <20240503-amiss-veteran-105160060dfa@thorsis.com>

On 03/05/2024 10:40, Alexander Dahl wrote:
> Hello Ian,
> 
> Am Fri, May 03, 2024 at 10:12:47AM +0100 schrieb Ian Abbott:
>> On 03/05/2024 07:59, Alexander Dahl wrote:
>>> Am Thu, May 02, 2024 at 03:53:22PM +0100 schrieb Ian Abbott:
>>>> +
>>>> +comment "BusyBox' vi is selected!"
>>>> +	depends on VIM_VIM && BUSYBOX_VI
>>>> +
>>>> +config VIM_VI_SYMLINK
>>>> +	depends on VIM_VIM && !BUSYBOX_VI
>>>
>>> The !BUSYBOX_VI is redundant, but I guess one can keep it.
>>
>> I'm not sure why it's redundant. I don't want this option and BUSYBOX_VI
>> fighting over the symlink to /usr/bin/vi in the image.
> 
> Right, there should be only one package setting that symlink.
> 
> What I meant was: VIM_VIM already depends on !BUSYBOX_VI so if
> VIM_VI_SYMLINK depends on VIM_VIM, then !BUSYBOX_VI is already
> implicitly satisfied and stating it again is not strictly necessary.

Actually, my patch removed the dependency of VIM_VIM on !BUSYBOX_VI so 
that /usr/bin/vim can be installed alongside busybox's /usr/bin/vi.

I'm not sure if there is a valid use case for installing both busybox vi 
and vim. Obviously it would use more space in the image, but if busybox 
is already running, running busybox's vi should be less memory hungry 
than running vim.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-




  reply	other threads:[~2024-05-03 12:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 14:53 Ian Abbott
2024-05-03  6:59 ` Alexander Dahl
2024-05-03  9:12   ` Ian Abbott
2024-05-03  9:40     ` Alexander Dahl
2024-05-03 12:24       ` Ian Abbott [this message]
2024-05-03 12:29         ` Alexander Dahl
2024-05-03  9:14 ` [ptxdist] [PATCH v2] " Ian Abbott
2024-05-03 14:56   ` Michael Olbrich
2024-05-03 18:01   ` [ptxdist] [PATCH v3] " Ian Abbott
2024-05-03 18:08     ` [ptxdist] [PATCH v4] " Ian Abbott
2024-05-12 13:16       ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f47b2b87-00a9-435c-a35e-278b3e886c75@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox