Re: [ptxdist] [PATCH] barebox: Copy TF-A binaries in to barebox firmware directory

[Christian Melki <christian.melki@t2data.com>]

Hi Benjamin.

On 3/13/25 1:21 PM, Benjamin Gaignard wrote:
> If ARM trusted firmware option has been selected copy the
> generated bl32 binaries to barebox firmware directory so they
> can be included in barebox build process.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
>  rules/barebox.make | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/rules/barebox.make b/rules/barebox.make
> index c0d9c5744..15c06d685 100644
> --- a/rules/barebox.make
> +++ b/rules/barebox.make
> @@ -119,6 +119,16 @@ ifdef PTXCONF_BAREBOX_EXTRA_ENV
>  			$(BAREBOX_BUILD_DIR)/.config; \
>  	fi
>  endif
> +
> +ifdef PTXCONF_TF_A
> +	mkdir -p $(BAREBOX_BUILD_DIR)/firmware/
> +	@for i in `find $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/ -maxdepth 1 \
> +	-type f -name *-bl31.bin -printf "%f\n"`; do \
> +		cp $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/$$i $(BAREBOX_BUILD_DIR)/firmware/; \
> +		cp $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/$$i $(BAREBOX_DIR)/firmware/; \
> +	done
> +endif
> +

I sort of get what you're trying to do, but this looks like all kinds of
weird. Naming, placement, constituents and targetinstall to pre-build?
I would suggest that a better interface for what is expected between
TF-A and BB is what is needed.

Regards,
Christian

>  	@$(call world/compile, BAREBOX)
>  	@$(call touch)
>