From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.benfm.de ([2a01:238:43b6:7d00:6e8f:5a82:3ff1:eb67] helo=h2734822.stratoserver.net) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3fUi-0001nB-AX for ptxdist@pengutronix.de; Sun, 24 Jan 2021 14:31:56 +0100 References: <20210124111804.510632-1-flix.ptxdist@benfm.de> <20210124130824.7ubx4yilejyrgahw@falbala.internal.home.lespocky.de> From: Felix Mellmann Message-ID: Date: Sun, 24 Jan 2021 14:31:54 +0100 MIME-Version: 1.0 In-Reply-To: <20210124130824.7ubx4yilejyrgahw@falbala.internal.home.lespocky.de> Content-Language: en-US Subject: Re: [ptxdist] [PATCH] Added symbolic links to the midnight commander package which allows to call the viewer, the editor and the diff tool from the command line. List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: Alexander Dahl Cc: ptxdist@pengutronix.de Hello Alex, I'm sorry that I've missed to obey the line length. Since I have never made any contribution to any mailing list until now, I think I have to learn a lot. I'm also unsure if my other two contributions have even reached the mailing list as only your answer is visible... Best regards, Felix On 24.01.21 14:08, Alexander Dahl wrote: > Hello Felix, > > > On Sun, Jan 24, 2021 at 12:18:05PM +0100, Felix Mellmann wrote: >> The midnight commander allows to call internal tools by using their apropriate >> name. By adding symbolic links these tool are accessible from the command line. >> Some users may appreciate using i.e. mcedit directly without the need to start >> a midnight commander. >> >> Signed-off-by: Felix Mellmann >> --- >> rules/mc.make | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/rules/mc.make b/rules/mc.make >> index 67fc61690..9335e9d0b 100644 >> --- a/rules/mc.make >> +++ b/rules/mc.make >> @@ -71,6 +71,10 @@ $(STATEDIR)/mc.targetinstall: >> @$(call install_fixup, mc,DESCRIPTION,missing) >> >> @$(call install_copy, mc, 0, 0, 0755, -, /usr/bin/mc) >> + @$(call install_link, mc, mc, /usr/bin/mcdiff) >> + @$(call install_link, mc, mc, /usr/bin/mcedit) >> + @$(call install_link, mc, mc, /usr/bin/mcview) >> + >> @$(call install_alternative_tree, mc, 0, 0, /etc/mc) >> @$(call install_tree, mc, 0, 0, -, /usr/share/mc/skins) > > This is certainly a valuable improvement. However, please trim down > the first line of the commit message to 60, at most 80 chars. This is > common practice and good style when working with Git. > > Thanks and greets > Alex > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de