Re: [ptxdist] PTXCONF_RAUC_COMPATIBLE location

[Denis Osterland-Heim <denis.osterland@diehl.com>]

Hi Robin,

I see. It is not perfect, that image-rauc uses the variables from rauc silently.

I would suggest:

diff --git a/platforms/image-rauc.in b/platforms/image-rauc.in
index 1f9427b40..bfbe4a18a 100644
--- a/platforms/image-rauc.in
+++ b/platforms/image-rauc.in
@@ -26,4 +26,26 @@ config IMAGE_RAUC_DESCRIPTION
 help
   Optional description that will be placed in the Bundles metadata.

+config IMAGE_RAUC_COMPATIBLE
+string
+prompt "RAUC Bundle Compatible"
+default "${PTXCONF_RAUC_COMPATIBLE}"
+help
+  An explicit identification string that RAUC uses to assure an update
+  bundle matches with the correct root filesystem on the target.
+  .
+  Only if the compatible in the targets RAUC system.conf file and those
+  in the Bundle's manifest match exactly, an update will be performed.
+  .
+  This must match the client configuration.
+
+config IMAGE_RAUC_BUNDLE_VERSION
+string
+prompt "RAUC Bundle Version"
+default "${PTXDIST_RAUC_BUNDLE_VERSION}"
+help
+  Overwrite the bundle version if needed.
+  .
+  This must match the client configuration.
+
 endif
diff --git a/rules/image-rauc.make b/rules/image-rauc.make
index fe1b0e89b..1fd810f71 100644
--- a/rules/image-rauc.make
+++ b/rules/image-rauc.make
@@ -28,8 +28,8 @@ ifdef PTXCONF_IMAGE_RAUC

 IMAGE_RAUC_ENV= \
 $(CODE_SIGNING_ENV) \
-RAUC_BUNDLE_COMPATIBLE="$(call remove_quotes,$(PTXCONF_RAUC_COMPATIBLE))" \
-RAUC_BUNDLE_VERSION="$(call remove_quotes, $(PTXCONF_RAUC_BUNDLE_VERSION))" \
+RAUC_BUNDLE_COMPATIBLE="$(call remove_quotes,$(PTXCONF_IMAGE_RAUC_COMPATIBLE))" \
+RAUC_BUNDLE_VERSION="$(call remove_quotes, $(PTXCONF_IMAGE_RAUC_BUNDLE_VERSION))" \
 RAUC_BUNDLE_BUILD=$(call ptx/sh, date +%FT%T%z) \
 RAUC_BUNDLE_DESCRIPTION=$(PTXCONF_IMAGE_RAUC_DESCRIPTION) \
 RAUC_KEY="$(shell cs_get_uri update)" \

Upstream and in your configuration:

PTXCONF_RAUC_COMPATIBLE="${PTXCONF_IMAGE_RAUC_COMPATIBLE}"

and in your platformconfigs:

PTXCONF_IMAGE_RAUC_COMPATIBLE="what ever you want"

This change would be transparent for all existing use-cases and give additional flexibility.

Regards, Denis


Am Montag, den 23.08.2021, 08:54 +0200 schrieb Robin van der Gracht:
> Hi Dennis,
>
> On 2021-08-23 06:27, Denis Osterland-Heim wrote:
> > Hi Robin,
> >
> > You may simply add the platform name to the compatibility string.
> >
> > PTXCONF_RAUC_COMPATIBLE="${PTXCONF_PROJECT_VENDOR} ${PTXCONF_PROJECT}
> > ${PTXCONF_PLATFORM}"
>
> Thank you for your reply.
>
> I've been doing so for some time now. But recently I had to rename my
> platforms but I'd like to keep the compatible string the same. That is when
> I starded questioning the location.
>
> Kind regards,
> Robin van der Gracht
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de