From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 15 Jun 2022 23:04:15 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o1aBR-003JCL-Oh for lore@lore.pengutronix.de; Wed, 15 Jun 2022 23:04:14 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o1aBS-0002hz-CG; Wed, 15 Jun 2022 23:04:14 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o1aAb-0002he-A3; Wed, 15 Jun 2022 23:03:21 +0200 Message-ID: From: Enrico =?ISO-8859-1?Q?J=F6rns?= To: Alexander Dahl Date: Wed, 15 Jun 2022 23:03:21 +0200 In-Reply-To: References: <20220615142217.990960-1-ejo@pengutronix.de> <20220615142217.990960-4-ejo@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2-1 MIME-Version: 1.0 Subject: Re: [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ejo , ptxdist@pengutronix.de, jlu@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi Alex, Am Mittwoch, dem 15.06.2022 um 17:48 +0200 schrieb Alexander Dahl: > Hello Enrico, >=20 > this might be nitpicking, but still =E2=80=A6 >=20 > Am Wed, Jun 15, 2022 at 04:22:15PM +0200 schrieb Enrico Jorns: > > We do not need bundle creation capabilities on the target in most cases= , > > thus make this optional (and disable by default). > >=20 > > Signed-off-by: Enrico Jorns > > --- > > rules/host-rauc.make | 1 + > > rules/rauc.in | 10 ++++++++++ > > rules/rauc.make | 1 + > > 3 files changed, 12 insertions(+) > >=20 > > diff --git a/rules/host-rauc.make b/rules/host-rauc.make > > index c78a518f6..1851aee9a 100644 > > --- a/rules/host-rauc.make > > +++ b/rules/host-rauc.make > > @@ -23,6 +23,7 @@ HOST_RAUC_CONF_OPT :=3D \ > > $(HOST_AUTOCONF) \ > > --disable-code-coverage \ > > --disable-valgrind \ > > + --enable-create \ >=20 > From the cover letter I understood this is a new post 1.5 option, > right? almost, as the cover-letter explicitly notes this is a post 1.3 option. ;) And this line is only for completeness. The added option in RAUC is semanti= cally --disable-create and --enable-create is the default. > > --disable-service \ > > --disable-network \ > > --disable-json > > diff --git a/rules/rauc.in b/rules/rauc.in > > index 832967b44..e43692846 100644 > > --- a/rules/rauc.in > > +++ b/rules/rauc.in > > @@ -27,6 +27,16 @@ menuconfig RAUC > > =20 > > if RAUC > > =20 > > +config RAUC_CREATE > > + bool > > + prompt "Enable bundle creation support on target" > > + default n > > + help > > + Enables support for creating bundles on target. > > + Disabling this will remove functionality required for bundle > > + creation which is not required on the target in most cases and thus > > + allows to save space. > > + > > config RAUC_SERVICE > > bool > > prompt "Enable service (D-Bus) support" > > diff --git a/rules/rauc.make b/rules/rauc.make > > index 820583e59..e001956a5 100644 > > --- a/rules/rauc.make > > +++ b/rules/rauc.make > > @@ -41,6 +41,7 @@ RAUC_CONF_OPT :=3D \ > > $(GLOBAL_LARGE_FILE_OPTION) \ > > --disable-code-coverage \ > > --disable-valgrind \ > > + --$(call ptx/endis,PTXCONF_RAUC_CREATE)-create \ >=20 > Same here. This should have set explicitly to a sensible default with > the package update. Making this optional would just change that line > then instead of adding it. See above. The ptxdist default for RAUC_CREATE ("n") leads to --disable-cre= ate which changes the RAUC default (which is --enable-create). Regards, Enrico > Greets > Alex >=20 > > --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \ > > --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \ > > --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \ > > --=20 > > 2.30.2 > >=20 > >=20 >=20 >=20 --=20 Pengutronix e.K.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Enrico J=C3=B6rns=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Embedded Linux Consulting & Support=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| https://www.pengutronix.de/ | Steuerwalder Str. 21=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| Phone: +49-5121-206917-180=C2=A0=C2=A0| 31137 Hildesheim, Germany=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Fax:=C2=A0=C2= =A0=C2=A0+49-5121-206917-9=C2=A0=C2=A0=C2=A0=C2=A0|