mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] nfs-utils: don't require sqlite
Date: Mon, 17 Nov 2025 23:01:52 +0100	[thread overview]
Message-ID: <e67c2dcda9e4b259ead3633ff8eaa5ab17ecccab.camel@pengutronix.de> (raw)
In-Reply-To: <20251117092906.1304078-1-l.stach@pengutronix.de>

Am Montag, dem 17.11.2025 um 10:29 +0100 schrieb Lucas Stach:
> Sqlite is only required for nfsdcld and nfsdcltrack, both of which are
> disabled in both the host and target ptxdist rules.
> 
Sorry, just noticed that I messed up here.

Calling autogen.sh will cause the y2038 configure option to disappear,
as ptxdist host-autoconf is too old. I guess it's time to bite the
bullet and bump the autoconf version?

Regards,
Lucas
 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  ...qlite-when-nfsdcltrack-or-nfsdcld-is.patch | 38 +++++++++++++++++++
>  patches/nfs-utils-2.8.4/autogen.sh            |  1 +
>  patches/nfs-utils-2.8.4/series                |  4 ++
>  3 files changed, 43 insertions(+)
>  create mode 100644 patches/nfs-utils-2.8.4/0001-only-check-for-sqlite-when-nfsdcltrack-or-nfsdcld-is.patch
>  create mode 120000 patches/nfs-utils-2.8.4/autogen.sh
>  create mode 100644 patches/nfs-utils-2.8.4/series
> 
> diff --git a/patches/nfs-utils-2.8.4/0001-only-check-for-sqlite-when-nfsdcltrack-or-nfsdcld-is.patch b/patches/nfs-utils-2.8.4/0001-only-check-for-sqlite-when-nfsdcltrack-or-nfsdcld-is.patch
> new file mode 100644
> index 000000000000..3df7a60067d5
> --- /dev/null
> +++ b/patches/nfs-utils-2.8.4/0001-only-check-for-sqlite-when-nfsdcltrack-or-nfsdcld-is.patch
> @@ -0,0 +1,38 @@
> +From: Lucas Stach <l.stach@pengutronix.de>
> +Date: Wed, 12 Nov 2025 20:54:18 +0100
> +Subject: [PATCH] only check for sqlite when nfsdcltrack or nfsdcld is enabled
> +
> +Only those two programs actually use sqlite.
> +---
> + configure.ac | 18 ++++++++++--------
> + 1 file changed, 10 insertions(+), 8 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 6da23915836d..b67b8b3fb98b 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -369,14 +369,16 @@ AC_LIBEVENT
> + dnl Check for sqlite3
> + AC_SQLITE3_VERS
> + 
> +-case $libsqlite3_cv_is_recent in
> +-yes) ;;
> +-unknown)
> +-   dnl do not fail when cross-compiling
> +-   AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> +-*)
> +-   AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
> +-esac
> ++if test "$enable_nfsdcld" = "yes" -o "$enable_nfsdcltrack" = "yes"; then
> ++  case $libsqlite3_cv_is_recent in
> ++  yes) ;;
> ++  unknown)
> ++     dnl do not fail when cross-compiling
> ++     AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> ++  *)
> ++     AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
> ++  esac
> ++fi
> + 
> + if test "$enable_nfsv4" = yes; then
> + 
> diff --git a/patches/nfs-utils-2.8.4/autogen.sh b/patches/nfs-utils-2.8.4/autogen.sh
> new file mode 120000
> index 000000000000..9f8a4cb7ddcb
> --- /dev/null
> +++ b/patches/nfs-utils-2.8.4/autogen.sh
> @@ -0,0 +1 @@
> +../autogen.sh
> \ No newline at end of file
> diff --git a/patches/nfs-utils-2.8.4/series b/patches/nfs-utils-2.8.4/series
> new file mode 100644
> index 000000000000..778729744955
> --- /dev/null
> +++ b/patches/nfs-utils-2.8.4/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-only-check-for-sqlite-when-nfsdcltrack-or-nfsdcld-is.patch
> +# da6a4db26035fb833a2141c392b46eac  - git-ptx-patches magic




      reply	other threads:[~2025-11-17 22:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  9:29 Lucas Stach
2025-11-17 22:01 ` Lucas Stach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e67c2dcda9e4b259ead3633ff8eaa5ab17ecccab.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox