From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 09 Apr 2024 12:27:00 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ru8gu-004J0f-1K for lore@lore.pengutronix.de; Tue, 09 Apr 2024 12:27:00 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ru8gt-0007v8-QO; Tue, 09 Apr 2024 12:26:59 +0200 Received: from mail-he1eur01on2109.outbound.protection.outlook.com ([40.107.13.109] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ru8gn-0007us-Mb; Tue, 09 Apr 2024 12:26:54 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ssl2GoxpLiXaMolhmipBKarK8KxrwjKzc2v4GVuYxnDpmrVCO3vS6RtzfhrFl58V0TvYcAfOTE63CFbhGEQZA2s3tUfStvFI60uyNpAE0I3byiXWnjDdK7/YE8p6KT9aHdH8qnrAT4ZQe4tKL0seB/lYzmedUpt0JvrppFrs+MyWcnO+pXHSysGUylxa6lqnE4VReSUYJsK0nW8XroPIws+GtIj+22fniPbWBTnUkdZrKbC03sepygBZkn3Em/Ua8CYuztyx5mVBjJ+Yi1AdZ7o3aKDmxNJJ7UquYs2FwGWIK83SGCh9JpaglKXBsG2TKmL56zVojD0dlKKrF/isqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yhJdVwSBHDh8MRxjLxaj90EVyyD0MMRqrxfO68puN5U=; b=aCD3ZwVkYgz0wjfkxNEGmTLTqTqvVNlixwEhwyzBGoeySrkN/QJOXCLcGS8avyQBMmRbCbTPn9rIfRqWBz6GoqB929Gu9zVDThHIhWYIAGYrK89e3k2u7ukLaxo4qjB93YAUa1tq0/y9OJwKlGbiNyp61C2nTDJBjUKX4BlPpzPUPtU8h0NPpoPKTTVG3vxQVhhFv3+m8cAT8sqJZCR4UjEHfQyzjqR4oxAZL4M+skZxW2clhDa6Es4q3/XKNOXrtC52kQPOVOskNEgbqLAq7u/I3p106Ru0guX6CZhmLzHm/uztVRt50H9L7qiYqGOI2NrEtEu/LCCVD1DvDUpgiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=t2data.com; dmarc=pass action=none header.from=t2data.com; dkim=pass header.d=t2data.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t2datacom.onmicrosoft.com; s=selector1-t2datacom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yhJdVwSBHDh8MRxjLxaj90EVyyD0MMRqrxfO68puN5U=; b=W6qLKqcWGghx9PBsvL31OxPXN9FsF+YuG743LfLtPZlc9USDeVSOnJtwlK2FtlONxx8hlhy9PbBQqX19xU/qRd5hpbLTNxqA0Do/qPsbaK0VzUMxm9Dm0/JGnv+dWwHsn/ktO81iRMVkbNbPg+Ma+1d+bAFZa1MoJAVEQ1SoD3o= Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) by DB4P251MB1024.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:384::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Tue, 9 Apr 2024 10:26:50 +0000 Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::ba8c:3db:3a02:7ce4]) by DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::ba8c:3db:3a02:7ce4%6]) with mapi id 15.20.7409.042; Tue, 9 Apr 2024 10:26:50 +0000 Message-ID: Date: Tue, 9 Apr 2024 12:23:53 +0200 User-Agent: Mozilla Thunderbird To: Ahmad Fatoum References: <20240409090816.2343063-1-a.fatoum@pengutronix.de> Content-Language: en-US From: Christian Melki In-Reply-To: <20240409090816.2343063-1-a.fatoum@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: GVX0EPF0000FA86.SWEP280.PROD.OUTLOOK.COM (2603:10a6:144:1:0:4:0:1d) To DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9P251MB0618:EE_|DB4P251MB1024:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bgDdAR34wuWXIL3v2qE+wNa1a/AnbFgm6MHn1V9IuHRM56GWfCMdc3tZnscD+mSljx5NMSMCujY9+auZGygXlPfY28pDmxAEQesnahTLTTX+ngjt+1JzyspkZRTGnJxm3fP3e2sq7I0YL4TiqBZwO1zVnREvueqwIWmiGEhvDbtTIx3qDley8R0HT8tRFcOvlaqzhuyMP4Y9GcA2yWPuU2+1bOMcm3kRLpmhEFXNN1PkJG9jbHfwkOCthi/DnGXf519tjxRK5mvrE512hC0fnRcDdcsU3tK+eQ/maJR93wRWaN2VWrPdiJeffmiGZofPtvBhwOFh5YQUoKCjw0XgnJhfSXUwahAG7BxphLFIdAna8yIo+0YhVvsL7bYBam0IddFjokdujSdMINZcCq9RdP5N3CnMNAHwSUiqZai9o6J8BRZMSN/wTviB8jhTOBdYgKYpYwmoPlVVrd8iLTuQSdMBpj0pig5++vMSxImeTdd3WV/hxsF8M4X+CmqvdzjLwEa3kwD3e2sPQmXcjigXf50UJ3Qh8OcRw50e2WpezEFoj55y+IyKMsygRBMZTV6kdD4aYjUQ/ZNyeeE0mdjFXt31u1BUP+S+SkNI5y58Xwc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P251MB0618.EURP251.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGFJZXRyYmdUOE1CcGxSRWlRNDVGZ1k3MlIwVlh1M29weVFZM21FUDVMamp2?= =?utf-8?B?THJ0WkpLN0d1aENZUjRUK1puVExudFZzT0Y0Qms2NElOY0x4aW9sKy9jTDcz?= =?utf-8?B?TG1GbkZwOGdOaXFnY1piQVRKdVZPWWlvVDZnUU5kakE5UVJ1aGEwMndWRlpp?= =?utf-8?B?RkJxNkR4VjJ0Q2FwWmQwSFFsTWp0YUpmR09OZ2xtdjJQbys5dTVzYlkvazVP?= =?utf-8?B?L3k5UVdyL0tkelRxZWU2L1ZUQmFCK1Y1Zkd6dWRnY0J0enJ1R2NlNElmQmU1?= =?utf-8?B?UzF3WUM4ajhOa1Fpd2RmeG1lOXl2YlpOanFxK2t2OEt3S21DSEFsN2ZUWk85?= =?utf-8?B?ZTNvZG42WUVFb3hsdzdUdEg3UFVWbnBoV1RTdjBUbVgvR2g3TVcrVkY4ajFP?= =?utf-8?B?VGxqdkFVb3JKbTdvQm1LMnI3UEd0WVllYStrN0Q5b3ZBZ1grOEdYZWtZcUpN?= =?utf-8?B?WlFLY0lWUE53b2RiRk91WWtMaVhMRWFFRjNXeDlHOVpBekpqMjR4WEV5bS80?= =?utf-8?B?N29EUytnaEpaTjE0ODJCRXJ0Y0JWbHAyZjNFQmdoT3ZDQmZtdGhmQ1g5LzN1?= =?utf-8?B?Zlg5ak1iZHpBS1pYSHRMS3dZQWk4MjhaaEdzKytPUEl0SlhsNmJxcXgxUGtY?= =?utf-8?B?U0xDbUxIYVR3SWlTQnNoZWV5c0ptN1VqcGVvZUN5OHYzSlhQSitucWs0VTYx?= =?utf-8?B?Z25jSkVXRzZHTThwRk9ZaTYwSFl4eXhhMWlFcGpkQXJra2duUlNvdUl1TjRy?= =?utf-8?B?TFlBRkNqN3NDWEZEN3RHSFFURy9xdEpxT0Y1a2Z6UjZvbC9MVXpLczE4bS9C?= =?utf-8?B?ZTFXNjdqS21rTnViR3ZqVURuSE1qaXpLbTc1ZS9POENjaTBCN3lZWXcwYUpz?= =?utf-8?B?VmhoTjArR3h3YVpjc1Z5VnFpMDdDUXhFWDNZKytDUXdMaFNMNHVSNnlOdmlj?= =?utf-8?B?ZlFPd09ld3lPUEVOb0twbTEvVUk0TGJBclM3YVdCbUZNZUxYbG1yQXRVTFVz?= =?utf-8?B?QWJJL3BkcjB0c0x4NnBZbDNRUzc2cUYrdm0xb0RJeVdFdHBuYzRYSkNyQlRS?= =?utf-8?B?K09UMldTaFB5d3J2em9TL3JoMWhyZElxOE1Wa0t6MmIvTlJJYXl2SEZ3T01K?= =?utf-8?B?M0JsZ2pJaGdmVHhLNG9nN29wYmxxb1l4MXRNbDJ0NThEeGhZQ3NwRmNLYjha?= =?utf-8?B?a3FuU2JyZktieVdmNlZEbnBvMTF1TUkxWXBldTA4UjFWcTVUbXViMm1KZjhp?= =?utf-8?B?UFNPTW12b3RSRVhLaHVTNURnREhCeTIydG9IQVFwTExNaml6L3hrNnorYUFa?= =?utf-8?B?RXVjclh6YlpXV2U5MWJUTW1JbTV6bEc4U3pZRDZJTk5sU1U0dm5obE04VTdw?= =?utf-8?B?MDByc2kzaVJiZEMvNXhSbUJIWGhrOWV0UUUxTWROODRyNk1kdEFPM0t3azRy?= =?utf-8?B?b2JhbVBWazRCMjF6dzM4UnZPdklwZ3NNVXRBVnp3OGRqU2NhY3BPSzVkS0Rt?= =?utf-8?B?UElxMXoyQVF3SEFSUkhjb0YwTTRZSUdwMVRBTkl6ajJ5SzJ4VXoyMU1ycmgw?= =?utf-8?B?Tm9jcnVNNjdSakRpTDFuVHlZNERsNUxiTld6a2J4bGhEZ1dsQ0prSmVYbHVZ?= =?utf-8?B?b2pRb21BNzhZNHhtWUh5aDJWdWtQdy9iaVBYNTRwQ1hnYlpzV2FhYTJVdUMx?= =?utf-8?B?ZWw3VDZwbzRiOXpWcHV0ZThoK0swaTlSQ2JQZ3lQOEd6d05sTTlOZDBhcE9D?= =?utf-8?B?bHhkWDh2UnQxSkcyK3g0OGFXbEZVdGVmVDYzclR6QlplU1d5YThDeVJmYzdI?= =?utf-8?B?eFhxeDZqWEtoRFVCenNWYnA5SWlDMzQ3ZmZaaXdLRE9BendweEM0TFIzci9l?= =?utf-8?B?akxBMEgvQ3NjK0QzVXBMZDg1SVRjMHFFVHMxZk9GL05ESXh2Yngwd1cvenVx?= =?utf-8?B?Ny9JS1Y1cy9uQnAyemxoZC9iRmpCN1kzbEVhY0VZeVVjTXlLVGM1WlJPanUr?= =?utf-8?B?aDJxL1dhRlR4UWs5bWg3UVprNmdYTGpLdlNITzZ1elJ2WEh2VXdXQUdpdWZl?= =?utf-8?B?Vnp1SFVHdDBDQjI1L2Z3c21rUFY1STJJOGc5VDdLVU9vRlFMSFVPQW1XVDJH?= =?utf-8?B?S2lCRlU5SzUybEozYWg1bVQ0YU9SZ2FsUVlNbFoxbTRwRW1GaG04dWQ1R2hq?= =?utf-8?B?Y1E9PQ==?= X-OriginatorOrg: t2data.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3abc75b-01d1-48f2-e3e9-08dc587f9149 X-MS-Exchange-CrossTenant-AuthSource: DB9P251MB0618.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 10:26:50.3214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 27928da5-aacd-4ba1-9566-c748a6863e6c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b9jvQOJCQ3uBlWfwBYCQIRa60b0Jaba8I1QAJzwOTcFIJ0BNKZ9sKMASl40r3saegWx7mQzCMhkgcyvZuZEOplkluKIr1Hx/U8Cz3yUW3KI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4P251MB1024 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] tf-a: stop defining AS and other variables in cross make env X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On 4/9/24 11:08 AM, Ahmad Fatoum wrote: > The MAKE_ENV incantation results in PTXdist defining variables like AS > and LD that point at the respective tools in the cross toolchain. > > This was unneeded as we already supply the TF-A built with a > CROSS_COMPILE option, which is used to derive the correct tools, but it > didn't hurt. > > This will expectedly change with TF-A v2.11, which should merge commit > cc277de81692 ("build: refactor toolchain detection"), currently sitting > in the integration branch. > > This changes the default value of AS to be that of the C compiler and > leads to various issues when overriding it with an assembler as was > possible before, e.g.: > > - hang during tool discovery, because `as -v` keeps waiting for input, > unlike gcc -v > > - Assembler errors during build, because GCC-specific options (e.g. > -DMACRO=VAL) are now passed to as(1). > > While TF-A changing the semantics of the AS option is arguably > strange[2], let's take the easy way out and stop setting AS, so the PTXdist > rule can build both old and new TF-A without problems. > > [1]: https://github.com/ARM-software/arm-trusted-firmware/commit/cc277de8169 > [2]: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/27163 > > Signed-off-by: Ahmad Fatoum > --- > rules/tf-a.make | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/rules/tf-a.make b/rules/tf-a.make > index 54fe7d1e37d8..b8c477476c74 100644 > --- a/rules/tf-a.make > +++ b/rules/tf-a.make > @@ -74,8 +74,6 @@ TF_A_CONF_TOOL := NO > # Compile > # ---------------------------------------------------------------------------- > > -TF_A_MAKE_ENV := $(CROSS_ENV) > - Perhaps not in this config, but isn't the make env used for other things? Like TLS stuff? regards, Christian > $(STATEDIR)/tf-a.compile: > @$(call targetinfo) >