From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 07 May 2021 13:14:46 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1leyRS-0004LV-Tx for lore@lore.pengutronix.de; Fri, 07 May 2021 13:14:46 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1leyRS-00074g-FJ; Fri, 07 May 2021 13:14:46 +0200 Received: from mail-eopbgr150059.outbound.protection.outlook.com ([40.107.15.59] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leyQZ-00074R-Hd; Fri, 07 May 2021 13:13:52 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AB8+6aJkKpj//TIgdCJBcnvExuOxiiC+oRbCqoSPeXNy+pD8iskV9ZcRANr0Tw4ejMY2pO54QXE7N4WeyUXbx4TSTrh25qggzoUfSUrFNVJ/PSVuQdnbUullMuSq6fAeeu9T5aO/Ku6i7+z927zlumFcr+7T21ohF+0Rr0O0PDr6qEsxkOqkLo57azeRHp678bQ5yi5UH6105RIAPwIxLZiPU7pw525nMSyzZkQ1SDxXWx9ndgZ3E/DkRnmSs+GYKSQ8dxLbq1bwJMsV1a5dW4PrnYVuz2+oVpWRK4CXLHs0xoNc/vrTBwS41Qu9vJG3xQVPEmppxjr9FwX+36iinQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3+YQVn5HFmP7z6SEbwNFSvbtWEezrg1VQHpfu5yhB4=; b=f2ZLiMv19P3jdgfCrpAGf+Lg6zuqgMhtwQhSmF60qzwS6RbjActWqCToksI6kOZX3nQ9oRhbojOempoA8Ms3IRztUyxoNiXkBri9SH9zIL5ZACPq2rtJmZfi517F7NdqkF4W2uG/J4d5Ut9oEEaH7FbfyaTMMB2Cu8wuN0PIoK3CiQL4cjm0TS+sVhvCohsssE0gih/j91R8JsGc5GzrHVpmiGSgf+1nzjtKSMC4zxgGO/OxzO+xR9IoM4PUY2hfCm8NtEuWe+bhukLm/ZcfyBA6PYrmelNpQ3yClb/yI3z8gw4Of8R2uTNxgF16RY9WAAGQ45a8wsvBPQ3gOBWNiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=t2data.com; dmarc=pass action=none header.from=t2data.com; dkim=pass header.d=t2data.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t2datacom.onmicrosoft.com; s=selector1-t2datacom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3+YQVn5HFmP7z6SEbwNFSvbtWEezrg1VQHpfu5yhB4=; b=M+u5tuFavdceML86PlAp9dhMzmqjXM1Pw3bCG59Rv2nClytJBfPchuFH3E46QD8Trkb65G+AOe2yTiz6SoEcNJ3j/I9qLu9pR4d7v+jqsjKW3aMDNgD0DaKez5ct1e7a2fF5s27pu1AbcQFnn+tuuu4KrEq10SnfJMJEn9jOiZE= Authentication-Results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=t2data.com; Received: from HE1PR0602MB2858.eurprd06.prod.outlook.com (2603:10a6:3:da::10) by HE1PR0602MB3289.eurprd06.prod.outlook.com (2603:10a6:7:17::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Fri, 7 May 2021 11:13:49 +0000 Received: from HE1PR0602MB2858.eurprd06.prod.outlook.com ([fe80::409f:a235:de54:364e]) by HE1PR0602MB2858.eurprd06.prod.outlook.com ([fe80::409f:a235:de54:364e%8]) with mapi id 15.20.4108.028; Fri, 7 May 2021 11:13:49 +0000 To: Michael Olbrich , ptxdist@pengutronix.de References: <73cafc96-554f-4e33-93ac-79bee71f1101@t2data.com> <20210507071553.3964996-1-m.olbrich@pengutronix.de> From: Christian Melki Message-ID: Date: Fri, 7 May 2021 13:14:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: <20210507071553.3964996-1-m.olbrich@pengutronix.de> Content-Language: en-US X-Originating-IP: [81.234.39.46] X-ClientProxiedBy: HE1PR09CA0051.eurprd09.prod.outlook.com (2603:10a6:7:3c::19) To HE1PR0602MB2858.eurprd06.prod.outlook.com (2603:10a6:3:da::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.7.217] (81.234.39.46) by HE1PR09CA0051.eurprd09.prod.outlook.com (2603:10a6:7:3c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Fri, 7 May 2021 11:13:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 566071df-4bcb-428c-6f20-08d911493091 X-MS-TrafficTypeDiagnostic: HE1PR0602MB3289: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ju+bUt22GurAlI9b2ImvXu3DfFVv3t8RlPne4YOgtIegz5eiSBEpSSiYj3ZtmrprM7DaUNfYYL9+dzkcv89GMH7WdWFeSuzi1aQyp3vaAVH16kKQOlIcFokcXhCR2nE/cJl2aZFx7/bzuhqa0g8I6pQ6l+Q8wIt6wn3eOlAwTdn26/AgvWZVBZJV/PYzvIFmaWSad1G6qZ951S12Kb01DbbCjsJLAhtYCjyeCO7tEWEg7qcF6bw/jRtoRgKtse0Er8nRz4nEr9dXtD4c1MdPkBCndzicp05x52eCGHabB1ClggvM1NYPL+XoBpt6A+bFecrq/0Wj12gvOOriuwQySPOjjlBE9nS95aSb1FMEmipsIMHGzuxDgGKjA2RPH2QmJBnLpbc969f3j3U9l5cRQDlPmvGUWl3mqeYYwJC+E7pAw2UzFeNk9zeRePHen+X9vSaXVZZwroYCM0Mp2Sc863phjvcM6arrtRVH7OH73tihBb8UWWafH9pGdZM4bryrv0d21e8BN1Qaa96pmExNeLD/LZBbhZkAoNoufVd4Dtileh8nUuuy6TfQUOFAMNV0y/f5xtNZI14nG/hUZTAer0ulB03YIUoxNs3oeIPCYJ2rwXPOdoX5ZU6JXy5S610WiRi4QTCfkwq5JLb+dhnkKaGLdowOzfCv+nh3ZoQoTWxFVqMuoKajdhi0ppgeC1FTmkYgj9t1b+AspnmYrgH1ZA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0602MB2858.eurprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(396003)(42606007)(136003)(346002)(39830400003)(6486002)(8676002)(186003)(5660300002)(83380400001)(16526019)(478600001)(8936002)(31696002)(26005)(52116002)(53546011)(86362001)(66476007)(66556008)(66946007)(44832011)(36756003)(2616005)(956004)(6666004)(38350700002)(316002)(38100700002)(3450700001)(31686004)(2906002)(450100002)(16576012)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?U1hvWlNLWmMvZjlDOVo4SE43U1htdFZ2blJSdU9QYllGNHROK2FaSGYybWdm?= =?utf-8?B?VEZjU1hPZ0pVMnFYVWp6VVc0ZUxMNEhydFArWk1mdks2N3M5SFg5akpaZGdH?= =?utf-8?B?c21ib1VFT2N0RWhHMW5XR1NIZi8vVDFLUmFXVGNiYlhac3U2dXRPd2ZnQ1Bk?= =?utf-8?B?QmNSdGowMG9QLzBML2FoNzhhaUlleEVwR2N1emgvWktBM3NkUHJCWkhmS1hn?= =?utf-8?B?cmh1ai8zV2ZoZFhSZTB1ZDFVZk1ST0Y5a21jTlA5RTdvS2FKZDdQQnZhS3cz?= =?utf-8?B?blVFWkVLeVErS2hHTXN0RDdmMklCSWtJWHBKMnpnT2ZibGFZczBHN01XM2Fw?= =?utf-8?B?LzRrUlRUZ0VZZkhjNDAwck5RM0dmNGF0Ty93NTRXNEVqZkdrWWZXYkZVUklG?= =?utf-8?B?SnpESSswTEtzZzhyaHhqTWRrMlZjUU9WSmFCNStMME9oYVh1SDBNQVVHVzBG?= =?utf-8?B?ZTczOXVJbW9ZKy9IZjcxT20xVlF0ZjUzVmhhRzcvSm1tUTFVUS85Q0VIUitR?= =?utf-8?B?Qzdtc0dwT1hmTHdrakpWbDdsSFdJZ0REWktjRjB2MStQTHhadkhWMVFvdHVB?= =?utf-8?B?STNkS0dPNXBpL0hORHZuVzEzaGRLZlFKWTlBU2hsL1JqQnE2Yy9OblhJS2VH?= =?utf-8?B?SnFuZDJjdUlCK2pYaE8zeE8rY3l0dkN2UVB5K3dIS2lucG1hU29UVzhZVElZ?= =?utf-8?B?a0FjczYrbjdzcHFxQm5UMlBFQ3FOb1R1ZlRlaEdDQXliK01rcksrRklhbDll?= =?utf-8?B?M2tDV1ZtR1U1Nmo0amJqbGlEQVNNTzFuWHhPSFdMQ3llWUw3YUZyZVYzY0xl?= =?utf-8?B?TXQraHZnSHpLSmtKanFxbGsxVjhyampKQ3JYT29qY0c4UytOTncrRXN3Z2RV?= =?utf-8?B?L25NL0o0Y0lmb3VUNUFLNTZtUE9EZ1VuL0lwMWJ4emVNOGo1bytKQWVWNHRJ?= =?utf-8?B?WDBJd2Q4N1R6N0o4Q3dzT3RBeHpFOWRIQXRaOWtvQldwc0JZMTlESDA0cmJ1?= =?utf-8?B?Z0tyRWlLYmRRT21LaG5KVDdtbFg1NEFCRmJrUG0vanlVckRFTUJWdTY0UVdS?= =?utf-8?B?b2VMUDUrT25aSzlyMHdYYzl5dnI0M29EdXF1Y3l6YlBBM3FNVUc5bldNMmV2?= =?utf-8?B?djlja2U5d0tGQmw5eFVqaVU2c0JiTDUrUXVqaGNKOWtvTmJEY1lscFpTQXVk?= =?utf-8?B?ek40TWltMUV6ZzBnc0xDSUUxeW5GWm5lNEVJaEk4cnBlanVVaE95U1RVeG1E?= =?utf-8?B?M0pYK3U3NFFsUkV0UTNKTXVTUTRCSkhXUCtSUm0wUGRyR3NKYWJ4cGRHK205?= =?utf-8?B?SDl2WDQ0ZUlXVitPbGNyL28vaXk4ZjdmcjNhek56Y0VBblI3c29rbkRhREpo?= =?utf-8?B?OFR2ZVR5WmJQNGxOVVNLSUlUWHR6U3c5SWZWZG9yWEU2dncvay9kTjZqYitR?= =?utf-8?B?YUNaREtORjFqcjc0M243d0JVN1JCNU1ka1dHbytTUzdvU2ljRXBYL2F2Tm1o?= =?utf-8?B?dDhRbTVtbERXQnU1NzgyVjlPeUFnazY3T3lJcEJZb2xHQlRiZ3dndWZvU1ov?= =?utf-8?B?S1BpUFdxS2toajN5V05la3JQbTFqcFVoNHJVL212ZFNGNWVCRGNDV2J0ZDZT?= =?utf-8?B?WXZmdnRRTld6WElhdDlzdU5wQWJhakNZSHJSNjFCWXRuREpDQUVvT1JUb3Ri?= =?utf-8?B?MmIxZElnNzNNVGpFVkVQSWovVXVOZEZUdlpycStQOHppZWJqOVNrVHovMDRR?= =?utf-8?Q?d3JIaVEU48FtkLO6+b66EkekemfHbsb04DkWRwz?= X-OriginatorOrg: t2data.com X-MS-Exchange-CrossTenant-Network-Message-Id: 566071df-4bcb-428c-6f20-08d911493091 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0602MB2858.eurprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2021 11:13:49.5757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 27928da5-aacd-4ba1-9566-c748a6863e6c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kl7ZM7fT/NME3ohQL/+yLrgq83mxJSlrqGxapHuhVRQtvx22jebEkKVv7ZRPdQRN6Ez7qJaRQWRfB4Lukb8tPRyKdet6x6WQMafvCRpUoj8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0602MB3289 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] pkg-config-wrapper: calculate the system paths dynamically as well X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de, christian.melki@t2data.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 5/7/21 9:15 AM, Michael Olbrich wrote: > Signed-off-by: Michael Olbrich > --- > > Would this work? Or do we need to exclude /usr/lib explicitly as well? > > Michael > > scripts/pkg-config-wrapper | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/scripts/pkg-config-wrapper b/scripts/pkg-config-wrapper > index d86fa7c683b5..dd786e47b212 100755 > --- a/scripts/pkg-config-wrapper > +++ b/scripts/pkg-config-wrapper > @@ -17,9 +17,11 @@ else > fi > > declare -a libdir system_path system_incpath > -libdir=( $(find ${prefix} -maxdepth 3 -type d -name pkgconfig) > -system_libpath=( "${libdir[@]/%//../../lib}" "${libdir[@]/%//../lib}" "/usr/lib" "/lib" ) > -system_incpath=( "${libdir[@]/%//../../include}" "${libdir[@]/%//../include}" "/usr/include" "/include" ) > +libdir=( $(find ${prefix} -maxdepth 3 -type d -path */lib*/pkgconfig) ) > +lib="$(basename $(dirname ${libdir[0]}))" Only one libdir? Lost lib64 in translation? Not sure I understand this. > +libdir+=( "${prefix/%//share/pkgconfig}" ) > +system_libpath=( "${libdir[@]/%//../../${lib}}" "/usr/${lib}" "/${lib}" ) This looks strange to me. libdir contains lib64, but $lib is only "lib". Doesn't this assume that system libpath is the same as the target? I'm a bit confused what the filtering needs to filter. Removing host directories, whatever they may be or removing directories that are similar to those we are including? Couldn't host path filtering be of similar construction as the cross libdir? > +system_incpath=( "${libdir[@]/%//../../include}" "/usr/include" "/include" Not sure i understand libdir to include path filtering either. :) This becomes sysroot-target/usr/lib{64}/pkgconfig/../../include, /usr/include. /include? > > orig_IFS="${IFS}" > IFS=":" > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de