Re: [ptxdist] [PATCH v3] image_tgz: Make label optional

[Alexander Dahl <post@lespocky.de>]

Hello, 

Am 2014-05-21 17:03, schrieb Alexander Dahl:
> I'm not sure how to fix this, no time anymore today, so I let you know
> this way.

Though I'm not entirely certain about some things in Makefiles I have a
solution which works for me:


% colordiff -bus ~/src/ptxdist/rules/post/image_tgz.make
rules/post/image_tgz.make                                        :(
--- /home/adahl/src/ptxdist/rules/post/image_tgz.make   2014-04-28
12:59:13.430666724 +0200
+++ rules/post/image_tgz.make   2014-05-26 09:00:10.981436285 +0200
@@ -13,7 +13,7 @@
 ifdef PTXCONF_IMAGE_TGZ
 IMAGE_TGZ_LABEL := $(call remove_quotes,$(PTXCONF_IMAGE_TGZ_LABEL))
 ifneq ($(IMAGE_TGZ_LABEL),)
-IMAGE_TGZ_LABEL_ARGS="--label '$(IMAGE_TGZ_LABEL)'"
+IMAGE_TGZ_LABEL_ARGS=--label '$(IMAGE_TGZ_LABEL)'
 endif

 $(IMAGEDIR)/root.tgz: $(STATEDIR)/image_working_dir


So I removed the quotes when assigning IMAGE_TGZ_LABEL_ARGS because
later in line 23 ${IMAGE_TGZ_LABEL_ARGS} was expanded to "something"
which led to 

echo -n "tar "--label 'foo bar baz-myproject-2014.03.1'" -zcf ";

which is obviously wrong. With my change this is

echo -n "tar --label 'foo bar baz-myproject-2014.03.1' -zcf ";

But as I said, I'm not sure if this assignement is valid in Makefiles
and I don't know (yet) what's the difference between $(something) and
${something} in a Makefile.

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de