Re: [ptxdist] [PATCH 1/4] doc: document git patch workflow

[Roland Hieber <r.hieber@pengutronix.de>]

On 14.07.2017 14:21, Bastian Stender wrote:
>> +.. note:: Optionally, you can enable the setting *Developer Options →
>> use git to
>> +  apply patches* in `ptxdist setup` to enable this permanently.
>> +  However, note that this setting is still experimental.
>
> Maybe we should mention that this can lead to unexpected side effects. I
> remember debugging a package configured with autoconf and AX_IS_RELEASE:
>
>   https://www.gnu.org/software/autoconf-archive/ax_is_release.html
>
> This lead to treating warnings as errors with "use git to apply patches"
> and thus compilation failed.

Yes, I remembered something like that, but I couldn't reproduce the 
exact error so I just formulated it generally.

>> +After commit your patches, call ``git ptx-patches`` to regenerate the
>> patches
>> +and the series file in the ``patches/foo-0.1`` folder, so they don't
>> get lost
>> +when cleaning the package.
>
> This should be consistent, so ``patches/foo-1.1.0``.

Oh, I changed it afterwards and overlooked that one. Thanks, will send v2.

  - Roland

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de