From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 30 Aug 2022 09:43:20 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oSvu3-001UOc-TK for lore@lore.pengutronix.de; Tue, 30 Aug 2022 09:43:20 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oSvu3-0003vt-86; Tue, 30 Aug 2022 09:43:19 +0200 Received: from mail-eopbgr80053.outbound.protection.outlook.com ([40.107.8.53] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSvtk-0003uw-B8; Tue, 30 Aug 2022 09:43:01 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S+H44a9ZmAK4NmcdC6inrhhtexysnH2IOTqgdlHf6N4zsZ/8hSFxtEo0jQU1+fnIuhF3y9Mc9/L9+sy8zsI0l7OLNM7VpRKdi26koeal3gJrpOY4rkGrrERCr4ydc4Bl3dV1vNllzDGkl1G4Sqr9R38QnfbnaXt0ghE6644HIzrGrYPQ9AMsTEyNDQnSPwHO4R7Ib2hSOFjI/KpI+GRRWM+Or1WOPCFmcGehNopRoiBv4/YYId6KLdj6FH3IiP9e967HDiHgUAwWsrUNGNZpQ+LWG/B44HMFXHQYr1A8xGZn5TCokaFQgICtJEsLBXPOD62ixRAs+gjSTt8gXRJBsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=snSDhgweP0Fms0O/Vq37g1DKKC+A/3wjMsacgc0e4bA=; b=iAkT3jzB9Vq3BKV/eP8Vncw2Zw26HZmmynJhLnLEA7hSkoL+YtREEvYjBVkB0IM9ZPrLV5g6E8r0jZ+XNDuUaiLsTLuW2xDg27TuJHddiBXXfFjPEe7vbMSw6EMo/w/MYUjVNq0tGEngVUN0x0Ke2Olc1ABpHW7XymUBJNMiFVd6M8+19TF9ReDauxoup9/+Rhw33IhpSAGNyiRqFKkZ0maqGeSXS0tCC/zGx5NqjonNJ8mrT6tLOjE29mCHR0zb7jtENAPvpyxvLcV3/+cssb1RGup8hcIWS1Z0v0NvZn6IyS2b3IRDcES8Jf9BmEYrjnr1dWP8WqXY9OR88TTqFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=t2data.com; dmarc=pass action=none header.from=t2data.com; dkim=pass header.d=t2data.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t2datacom.onmicrosoft.com; s=selector1-t2datacom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snSDhgweP0Fms0O/Vq37g1DKKC+A/3wjMsacgc0e4bA=; b=YvkGmJqmpMjfhv7S2j0Q7pjNstBzTggELkRjQ+QYvnAngBtQWg2ArpcMiEsCEHwkTGBPmMH+RrWt3GobudRwbOROemsBdxQv9nNxjUCjP71tOIoTLE0l9ahlPGMvFpYtrDOlKmUWHLFXEjL2C/ybONSBMqGkWtL62O6iWjMGBmg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=t2data.com; Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) by DB9P251MB0289.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:2c0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Tue, 30 Aug 2022 07:42:55 +0000 Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::a130:b2a7:9ffa:f1b6]) by DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::a130:b2a7:9ffa:f1b6%7]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 07:42:55 +0000 Message-ID: Date: Tue, 30 Aug 2022 09:41:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Content-Language: en-US To: Michael Olbrich References: <20220826133537.1843791-1-christian.melki@t2data.com> <20220826133537.1843791-3-christian.melki@t2data.com> From: Christian Melki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: GV3P280CA0098.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::30) To DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2e6fe7b-4792-432e-2043-08da8a5b4052 X-MS-TrafficTypeDiagnostic: DB9P251MB0289:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MUHaepVmpAYmHiGuVKqmpLR4OY4GIbrJr9gVtX0MIFTt34+6JN9HSnNh1Ay498b9+s09NVZ/EPGTfK8pT0aL56wHmFFaAcxXWAzkuWTDvr8Ff+UPRsWxwwpBCywmysOYasoh4c1wE/EzqSAiZkKSzACdtMsm+zugIxUta7Q/d0DebMMTNCXAU4v4hRr3SwvCK7pl5opTt467Fh93+qj/pQtiJDDJe3U5twqYb5SSTfVQAo2hlQ0peN2nbDZ1dl0Mle3hOpPyteltTRznPIUNc5+s38k1AqLQdPXkWXxWDyvuv9o/JlOOxPiyBxMAFM/UdgyhbbWuGfwkzO9zYUZlG+BkWSA/C6AXMjhweYws/rMRwj5g0TAiknKTQuV0HoMH60rD7f/l0+J7ixOLYctUAy2HqLcHXNJg1J258ZU2tJspJ76hHoHziM4vFwu1Pa8Fw7kz0JAdImt0UkzLDs/3SfIDD1o3P8QH1fep2NF7gl5WMAjp8GrOvOOMeZk6cbSPwKFLFzijKUwlTokoKu7HogrkpC7FbMW7ml1uMumedk52zKRBMuZ3hYpZuSK/zuCruFiIJZPJUGf1s2ArSOCkuIuGAUDnJtA9ZISf5j7AT0GsKv8otajwnYWsttkZki55vxK6Qgnh3QU9JsBwnwSdKvPbdCJBuPOS6mIZn4pYcAAg1mwUiQ1fyy5XSYmks3bxQ5wW4jhlNOQYKPdf4lx23T/vyh1K8RY+WqGWnSt3sNisWjtSVQmDk52IaqtxpxKDAOLYyU9S3hiyUKpD1ctuzQ0v1WXDaxR83mPCveWp5MxEt03pmT2M3SY+bqfC/B1/c2FRcsAY7j/8P7l2Uvtdew== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P251MB0618.EURP251.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230016)(366004)(39830400003)(396003)(376002)(346002)(136003)(26005)(6666004)(6486002)(6506007)(6512007)(83380400001)(478600001)(186003)(41300700001)(5660300002)(2616005)(8936002)(44832011)(2906002)(66476007)(316002)(6916009)(4326008)(66556008)(66946007)(8676002)(450100002)(86362001)(36756003)(31696002)(31686004)(53546011)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2lISTBIYm9pK3VkbUxLR2ZlWEZvRXBTRHZGOC9YOE56MEJySGovWEh6RDN2?= =?utf-8?B?OThCZTBRYUxrOHh4di9XZXdoTkZFSFphR0IzZEp0c05Hem4zMUV5WGlIWkc5?= =?utf-8?B?MEQvWGNPVFk5em9IOWVlNVJ0NmFSTDZQRHY4TjBEZW13M2o2aHBzSzlnMjVQ?= =?utf-8?B?TkdPaFlCZWY4RFVnVXVZdXRuMlQ4b1N6QTR2UkN5MDViQnZCSmdBbFYrMVNz?= =?utf-8?B?cGxNbmszMC9vR21DMGVlS1RoS1o2aDRxelZWc3E5ODRqQ2pHWWdJUjFQcnR5?= =?utf-8?B?eWV4L2M0eVo2bXVFR3B5c3FUd1BoeTVjeTQ0MmY2RVJxSFVzb1lNYkhoWS9H?= =?utf-8?B?cFY1Um1YczZ2UkNheWlhV1N5akZSUG1HYjJsdzVJT3g0VzB1dWFxb0RXZ05H?= =?utf-8?B?NHJVWTB1NENsSmV5Nm1LM05DUnFVVzUwdkRlVXA2dS9GcDJvVFJMODNzTm9R?= =?utf-8?B?QllYeEFicHVLZDhWOS9nZkV3WkYzcmZzRzVKRE45MUhzR0ZUN3VnZHN1Nk1w?= =?utf-8?B?Z0o5SzNrVWMrMWU5NE5iSnFCcW1hNnpNb0VhU2tSMjFFR0dScFNsbVV3c3hq?= =?utf-8?B?Qi9LVTllUUVsQ1V2R09ZNEpEU2NvOGwvS2cxRnNsV1NsRWhpeG4rVUdEU3A3?= =?utf-8?B?VDAxTVZWSGhzNWd3WUg0b2Q4Q0ZKN1ZqWW9IVmdLcEJwbCtuaitQR05PbjYz?= =?utf-8?B?aUhpOUNtSkJqTldLZmZncElOQXVUNmROKzU2NTd1TVZxSmtXR3BGQ2xESDl5?= =?utf-8?B?NFY1UzhMYThEZXN6azZCak1ibERYQ3ZkSlhtMjRIeFZ3RzhuUGxOMWxkNXo4?= =?utf-8?B?bS9aTFd4UFgrb09mR3hOZVEzaHdYRVYxRVAzN0NPUkthdm4yZHd0eS9mYmVS?= =?utf-8?B?eTBJaWZHYUNjaWlyV1U0TTFNT2RsajZQRmNZQ0tORWNxR1NCNjRIUlhCcU1x?= =?utf-8?B?cUFFQnFsNzhlVUlkK2lDaHE5aTRxazVpcVluUzNnK0gvUytRdWZEOHk2Y1NM?= =?utf-8?B?dFFxblhXdnVNT1VnUDlZQW5TbXU2U200RUQxcDEwUjhvcWc3cWVOeXNhSlFp?= =?utf-8?B?aWZmRmFyWmgyUUp2TEdLWU1LWHBYeVAxOFhycktHODZiVFoyYjlxV1orOW8w?= =?utf-8?B?SDlkL0dUQ3BpYXF6QVJUOEo4ZkQ4YTlzazVxUjBvSyt4bStDdEwrb0hrbDNQ?= =?utf-8?B?SGphMVR4YjR0WU44TDVpK0RMMlYrZ3IxWktDUHJiRHVWRDhKM1BPaTlUM09j?= =?utf-8?B?ZFJFVnFBUWcraGpLQlFTUTZkQ0tzM0o2NDNmakg1QzZ5ZTd1ZnIyeUhJeGh0?= =?utf-8?B?UkRKZ0s1OXJiOW9uK0ZORlY0eVJVVG5mNzVUVTFsVzJYR2xiUmpvbEQvdkRO?= =?utf-8?B?SmtXSTltVjkvcFlIbTNwNTd0aGZocUg5WXUvTWx1dkVzNVJDcis5T2xFUTJl?= =?utf-8?B?WnFxMXVpNGR4K2hLOGovZ3N3NGtBbFdxL2g4SkVhWUc2c1RNY1NQR0RCWHIx?= =?utf-8?B?clN5N0ljOVdtTG9McVFldE9yMjBBUDNhNlRTSjlYUy8wNjYwalpNeE1wQmVN?= =?utf-8?B?Zy9IRDdlMHZGMlNWL2ZwczYwZnZKYmFVb2E3cXY3QytPVHpzZHQrNnJHYkJM?= =?utf-8?B?OU1tcEpXZmVheWlLMWJjQmYyOFVNZTVwMXl4OGFMcC9JT3ppcjJXWWxjaXBq?= =?utf-8?B?ZzQ1eUtKdmc0Q3BxWlp4dkp2QVRNSHhKZVhWT0EzNHdiNWxKSGVpZVFjUmsr?= =?utf-8?B?b1FoTGF0bjczckwrY255bEVYWWZYbjBFUXRFWVBaRTBhQnRERVJ3QUJaT1ZN?= =?utf-8?B?NVlGd2Z0YXFpOHVLbHpzbDdMdFBVK0ZRdzdFMEhtekRaUDI5N2pOSXd4bjZX?= =?utf-8?B?d3gwT3FkZDVHSUtzRFNIZ25Neml4dGNrbGtFNmhEdkV6NGVrSEthVXFjbmN1?= =?utf-8?B?RnhMb2x5U3FERlF1Z2xoVEpsVzdHNTNJL2w0ZlpuVWk4TUtBdEw0V1Z2aWUx?= =?utf-8?B?cXAvM0hYT1BaM0JxYWFKWlBDci96YUVYeUF6ZlZLYW5tV2EzUXhUTkRpMC8w?= =?utf-8?B?S3F1akxIdmU4ZWZqRzFuaWJ2VUdISit3cjhTSk9WRTJJcW05U1BqSlgvQ3Np?= =?utf-8?B?M0svT25LUnA3a0FUR2gzekZFZmZvSzFaQk95Wm5SRTc5S3kyY3BWNnhtU2d3?= =?utf-8?B?b0E9PQ==?= X-OriginatorOrg: t2data.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2e6fe7b-4792-432e-2043-08da8a5b4052 X-MS-Exchange-CrossTenant-AuthSource: DB9P251MB0618.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 07:42:55.4002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 27928da5-aacd-4ba1-9566-c748a6863e6c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y1JfK46RGbMqoYFrH93vTm534ik/tYKoniuv2/C7CCwqt+VR4u4I7qeS5MAhD/NXYQE2orPJvs0s/c/0zZB8z1sqe0QnNmEeN/cGTFY9ftI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P251MB0289 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 3/3] u-boot: Move image copying from targetinstall to install. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 8/30/22 9:25 AM, Michael Olbrich wrote: > On Fri, Aug 26, 2022 at 03:35:37PM +0200, Christian Melki wrote: >> This seems like a potential issue in several packages. >> When signing u-boot images in tf-a, tf-a has u-boot as >> a dependency. But u-boot doesn't install images to be processed >> until targetinstall, which leads to problems. >> >> Some things might be targetinstall. But resulting images destined >> for the imagedir aren't really targetinstall unless >> they are also copied to rootfs. > > This is broken. 'ptxdist clean root' will remove the files from images/ and > then only targetinstall is executed. So the files won't be copied again. > > If other packages need those files, then they must be copied to > $(U_BOOT_PKGDIR) in the install stage. > > Michael > Hmm. Not sure how that is supposed to work? Do you mean that they need to be copied to pkgdir as well as imagedir? install: -> pkgdir -> imagedir targetinstall: pkgdir -> imagedir ? /C >> Signed-off-by: Christian Melki >> --- >> rules/u-boot.make | 15 ++++++++------- >> 1 file changed, 8 insertions(+), 7 deletions(-) >> >> diff --git a/rules/u-boot.make b/rules/u-boot.make >> index 0b632e8b2..bdbe03ffe 100644 >> --- a/rules/u-boot.make >> +++ b/rules/u-boot.make >> @@ -133,14 +133,7 @@ endif >> >> $(STATEDIR)/u-boot.install: >> @$(call targetinfo) >> - @$(call touch) >> - >> -# ---------------------------------------------------------------------------- >> -# Target-Install >> -# ---------------------------------------------------------------------------- >> >> -$(STATEDIR)/u-boot.targetinstall: >> - @$(call targetinfo) >> @$(call world/image-clean, U_BOOT) >> ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_BIN >> @$(call ptx/image-install, U_BOOT, $(U_BOOT_BUILD_DIR)/u-boot.bin) >> @@ -194,6 +187,14 @@ ifndef PTXCONF_U_BOOT_ENV_IMAGE_NONE >> @$(call ptx/image-install, U_BOOT, $(U_BOOT_BUILD_DIR)/u-boot-env.img) >> endif >> >> + @$(call touch) >> + >> +# ---------------------------------------------------------------------------- >> +# Target-Install >> +# ---------------------------------------------------------------------------- >> + >> +$(STATEDIR)/u-boot.targetinstall: >> + @$(call targetinfo) >> ifdef PTXCONF_U_BOOT_BOOT_SCRIPT >> @$(call install_init, u-boot) >> @$(call install_fixup, u-boot, PRIORITY, optional) >> -- >> 2.34.1 >> >> >> >