* [ptxdist] [PATCH] Fix problem with finding platforms/*.in
@ 2013-08-16 15:25 Bernhard Walle
2013-08-20 9:29 ` Alexander Dahl
2013-08-20 11:05 ` Michael Olbrich
0 siblings, 2 replies; 3+ messages in thread
From: Bernhard Walle @ 2013-08-16 15:25 UTC (permalink / raw)
To: ptxdist
ptxdist 2013.08 doesn't find my platforms/u-boot.in file. This is
because it looks for ":/path/to/bsp/platforms" instead of the variant
without colon.
Following shell script demonstrates that:
#!/bin/bash
oldifs="$IFS"
IFS=: a="1:2:3:" b="4:5:6:"
c=(${a}:${b})
d=(${a} ${b})
IFS="$oldifs"
echo ${c[@]} # 1 2 3 :4 5 6
echo ${d[@]} # 1 2 3 4 5 6
So only the variant without a ':' is correct.
The problem was introduced with 51c5786c16a9a3508af9b6cc69947a2f3b8bc7cf
on 20th June 2013. So I think it was also in 2013.07 although I didn't
test.(
Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
---
scripts/lib/ptxd_lib_kgen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/ptxd_lib_kgen.sh b/scripts/lib/ptxd_lib_kgen.sh
index 6c7b54b..c50df13 100644
--- a/scripts/lib/ptxd_lib_kgen.sh
+++ b/scripts/lib/ptxd_lib_kgen.sh
@@ -90,7 +90,7 @@ EOF
# transmogrify part into subdir
local oldIFS="$IFS"
case "${kgen_part}" in
- ptx|platform) IFS=: kgen_dirs=( ${PTXDIST_PATH_RULES}:${PTXDIST_PATH_PLATFORMS} ) ;;
+ ptx|platform) IFS=: kgen_dirs=( ${PTXDIST_PATH_RULES} ${PTXDIST_PATH_PLATFORMS} ) ;;
board|user|collection) return 0 ;;
*) cat <<EOF
--
1.8.3.4
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] Fix problem with finding platforms/*.in
2013-08-16 15:25 [ptxdist] [PATCH] Fix problem with finding platforms/*.in Bernhard Walle
@ 2013-08-20 9:29 ` Alexander Dahl
2013-08-20 11:05 ` Michael Olbrich
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Dahl @ 2013-08-20 9:29 UTC (permalink / raw)
To: ptxdist
Hei hei,
Am 2013-08-16 17:25, schrieb Bernhard Walle:
> The problem was introduced with 51c5786c16a9a3508af9b6cc69947a2f3b8bc7cf
> on 20th June 2013. So I think it was also in 2013.07 although I didn't
> test.(
No it's not in the 2013.07.x branch. I reported the problem after the
2013.08.0 release and your patch fixes my problem.
Greets
Alex
--
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601 D1D5 8FBA 7744 CC87 10D0 ***
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] Fix problem with finding platforms/*.in
2013-08-16 15:25 [ptxdist] [PATCH] Fix problem with finding platforms/*.in Bernhard Walle
2013-08-20 9:29 ` Alexander Dahl
@ 2013-08-20 11:05 ` Michael Olbrich
1 sibling, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2013-08-20 11:05 UTC (permalink / raw)
To: ptxdist
On Fri, Aug 16, 2013 at 05:25:53PM +0200, Bernhard Walle wrote:
> ptxdist 2013.08 doesn't find my platforms/u-boot.in file. This is
> because it looks for ":/path/to/bsp/platforms" instead of the variant
> without colon.
>
> Following shell script demonstrates that:
>
> #!/bin/bash
>
> oldifs="$IFS"
> IFS=: a="1:2:3:" b="4:5:6:"
> c=(${a}:${b})
> d=(${a} ${b})
> IFS="$oldifs"
> echo ${c[@]} # 1 2 3 :4 5 6
> echo ${d[@]} # 1 2 3 4 5 6
>
> So only the variant without a ':' is correct.
>
> The problem was introduced with 51c5786c16a9a3508af9b6cc69947a2f3b8bc7cf
> on 20th June 2013. So I think it was also in 2013.07 although I didn't
> test.(
Nice catch. This was indeed bogus. We're generating an array here and not a
":" separated string.
Applied.
Thanks,
Michael
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
> scripts/lib/ptxd_lib_kgen.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/ptxd_lib_kgen.sh b/scripts/lib/ptxd_lib_kgen.sh
> index 6c7b54b..c50df13 100644
> --- a/scripts/lib/ptxd_lib_kgen.sh
> +++ b/scripts/lib/ptxd_lib_kgen.sh
> @@ -90,7 +90,7 @@ EOF
> # transmogrify part into subdir
> local oldIFS="$IFS"
> case "${kgen_part}" in
> - ptx|platform) IFS=: kgen_dirs=( ${PTXDIST_PATH_RULES}:${PTXDIST_PATH_PLATFORMS} ) ;;
> + ptx|platform) IFS=: kgen_dirs=( ${PTXDIST_PATH_RULES} ${PTXDIST_PATH_PLATFORMS} ) ;;
> board|user|collection) return 0 ;;
> *) cat <<EOF
>
> --
> 1.8.3.4
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-20 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-16 15:25 [ptxdist] [PATCH] Fix problem with finding platforms/*.in Bernhard Walle
2013-08-20 9:29 ` Alexander Dahl
2013-08-20 11:05 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox