From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from vps-1010511-3500.united-hoster.de ([81.20.132.56] helo=rohieb.name) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1bdsdH-0004kc-2m for ptxdist@pengutronix.de; Sun, 28 Aug 2016 07:27:47 +0200 Received: from [192.168.178.246] (p5DDFF363.dip0.t-ipconnect.de [93.223.243.99]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: rohieb@rohieb.name) by rohieb.name (Postfix) with ESMTPSA id A043F259580F for ; Sun, 28 Aug 2016 07:27:15 +0200 (CEST) References: <1471445616-7728-1-git-send-email-rohieb@rohieb.name> <20160818065342.463fc7qfeixtb4vt@pengutronix.de> From: Roland Hieber Message-ID: Date: Sun, 28 Aug 2016 07:27:06 +0200 MIME-Version: 1.0 In-Reply-To: <20160818065342.463fc7qfeixtb4vt@pengutronix.de> Subject: Re: [ptxdist] [PATCH] ibrdtn: add packaging rules for IBR-DTN and dtndht List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0214400714==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0214400714== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pTqW7gN1C3rw33X1Cn99ce15cHBNsjQFf" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pTqW7gN1C3rw33X1Cn99ce15cHBNsjQFf Content-Type: multipart/mixed; boundary="K7eghm9U13QnmHj4CQrPuJjs83pgOOCwx" From: Roland Hieber To: ptxdist@pengutronix.de Message-ID: Subject: Re: [ptxdist] [PATCH] ibrdtn: add packaging rules for IBR-DTN and dtndht References: <1471445616-7728-1-git-send-email-rohieb@rohieb.name> <20160818065342.463fc7qfeixtb4vt@pengutronix.de> In-Reply-To: <20160818065342.463fc7qfeixtb4vt@pengutronix.de> --K7eghm9U13QnmHj4CQrPuJjs83pgOOCwx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Thanks for the feedback! On 18.08.2016 08:53, Michael Olbrich wrote: > I've made several comments below, that apply to more that one place. Pl= ease > fix it everywhere. >=20 > And check your configure options. You need to specify everything that i= s > optional or may be auto detected. Please look at some other rules for > guidance or ask me if you are unsure if an option should be specified. Okay, everything optional or auto-detected should be pinned down now. I've basically ignored every configure option relating to the toolchain, like --enable-static, --enable-maintainer-mode, --with-pic, --with-gnu-ld, etc. Some of the packages take paths for CPPUnit, but I ignored that too since tests are not run. >> diff --git a/projectroot/lib/systemd/system/ibrdtnd.service b/projectr= oot/lib/systemd/system/ibrdtnd.service >> [...] >> +[Service] >> +ExecStartPre=3D/bin/mkdir -p /etc/ibrdtn/bpsec /etc/ibrdtn/certs >> +ExecStartPre=3D/bin/chown root:root -R /etc/ibrdtn/bpsec /etc/ibrdtn/= certs >=20 > The rootfs may be read-only. These directories should be created in the= > targetinstall stage. Right! I now mkdir'd the folder in the targetinstall stage using ${ROOTDIR}, but it seems the rootdir contents are all created with my user and chown'd to root in the images stage later, so I didn't care for chown'ing them in the targetinstall stage (which additionally would have required (fake)root while building). > Break like this: >=20 > DTNDHT_CONF_OPT :=3D \ > $(CROSS_AUTOCONF_USR) \ >> + --$(call ptx/wwo, PTXCONF_DTNDHT_WITH_OPENSSL)-openssl \ >=20 > no '\' for the last line. Old habit of mine to get fewer unneccessary changes in diffs when adding options in the future. But okay, I've left it out for now :) I also added a LIBC_M dependency in the packages that needed it because the build output showed "-lm" in libtool calls. I tried to discover additional runtime dependencies, but didn't find a good way to determine which objects are loaded at run time =E2=80=93 on my machine I would have= used ldd for that, but I can't do that for ARM binaries. Is there a way without actually running the binary (in qemu)? The Guru Guide chapter on Managing External Runtime Dependencies is very sparse on that topic. For the ibr* packages I also added the GitHub releases as additional URLs, but the dtndht tarballs on GitHub have different checksums than the tarballs from the official site. Is there a way to handle that (other than ignore one site)? - Roland --K7eghm9U13QnmHj4CQrPuJjs83pgOOCwx-- --pTqW7gN1C3rw33X1Cn99ce15cHBNsjQFf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXwnYyAAoJELJBPGbdLD/qHxQP+wcpHlIT9vpMUATZyRdo94sP NvQ311Tq4B80rn6TvXG7XCm/pDORCYzsvCg4ms+7Bbo91+UPE5sdVSwI+VzyX200 BhPm4kZt77pT49LapX+mnH4GyXjhE0ji4080K1jdE1zKFbmp2KQxDLmv9lMmYQh4 hM+zG8ohgOMTCgkhya/kGsYTVqNGfg/mzC04SeO4YOM7MU5NTsCxIMO7vXMdOuh1 7AuILMXYVFLqZ0C2KiUaKc+cIqnrcuioZKuJ8oHO64uUYVlB5LQcN9XlWL7VsJs5 7XwSGWUBv7eK+gkXiUFxbJ5EPljaFUkAxJLgMiz0d8yXlgUDiRa4sIg0s90cuA6j bZW84hLhwjbzR7XYf6oAH0DQqpKv6tVpvKbDeirTP8Qc1MydLA43HGg983AWC4tp GKHll/Hb2GZxKaycMYYiNb67ziZZOwSch+0pgvfrfnx2D5l6+w2MfCqbDfuBRAxL f2UEplxh8jdm6oYRQ7OHvTmH1PYlOl4g70q+S9viVTsPefYfVON+swf5nR1NW38s AL93fTivVeT1zl2Wbk4fBKRUWzeAbV5nygeEs5NBfJaHAKw2fgjfYrNnzC4Ygz7d KZa9fv5jsAZelKGPMEUNPDp0aDykkD8PYdERilHXsvSbO8hRdXIn+Qviswzty6KW WGxtoGiv8YS/uRAKxfZK =+IZA -----END PGP SIGNATURE----- --pTqW7gN1C3rw33X1Cn99ce15cHBNsjQFf-- --===============0214400714== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============0214400714==--