From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 28 Jan 2022 17:48:42 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nDUQU-00GDX0-9e for lore@lore.pengutronix.de; Fri, 28 Jan 2022 17:48:42 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nDUQT-0007gV-Jw; Fri, 28 Jan 2022 17:48:41 +0100 Received: from mail-eopbgr10057.outbound.protection.outlook.com ([40.107.1.57] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDUQ4-0007gC-Rb; Fri, 28 Jan 2022 17:48:17 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dhoXvCIhUdmhVLTz1aKwfOxGECXSF7PYtmLwLJqIJN5kLpqcnDWTAzrEofSMOIl4TWErL17CGwOeJYsLWPVd8k1kLDMRALywrm5/GYF32LhH7ijXRwkvqEcSOcJ0FTgnfivcDsYBu1fxysIm7AQH8zoTYu6iJsZca/zFa0Y8rcc5DsdY+Ug2vhY/wLseIG8cfydyo6Xcbia675HUX6RxDhJWZ72QRhtvuTXuy0lrZbghlJ7uU/l8+G+jsNti60IOusUox/WJG2uEVnOLiMscNLSmjlsDFcycnfUnEYfQVOPOBS7KlX6QJ9tlZLMNsSE3pswNmLM8dN+9VT9oJihzRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TnmA1eLba5uXIQzAIBj1qiUzTbxe6HNRjQjf93lgfH0=; b=Ru05KC13nxEPReXkN57rzymWmcvsV5ztuZJjcWvLU6Wup5CLTR4dtwgg0iPd7vUSVIlT212m4pVVWHljI3UjAKY33rlwqBEnX4Y1BDz/zx0gkecFUKCAC7wjx0PGYTPv5+eAKMy3nFX63tYPHCpmJLLc9/DxgNBCNkC5kdz1Qt1vhnSxHsWD4QJxSmc/hwgM8zwKDJS2CHxFf/86yEIv1vvq8jevp7MxM9pWhWSXnpMfMxtmRxtFTP3A6R1T/MJiTQYBlypQ4A5J+UwdOzHC6uopLj1Um8EDo0vxH2doDvhnbqkS6KEXb22nvHgVe67FvJiqjwu8S3PKAI1UXeYPxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfvision.net; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TnmA1eLba5uXIQzAIBj1qiUzTbxe6HNRjQjf93lgfH0=; b=bP59+ce2t+67OTK5NFpxjVTJoApGvwu3s7HivLCMt8Pe/s0S97vt1tDxcMcsjOtQECO08exAamf0X21eaGMY7/tMbNpPvNLVrj8MTpGsWl+QqM8gu3HdFSR9wIsprp80Ws6wSmOh7DH3w0qPSethv4b6NJUn9KUXNsUgkWRZZ8Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wolfvision.net; Received: from HE1PR0802MB2426.eurprd08.prod.outlook.com (2603:10a6:3:e1::23) by AS8PR08MB7372.eurprd08.prod.outlook.com (2603:10a6:20b:448::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Fri, 28 Jan 2022 16:48:15 +0000 Received: from HE1PR0802MB2426.eurprd08.prod.outlook.com ([fe80::e14f:197:5001:4c56]) by HE1PR0802MB2426.eurprd08.prod.outlook.com ([fe80::e14f:197:5001:4c56%3]) with mapi id 15.20.4930.019; Fri, 28 Jan 2022 16:48:14 +0000 Message-ID: Date: Fri, 28 Jan 2022 17:48:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ptxdist@pengutronix.de, m.olbrich@pengutronix.de References: <20220124120942.557161-1-michael.riesch@wolfvision.net> <20220124120942.557161-6-michael.riesch@wolfvision.net> <20220128161041.GD11273@pengutronix.de> From: Michael Riesch In-Reply-To: <20220128161041.GD11273@pengutronix.de> X-ClientProxiedBy: VE1PR03CA0054.eurprd03.prod.outlook.com (2603:10a6:803:118::43) To HE1PR0802MB2426.eurprd08.prod.outlook.com (2603:10a6:3:e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08382655-e351-4e34-223f-08d9e27dfa19 X-MS-TrafficTypeDiagnostic: AS8PR08MB7372:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s0dDR2SKXWh1+HD/h3rESoVioOTkkyKFFznqaaw76F+c6JLGW2jpKtLj17uaUKAEXC2lRrH1E3KBiPmM51WQPF8Ky85e1HhD1lQwtak1aN7xIS9wU0b9Rodw/8JXYBCuVp7WFlx6GtJjhfX/o9XtljoCkXR+Jxyc+yZ2HSUKcp3T7a0gsJohgNb0vmAeWbhAc12xJQhQ3G/pmu44/MQaztCF1/z3k1tGjfjHhb6Ao5C8dMFeUpYtOur0jiIqQ4j5Un4694DUjAY7ph556wak7JdRhZPDD4Y366sBg1o+6FWAFYncVhZ4ELTKpu5OET71sUESosqIP/5El8ZBayFQB3o2QdVWn8szShvuBUeW/r/ruNVvswPpPXXjPfsBFaWnpQQveYDrQrckR9HcSCGtUpt7nZQ6MoMSmKPepYtB45v2TAagJKitwz/0v+Y6Mb8dX7KrefR2iqh76jU+epyXLyW3I/LZfVckERoF9o5zRlj5v7+kGPikpBHzUgWxaxF1OkA+8k1Kz01/8iV58EA+dlAUVSf2u33VABLshREmyIexniBp2skNuVOraHcCzHinGcMkACpsRcruDkc5PbYTyXZiPABqMSm35u/Nm94ImTEo0yD4sm9bGWqmZCmor1NO9tPKw/hNRcKxQhkcIvQp7+9UJ/HfuLT1SCbQujxfH51mY1Yw2Ft4XFDXHLEBzhYWxrSTJJEgz8WtjOtQxRxNWeBu2zeFsrDUOjJZDTm4Vv4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0802MB2426.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2616005)(186003)(508600001)(6486002)(86362001)(44832011)(6666004)(83380400001)(31686004)(52116002)(2906002)(6506007)(53546011)(6512007)(36756003)(8676002)(66476007)(66946007)(5660300002)(66556008)(8936002)(450100002)(4326008)(31696002)(316002)(38100700002)(43740500002)(45980500001)(20210929001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TG9YR3ZxSVppcVNNT2QyNDIrSkhhczhxR3Rkd21NcE1rYXZ2SUR2eTk2SGhE?= =?utf-8?B?VUlCRnhHSDdZaE1vUmQwWFRGRGJkeGZxNEdQNFdBVFZEQUk2TjJJZmhOSkVn?= =?utf-8?B?MVRtQkg4NXFERnRkQ0FPVzZ2SWlzSm1yYTNUYTNRV3pySHk1dW1xaE1PWFQx?= =?utf-8?B?TlZKRHEzVVhLdWZFRFlUb3ppaGJzWDRWVXFjWHpibStPR3J1OW5GSXFpbjFr?= =?utf-8?B?ZXRBaGVVOFVLUEJPSFZzUU1vUWIzUmtpdm1EdkZhbmNhYktwN3BsUDlpS2dI?= =?utf-8?B?NjBRZGVRbDBYY0s5Q2txT0JCUU1lbVdHdlhpQ1Q0ekdyeHVGR1RRTlY3ejdn?= =?utf-8?B?Qk5McWVzUm1HYTNrQXNtY0RkdkFORGRtdmZ0azFlWFczMzBHVFJaT3N5bzQ0?= =?utf-8?B?Ry9Wb1VOMjFLQmZRbDZiREFuYXlhWU1tcm5oZW5QaEluNXRKZjM4b25jS0xu?= =?utf-8?B?dmMyRWxnNmdySXVCcjd4YVErWjJ4bmpibFpKalMyVG05TUZJVGxzcHlPb0FM?= =?utf-8?B?dVhUd2Z0SisyWXVNblB4bkVVQjVUbi9wR1lreXJTYlNqZDd5bmF2cTJJamE2?= =?utf-8?B?TFFqV3FPVlFuQ0VkTDVXaWEvQURJRW1WNElvQWJXSmZsbVQwb2txOU9hQzBu?= =?utf-8?B?cWl2cUlORHJHdjh4cVA3OUYxVDJYUUJZcjNmZTZNL0lhcjNGSC9JVlVnakE4?= =?utf-8?B?NmwyT3pHdGw1aTVXTTkyU2Yzd0hCb1pTd0lHdEdhcDBBbFYzajgrYTJZRnFX?= =?utf-8?B?bFNBc3dGTTZaSUptQ20yblE2YmFlNG5FWjRtTzhvSGFjN0JCNE44YXZrcjV2?= =?utf-8?B?bjRWYnJ5cmkveXQ2bWRVaks4WWRlbUh2cUZjWlQ3RHVYbTdmWHJncCt6MnBN?= =?utf-8?B?em40WFRzTEs4b1dBc25OV1hYMzRtWGRjcjEwQ1ZVTzlxNHRCT25KQUloajJl?= =?utf-8?B?VUdtRG9UMzQ3bENPSDh2TWNWRmNFYUNVSEo3WEYvQ25tUkNoSC9pY0tYclh1?= =?utf-8?B?SUo3K1MvWXBsSG1BbTFvQU5UY00wZk5hR1hoNmlWSGppN3dmb0J3cnRlcUxk?= =?utf-8?B?NG1JeXE5cWczMzJnMjlQN2tKTU9NaitwK3padmI1YXdsRjVDaG9DWXIwdGJq?= =?utf-8?B?b1hjSFV2L1dOZThCNVBEcHdCVnJ0eEhFUVl4M2JRb1JMT3M0bXg2VGQ4aWdr?= =?utf-8?B?Q3FnL2lNTW1RL0QzWTR3RSt4aGZmakp6VzFDU1JaY2p0T2FlV0w0V1VRUzlN?= =?utf-8?B?c0hDczBRK2p0c3BpQVArYllyeThKWGQ2T01hNllsQng3VXJCNStpMzF6NWxx?= =?utf-8?B?clR5UVAxZ2tmbUJEejJqOEZMdTREYnVtWjZHbzFIdkVZR0dFSjl6S2I4Q1NF?= =?utf-8?B?YnMzY0tNUXRoYzQrTlg1dU04UWpmeUJ1WFZiUGxMc3ZPTFJIWTdaUlFJL3VS?= =?utf-8?B?WnJXeERNeTM4OFk0clR1d3huSHg3VUJpSzlrMFlWL1B6SGhPLytwaDdObmFO?= =?utf-8?B?clpOc25ROUJPZCtSYzZXdmNJQS9hRHBKYnUvVFE3b203dWRuZHJtR2FINkdu?= =?utf-8?B?VWZwUGRyWDJvdHJidTRYSEU5Y1YvQXUrcFVRb1cydUZmUlFUbU1VUWdPZ2Ur?= =?utf-8?B?Uzk3NzFCUmhUakNwbHdvZnc3dUhqZkJhdGY3aVVmOWFWM2wyYXphVWZ3M0Ri?= =?utf-8?B?VGRSWmxTSGFFM2thYlNrMG1hZXhBSUNoaHlBc2FrVFc1WHBJMWZ5R1NrQUpu?= =?utf-8?B?bmtoaitPYnYvMmhYcWpwZ3NUdkpJT3h5bDVuUVNhaDJRM01BTUI2QzlxYXlj?= =?utf-8?B?dk4zWHJrR2Z2dXk4SXFrR0I3cnF6MFNtellkbUtBYW9hWGdHZkowMm9xSTZF?= =?utf-8?B?bnM3MFl2Sjk3TVRoejl2OHZLU1BIK05IVlBUbzJBa2d1NzhSTWZ2b0ZiL3dC?= =?utf-8?B?ZmplSDVKbnZEdHRQaU94NWg1b0l4WGJNdkkrL054N210R2FWQS83dkxnbGNh?= =?utf-8?B?ZzQwOWtJSVIrSk9Id3ptc0xWVjY3UWJRRVlPeXRHUmNGSUZqSFM0b0ZqL3BE?= =?utf-8?B?aCtPSER5emw3RzZhYkdrTHRTU2NnN3A3aUJRUnA2a0E4clNUeTl4aXZXRm85?= =?utf-8?B?STVyNTJTYnBveVNrNkx4a2JpbGFKOXpwNG80WDA0c1ZzYjBYTC9QZE1na2ZT?= =?utf-8?B?c254Tkt4dkladEttWGJ2WjlMaElTNGJSUkl6TTJjWFE5clB3aDVOR0VCR0hC?= =?utf-8?B?OWN1UGxQN2dGYVczZUdsOGdhc2lHYU4xWmEzQUdSeitSbjJTMWxtU1BQYWhX?= =?utf-8?B?bnpBZWUvb3dENW5WdXo0UUNPL0FrSHltRHB5NlpVVGNHWU5aY0RaUT09?= X-OriginatorOrg: wolfvision.net X-MS-Exchange-CrossTenant-Network-Message-Id: 08382655-e351-4e34-223f-08d9e27dfa19 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0802MB2426.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 16:48:14.7657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +yyxzjDwAu+wcec8l/L5Pg+e+O48mOXfFbxlXG0CQT4VKFDrAliAs4BsJ42rYt1m8H/j5+ZaWicjtJ07YI4qw60zzm7+zcErGBcFjG7X23M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7372 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [RFC PATCH v5 5/5] barebox.rockchip: add binary firmware blobs for quartz64 and rk3568-evb1 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: m.tretter@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello Michael, On 1/28/22 17:10, Michael Olbrich wrote: > On Fri, Jan 28, 2022 at 04:26:23PM +0100, Michael Riesch wrote: >> Hello Michael, >> >> Thanks for your review. I'll prepare a v6! >> >> On 1/28/22 13:33, Michael Olbrich wrote: >>> On Mon, Jan 24, 2022 at 01:09:42PM +0100, Michael Riesch wrote: >>>> Currently, the mainline OP-TEE and TF-A sources do not support the >>>> RK356x SoCs. Therefore, the only option is to use the binary blobs >>>> provided by Rockchip. This patch integrates these blobs (along the SDRAM >>>> initialization binary) for the Pine64 Quartz64 board and the RK3568 >>>> EVB1 into barebox. >>>> >>>> Signed-off-by: Michael Riesch >>>> --- >>>> platforms/barebox.rockchip.in | 13 +++++++++++++ >>>> rules/barebox.rockchip.make | 18 ++++++++++++++++++ >>>> 2 files changed, 31 insertions(+) >>>> create mode 100644 rules/barebox.rockchip.make >>>> >>>> diff --git a/platforms/barebox.rockchip.in b/platforms/barebox.rockchip.in >>>> index 8ecdb0762..9aad4eaf8 100644 >>>> --- a/platforms/barebox.rockchip.in >>>> +++ b/platforms/barebox.rockchip.in >>>> @@ -1 +1,14 @@ >>>> ## SECTION=barebox_firmware >>>> + >>>> +config BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>>> + prompt "barebox needs firmware-rockchip" >>>> + bool >>>> + depends on ARCH_ARM64 >>>> + select FIRMWARE_ROCKCHIP if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>> >>> This does not work. It must look like this or the build dependency is not >>> created: >>> >>> config BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>> prompt "barebox needs firmware-rockchip" >>> bool >>> depends on ARCH_ARM64 >>> >>> config BAREBOX >>> select FIRMWARE_ROCKCHIP if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>> >>> Multiple occurrences of the same symbol are merged, so this works just >>> fine as long as 'BAREBOX' is fully defined somewhere else. >> >> I tried this approach but it returns the error >> >> .../ptxdist/platforms/barebox.in:11:error: recursive dependency detected! >> .../ptxdist/platforms/barebox.in:11: symbol BAREBOX depends on BAREBOX >> >> Any idea what could be wrong here? > > Ah, if we resolve any 'source' commands etc. then the whole thing looks > basically like this: > > if BAREBOX > if BAREBOX_FIRMWARE > > config BAREBOX > select FIRMWARE_ROCKCHIP if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > > endif > endif > > and that's the same as > > config BAREBOX > depends on BAREBOX > depends on BAREBOX_FIRMWARE > select FIRMWARE_ROCKCHIP if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > > I think, the only idea is to split that in two files. On with > SECTION=barebox_firmware and one with SECTION=bootloader. Would some kind of dependency symbol do the trick? For example, in barebox.in: config BAREBOXDEP menuconfig BAREBOX select BAREBOXDEP if BAREBOX menuconfig BAREBOX_FIRMWARE ... endif and in barebox.rockchip.in: config BAREBOX_NEEDS_FIRMWARE_ROCKCHIP config BAREBOXDEP select FIRMWARE_ROCKCHIP if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP ? Thanks and best regards, Michael > > It's not very nice, but I don't have a better idea. > > Michael > > >>>> + select FIRMWARE_ROCKCHIP_RK356x_BL31 if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>>> + select FIRMWARE_ROCKCHIP_RK356x_BL32 if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>>> + select FIRMWARE_ROCKCHIP_RK3566_SDRAM if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>>> + select FIRMWARE_ROCKCHIP_RK3568_SDRAM if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>>> + help >>>> + Select this if barebox needs the non-free Rockchip firmware >>>> + blobs. >>>> diff --git a/rules/barebox.rockchip.make b/rules/barebox.rockchip.make >>>> new file mode 100644 >>>> index 000000000..0255b2b4d >>>> --- /dev/null >>>> +++ b/rules/barebox.rockchip.make >>>> @@ -0,0 +1,18 @@ >>>> +# -*-makefile-*- >>>> +# >>>> +# Copyright (C) 2021 by Michael Riesch >>>> +# >>>> +# For further information about the PTXdist project and license conditions >>>> +# see the README file. >>>> +# >>>> + >>>> +ifdef PTXCONF_BAREBOX_NEEDS_FIRMWARE_ROCKCHIP >>>> + >>>> +BAREBOX_INJECT_FILES += rk3568_bl31_v1.24.elf:firmware/rk3568-bl31.bin >>>> +BAREBOX_INJECT_FILES += rk3568_bl32_v1.05.bin:firmware/rk3568-op-tee.bin >>>> + >>>> +BAREBOX_INJECT_FILES += rk3566_ddr_1056MHz_v1.08.bin:arch/arm/boards/pine64-quartz64/sdram-init.bin >>>> + >>>> +BAREBOX_INJECT_FILES += rk3568_ddr_1560MHz_v1.08.bin:arch/arm/boards/rockchip-rk3568-evb/sdram-init.bin >>>> + >>>> +endif >>>> -- >>>> 2.30.2 >>>> >>>> >>>> _______________________________________________ >>>> ptxdist mailing list >>>> ptxdist@pengutronix.de >>>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de >>>> >>> >> > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de