From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 29 Jul 2022 13:23:44 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oHO5o-003WPL-Sd for lore@lore.pengutronix.de; Fri, 29 Jul 2022 13:23:44 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oHO5o-0002T5-9t; Fri, 29 Jul 2022 13:23:44 +0200 Received: from mail.ela-soft.com ([213.23.49.162]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHO5U-0002Sv-LP for ptxdist@pengutronix.de; Fri, 29 Jul 2022 13:23:25 +0200 Received: from [10.0.1.142] (tupai.ela-bln.local [10.0.1.142]) by mail.ela-soft.com (mailsystem) with ESMTPSA id BE677E527 for ; Fri, 29 Jul 2022 13:23:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ela-soft.com; s=2021; t=1659093802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FlFOHVeOzimgdal+VTBne6eblKSHiRWo4UiTJNwO1tI=; b=wsJgCXzvY3EA/t90lkSvzE0mr5Y4sGBXqWkGDCgKVYKOSInh+G33IB5on4g+KbKtgaebec WofWSSrHCTGzg5soDsiaaWGFyrrz29XNffcemrZ+yXOptxn7/0nm+r+uw/ynQDKbnvvMOz wluT+KWT54RhOPzA8Ci0P2R3YzGGE2uUXgVNxtxvCt+mSC3R0XIHDhHCZrHY16r0JbOfaW VyaX6rtNCqyNk0ZfHNp8JPtUebw0e7WI7QmP21y9QNTpqtOGvgIyCrBL1gYB8H4Ix0nS/C NiOnR39HZh4z3Rk/jZfP1Dtqf2WbG9js88tH6eMjaBgkfE4oBBY/iaTo8316Jg== Message-ID: Date: Fri, 29 Jul 2022 13:23:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: de-DE To: ptxdist@pengutronix.de References: <418570e2-7fbd-f917-3cad-98e52247d275@ela-soft.com> <20220729104859.GC20240@pengutronix.de> <20220729105413.GD20240@pengutronix.de> From: Andreas Helmcke In-Reply-To: <20220729105413.GD20240@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-102.2 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] Problems with own get rule X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello, Am 29.07.22 um 12:54 schrieb Michael Olbrich: > On Fri, Jul 29, 2022 at 12:48:59PM +0200, Michael Olbrich wrote: >> On Fri, Jul 29, 2022 at 12:37:50PM +0200, Andreas Helmcke wrote: >>> Hello, >>> >>> i have defined my own get rule to fetch some sources from svn. I did not use the buildin svn support because: >>> 1. there are different svn targets which must get checked out to specific directories >>> 2. i want to use tags, not revision numbers >>> >>> This works pretty well, there is only one problem. >>> >>> After ptxdist menuconfig is called to change the version number, the compile step fails with missing directory because the get rule wont get called. It should, since the source directory does not exists (the directory name contains the version (tag) name). >>> >>> Any advice is appreciated. >> >> Which PTXdist version? I think with a current version, foo.get should be >> called whenever the value of $(FOO) changes. ptxdist version: 2022.05.0 > It's only used indirectly via FOO_SOURCE. Try setting: > > FOO_SOURCE := $(FOO_SRC_DIR) this produces a circular dependency: make: Circular .../svn_src/foo-V2.00.01-B2 <- .../svn_src/foo-V2.00.01-B2 dependency dropped. >>> The make file has this rules: >>> >>>> # >>>> # We provide this package >>>> # >>>> PACKAGES-$(PTXCONF_FOO) += foo >>>> >>>> # >>>> # Paths and names >>>> # >>>> FOO_VERSION := $(call ptx/config-version, PTXCONF_FOO) >>>> FOO_MD5 := >>>> FOO := foo-$(FOO_VERSION) >>>> FOO_SRC_DIR := $(PTXDIST_WORKSPACE)/svn_src/$(FOO) >>>> FOO_URL := lndir://$(FOO_SRC_DIR) >>>> FOO_DIR := $(BUILDDIR)/$(FOO) >>>> FOO_LICENSE := unknown >>>> >>>> FOO_SVN_BASE_URL := \ >>>> https://subversion.company.com/entwicklung/foo_bar/foo/tags/$(FOO_VERSION) >>>> >>>> # ---------------------------------------------------------------------------- >>>> # Get >>>> # ---------------------------------------------------------------------------- >>>> >>>> $(STATEDIR)/foo.get: >>>> @$(call targetinfo) >>>> @$(call clean, $(FOO_SRC_DIR)) >>>> @svn export \ >>>> $(FOO_SVN_BASE_URL)/foo/phyCard-release $(FOO_SRC_DIR)/foo/phyCard-release >>>> @svn export \ >>>> $(FOO_SVN_BASE_URL)/foo/src $(FOO_SRC_DIR)/foo/src >>>> @$(call touch) >>>> >>>> >>>> # ---------------------------------------------------------------------------- >>>> # Extract >>>> # ---------------------------------------------------------------------------- >>>> >>>> $(STATEDIR)/foo.extract: >>>> @$(call targetinfo) >>>> @$(call clean, $(FOO_DIR)) >>>> @$(call extract, FOO) >>>> @$(call patchin, FOO) >>>> @$(call touch) >>> >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> >> >