Re: [ptxdist] [PATCH 23/23] xorg-fonts: make all xorg-font-ttf packages tristate

["Baeuerle, Florian" <Florian.Baeuerle@allegion.com>]

Hi Juergen,

Am Donnerstag, den 02.08.2018, 07:25 +0200 schrieb Juergen Borleis:
> Hi Florian,
> 
> On Wednesday 01 August 2018 20:32:00 Florian Bäuerle wrote:
> > [...]
> > 
> > diff --git a/rules/graphics_and_multimedia.in
> > b/rules/graphics_and_multimedia.in index 54e53ad7a..f96a381e3 100644
> > --- a/rules/graphics_and_multimedia.in
> > +++ b/rules/graphics_and_multimedia.in
> > @@ -1,7 +1,7 @@
> >  ## SECTION=graphics_and_multimedia
> > 
> >  menuconfig MENU_XORG_FONTS
> > -	bool
> > +	tristate
> >  	prompt "fonts                         "
> >  	select XORG_LIB_XFONT_PCF_FONTS if XORG_SERVER
> >  	default y if XORG_SERVER
> > @@ -13,7 +13,7 @@ if MENU_XORG_FONTS
> > 
> >  config XORG_FONTS
> >  	depends on MENU_XORG_FONTS
> > -	bool
> > +	tristate
> >  	select XORG_FONT_UTIL
> >  	select XORG_FONT_ALIAS
> >  	select HOST_XORG_APP_MKFONTDIR
> > @@ -25,7 +25,7 @@ config XORG_FONTS
> >  config XORG_FONTS_FC_CACHE
> >  	default FONTCONFIG
> >  	select FONTCONFIG_UTILS
> > -	bool
> > +	tristate
> 
> These changes conform to the subject.
> 
> >  config XORG_FONTS_QT4_LINKS
> >  	depends on QT4_PLATFORM_EMBEDDED
> > diff --git a/rules/xorg-font-adobe-100dpi.in
> > b/rules/xorg-font-adobe-100dpi.in index e890885d6..66c0ec5c0 100644
> > --- a/rules/xorg-font-adobe-100dpi.in
> > +++ b/rules/xorg-font-adobe-100dpi.in
> > @@ -1,7 +1,7 @@
> >  ## SECTION=multimedia_xorg_font_100dpi
> > 
> >  config XORG_FONT_ADOBE_100DPI
> > -	tristate
> > +	bool
> 
> This change doesn't conform to the subject.

Oh sorry, I must confess that i edited the in-files with sed. I will carefully
review the changes again. Thanks!

> 
> BTW: Can you drop a few more words in the commit logs why you do this 
> change? What is the intention?
> 

Once more sorry about that, I'm relatively new to git send-email and the workflow
with mailing lists. I learned about --compose just after I sent those patches.

So basically the intention is to get the ability to (de)select ttf fonts via collection.
Michael pointed out some problems with my first attempt to doing so [1].

Most font-packages copy their fonts during targetinstall into xorg-fonts PKGDIR.
xorg-fonts then does some post-processing (mkfontdir and mkfontscale).

With these patches, all available ttf fonts are packaged individually instead.

> Cheers,
> Jürgen
> 

Best Regards,
Florian

1: https://www.mail-archive.com/ptxdist@pengutronix.de/msg13129.html
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de