From: Jon Ringle <jon@ringle.org>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] kernel: rework prepare stage
Date: Fri, 22 Feb 2019 12:23:37 -0500 (EST) [thread overview]
Message-ID: <alpine.DEB.2.21.1902221217190.15534@jring-w510-7m3g.gridpoint.com> (raw)
In-Reply-To: <20190222081156.12582-1-m.olbrich@pengutronix.de>
On Fri, 22 Feb 2019, Michael Olbrich wrote:
> The old implementation is broken, when a initramfs is used.
> Changing the kconfig symbol back to '# Automatically set by PTXDist' is
> broken because '$(<)' is not the kernel config any more (Broken since
> cd920ab716bab0c190666e0273c10b19c7cdaeec "barebox/kernel: drop explicit
> dependency").
> Also, world/kconfig-sync compares .config and KERNEL_CONFIG and this does
> not work because CONFIG_INITRAMFS_SOURCE in .config has been modified.
>
> Instead, make sure that KERNEL_CONFIG contains the path independent dummy
> text before copying it to .config.
> Then run the default prepare stage that checks or updates the config.
> Insert the path for the empty initramfs after all checks are done.
>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
>
> Hi Jon,
>
> The initramfs handling is completely broken :-/. Can you try this patch?
> That should fix your problem. I've queued this for master, but I'm still
> waiting for some test results before pushing this.
>
Tested with 'ssh localhost "cd $(pwd); ptxdist images"'
Looks good.
Tested-by: Jon Ringle <jringle@gridpoint.com>
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2019-02-22 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 16:11 [ptxdist] Problems building kernel image with initramfs with no tty Jon Ringle
2019-02-22 8:11 ` [ptxdist] [PATCH] kernel: rework prepare stage Michael Olbrich
2019-02-22 17:23 ` Jon Ringle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1902221217190.15534@jring-w510-7m3g.gridpoint.com \
--to=jon@ringle.org \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox