From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 15 Jul 2026 12:55:19 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wjxGp-0040zU-1Z for lore@lore.pengutronix.de; Wed, 15 Jul 2026 12:55:19 +0200 Received: from [127.0.0.1] (helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wjxGn-0001bM-Fu; Wed, 15 Jul 2026 12:55:17 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wjxGd-0001VS-EY; Wed, 15 Jul 2026 12:55:07 +0200 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 227BC20221B; Wed, 15 Jul 2026 12:55:07 +0200 (CEST) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wjxGd-001vHn-05; Wed, 15 Jul 2026 12:55:07 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wjxGc-00000001G70-3y6g; Wed, 15 Jul 2026 12:55:06 +0200 Date: Wed, 15 Jul 2026 12:55:06 +0200 From: Michael Olbrich To: Sven =?utf-8?Q?P=C3=BCschel?= Message-ID: References: <20260714082724.446541-1-s.pueschel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260714082724.446541-1-s.pueschel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v3] lvm2: move lvmdump and fsadm into separate options X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, Jul 14, 2026 at 10:14:50AM +0200, Sven Püschel wrote: > Move lvmdump and the fsadm command into a separate option, as both > commands are bash scripts and therefore need bash as a dependency. > As these commands may not be used, we don't add bash as a dependency to > the much bigger LVM2_LVM_TOOLS option but instead add distinct options > for these commands. > > Signed-off-by: Sven Püschel > > --- > v3 > - added new options instead of adding bash to LVM2_LVM_TOOLS > - added RUNTIME flag to the bash dependency > v2 > - added > --- > rules/lvm2.in | 11 +++++++++++ > rules/lvm2.make | 7 ++++++- > 2 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/rules/lvm2.in b/rules/lvm2.in > index 3213d9c31..6eae0a2de 100644 > --- a/rules/lvm2.in > +++ b/rules/lvm2.in > @@ -8,6 +8,7 @@ menuconfig LVM2 > select READLINE > select NCURSES > select SYSTEMD if LVM2_SYSTEMD > + select BASH if (LVM2_FSADM || LVM2_LVMDUMP) && RUNTIME > prompt "lvm2 " > help > LVM2 refers to a new userspace toolset that provide logical volume management > @@ -32,6 +33,16 @@ config LVM2_STARTSCRIPT > depends on INITMETHOD_BBINIT > prompt "install /etc/init.d/lvm2" > > +config LVM2_FSADM I think you need to select LVM2_LVM_TOOLS here. The scripts probably don't make sense without the actual binaries and the targetinstall stage will fail as well. > + bool > + default y No 'default y' I think. These are tools typically used during development. And automatically enabling bash during an update is not so nice. > + prompt "install the fsadm command" > + > + > +config LVM2_LVMDUMP > + bool > + default y Same here. Michael > + prompt "install the lvmdump command" > endif > > config LVM2_LIBDEVMAPPER_EVENT > diff --git a/rules/lvm2.make b/rules/lvm2.make > index 57773a1f7..b5aea9873 100644 > --- a/rules/lvm2.make > +++ b/rules/lvm2.make > @@ -110,10 +110,15 @@ $(STATEDIR)/lvm2.targetinstall: > > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/dmsetup) > > -ifdef PTXCONF_LVM2_LVM_TOOLS > +ifdef PTXCONF_LVM2_FSADM > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/fsadm) > +endif > + > +ifdef PTXCONF_LVM2_LVMDUMP > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/lvmdump) > +endif > > +ifdef PTXCONF_LVM2_LVM_TOOLS > @$(call install_copy, lvm2, 0, 0, 0755, -, /usr/sbin/lvm) > @$(call install_link, lvm2, lvm, /usr/sbin/lvchange) > @$(call install_link, lvm2, lvm, /usr/sbin/lvconvert) > -- > 2.47.3 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |