mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Artur Wiebe via ptxdist <ptxdist@pengutronix.de>
Cc: Artur Wiebe <artur@4wiebe.de>
Subject: Re: [ptxdist] [PATCH] mesalib: enable legacy-wayland=bind-wayland-display for wpebackend-fdo
Date: Fri, 26 Jun 2026 18:38:08 +0200	[thread overview]
Message-ID: <aj6q8F15KLuA-gG3@pengutronix.de> (raw)
In-Reply-To: <20260625115021.2433949-1-artur@4wiebe.de>

On Thu, Jun 25, 2026 at 01:50:21PM +0200, Artur Wiebe via ptxdist wrote:
> Mesa 25.2 deprecated EGL_WL_bind_wayland_display and moved it behind the
> -Dlegacy-wayland=bind-wayland-display build option. Without it, Mesa no
> longer exposes the EGL_WL_bind_wayland_display extension at runtime.
> 
> wpebackend-fdo calls eglBindWaylandDisplayWL (obtained via eglGetProcAddress
> on EGL_WL_bind_wayland_display) to allow the Wayland compositor side to
> import wl_buffer resources as EGLImages using EGL_WAYLAND_BUFFER_WL. This
> is still the only path available for non-dmabuf, non-SHM wl_buffers in the
> wpebackend-fdo EGL compositor backend.

This is not something that should be enabled unconditionally. Please create
a kconfig option for with, without prompt and select that from
wpebackend-fdo. That way, it is clear that it is only needed for that.

Michael

> Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> ---
>  rules/mesalib.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/mesalib.make b/rules/mesalib.make
> index 7eddb97ce..040863b13 100644
> --- a/rules/mesalib.make
> +++ b/rules/mesalib.make
> @@ -263,7 +263,7 @@ MESALIB_CONF_OPT	:= \
>  	-Dintel-elk=true \
>  	-Dintel-rt=disabled \
>  	-Dintel-virtio-experimental=false \
> -	-Dlegacy-wayland=[] \
> +	-Dlegacy-wayland=bind-wayland-display \
>  	-Dlibgbm-external=false \
>  	-Dlibunwind=disabled \
>  	-Dllvm=$(call ptx/endis, PTXCONF_MESALIB_LLVM)d \
> -- 
> 2.54.0
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2026-06-26 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25 11:50 Artur Wiebe via ptxdist
2026-06-26 16:38 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aj6q8F15KLuA-gG3@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=artur@4wiebe.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox