From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 19 Sep 2025 07:43:43 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uzTuJ-004kB3-1A for lore@lore.pengutronix.de; Fri, 19 Sep 2025 07:43:43 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uzTuJ-0004Ny-5P; Fri, 19 Sep 2025 07:43:43 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uzTuC-0004NQ-KN; Fri, 19 Sep 2025 07:43:36 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uzTuC-0023Xw-1Q; Fri, 19 Sep 2025 07:43:36 +0200 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uzTuC-000KOI-18; Fri, 19 Sep 2025 07:43:36 +0200 Date: Fri, 19 Sep 2025 07:43:36 +0200 From: Michael Olbrich To: Fabian Pfitzner , ptxdist@pengutronix.de Message-ID: Mail-Followup-To: Fabian Pfitzner , ptxdist@pengutronix.de References: <20250905144424.620258-2-f.pfitzner@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-IRC: #ptxdist @freenode Subject: Re: [ptxdist] [PATCH 1/2] openh264: new package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Fri, Sep 19, 2025 at 07:30:34AM +0200, Michael Olbrich wrote: > On Fri, Sep 05, 2025 at 04:44:24PM +0200, Fabian Pfitzner wrote: > > Signed-off-by: Fabian Pfitzner > > --- > > rules/openh264.in | 8 +++++++ > > rules/openh264.make | 54 +++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 62 insertions(+) > > create mode 100644 rules/openh264.in > > create mode 100644 rules/openh264.make > > > > diff --git a/rules/openh264.in b/rules/openh264.in > > new file mode 100644 > > index 000000000..069cd22d2 > > --- /dev/null > > +++ b/rules/openh264.in > > @@ -0,0 +1,8 @@ > > +## SECTION=multimedia_libs > > + > > +config OPENH264 > > + bool > > + prompt "openh264" > > + select HOST_MESON > > + help > > + Enable OpenH264 codec > > diff --git a/rules/openh264.make b/rules/openh264.make > > new file mode 100644 > > index 000000000..032636d09 > > --- /dev/null > > +++ b/rules/openh264.make > > @@ -0,0 +1,54 @@ > > +# -*-makefile-*- > > +# > > +# Copyright (C) 2025 by Fabian Pfitzner > > +# > > +# For further information about the PTXdist project and license conditions > > +# see the README file. > > +# > > + > > +# > > +# We provide this package > > +# > > +PACKAGES-$(PTXCONF_OPENH264) += openh264 > > + > > +# > > +# Paths and names > > +# > > +OPENH264_VERSION := 2.6.0 > > +OPENH264_MD5 := 0b01f0279eca1c7bb65395ea350fa85c > > +OPENH264 := OpenH264-$(OPENH264_VERSION) > > +OPENH264_SUFFIX := tar.gz > > +OPENH264_URL := https://github.com/cisco/openh264/archive/refs/tags/v$(OPENH264_VERSION).$(OPENH264_SUFFIX) > > +OPENH264_SOURCE := $(SRCDIR)/$(OPENH264).$(OPENH264_SUFFIX) > > +OPENH264_DIR := $(BUILDDIR)/$(OPENH264) > > +OPENH264_LICENSE := GPL-2.0-or-later And the ':=' are not properly aligned. Michael > > This license looks wrong. Please check and add the license file(s) as well. > > Michael > > > + > > +# ---------------------------------------------------------------------------- > > +# Prepare > > +# ---------------------------------------------------------------------------- > > + > > +OPENH264_CONF_TOOL := meson > > +OPENH264_CONF_OPT := \ > > + $(CROSS_MESON_USR) \ > > + -Dtests=disabled > > + > > +# ---------------------------------------------------------------------------- > > +# Target-Install > > +# ---------------------------------------------------------------------------- > > + > > +$(STATEDIR)/openh264.targetinstall: > > + @$(call targetinfo) > > + > > + @$(call install_init, openh264) > > + @$(call install_fixup, openh264,PRIORITY,optional) > > + @$(call install_fixup, openh264,SECTION,base) > > + @$(call install_fixup, openh264,AUTHOR,"Fabian Pfitzner ") > > + @$(call install_fixup, openh264,DESCRIPTION,missing) > > + > > + @$(call install_lib, openh264, 0, 0, 0644, libopenh264) > > + > > + @$(call install_finish, openh264) > > + > > + @$(call touch) > > + > > +# vim: syntax=make > > -- > > 2.47.2 > > > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |