Re: [ptxdist] [PATCH 1/2] openh264: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Sep 19, 2025 at 07:30:34AM +0200, Michael Olbrich wrote:
> On Fri, Sep 05, 2025 at 04:44:24PM +0200, Fabian Pfitzner wrote:
> > Signed-off-by: Fabian Pfitzner <f.pfitzner@pengutronix.de>
> > ---
> >  rules/openh264.in   |  8 +++++++
> >  rules/openh264.make | 54 +++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 62 insertions(+)
> >  create mode 100644 rules/openh264.in
> >  create mode 100644 rules/openh264.make
> > 
> > diff --git a/rules/openh264.in b/rules/openh264.in
> > new file mode 100644
> > index 000000000..069cd22d2
> > --- /dev/null
> > +++ b/rules/openh264.in
> > @@ -0,0 +1,8 @@
> > +## SECTION=multimedia_libs
> > +
> > +config OPENH264
> > +	bool
> > +	prompt "openh264"
> > +	select HOST_MESON
> > +	help
> > +	  Enable OpenH264 codec
> > diff --git a/rules/openh264.make b/rules/openh264.make
> > new file mode 100644
> > index 000000000..032636d09
> > --- /dev/null
> > +++ b/rules/openh264.make
> > @@ -0,0 +1,54 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2025 by Fabian Pfitzner <f.pfitzner@pengutronix.de>
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_OPENH264) += openh264
> > +
> > +#
> > +# Paths and names
> > +#
> > +OPENH264_VERSION	:= 2.6.0
> > +OPENH264_MD5		:= 0b01f0279eca1c7bb65395ea350fa85c
> > +OPENH264		:= OpenH264-$(OPENH264_VERSION)
> > +OPENH264_SUFFIX	:= tar.gz
> > +OPENH264_URL		:= https://github.com/cisco/openh264/archive/refs/tags/v$(OPENH264_VERSION).$(OPENH264_SUFFIX)
> > +OPENH264_SOURCE	:= $(SRCDIR)/$(OPENH264).$(OPENH264_SUFFIX)
> > +OPENH264_DIR		:= $(BUILDDIR)/$(OPENH264)
> > +OPENH264_LICENSE	:= GPL-2.0-or-later

And the ':=' are not properly aligned.

Michael

> 
> This license looks wrong. Please check and add the license file(s) as well.
> 
> Michael
> 
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +OPENH264_CONF_TOOL	:= meson
> > +OPENH264_CONF_OPT	:= \
> > +	$(CROSS_MESON_USR) \
> > +	-Dtests=disabled
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/openh264.targetinstall:
> > +	@$(call targetinfo)
> > +
> > +	@$(call install_init, openh264)
> > +	@$(call install_fixup, openh264,PRIORITY,optional)
> > +	@$(call install_fixup, openh264,SECTION,base)
> > +	@$(call install_fixup, openh264,AUTHOR,"Fabian Pfitzner <f.pfitzner@pengutronix.de>")
> > +	@$(call install_fixup, openh264,DESCRIPTION,missing)
> > +
> > +	@$(call install_lib, openh264, 0, 0, 0644, libopenh264)
> > +
> > +	@$(call install_finish, openh264)
> > +
> > +	@$(call touch)
> > +
> > +# vim: syntax=make
> > -- 
> > 2.47.2
> > 
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |